You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/29 22:16:30 UTC

[GitHub] [airflow] mik-laj commented on issue #22727: google provider - GKEStartPodOperator without gcloud to get conf

mik-laj commented on issue #22727:
URL: https://github.com/apache/airflow/issues/22727#issuecomment-1140534674

   @rbiegacz Are you interested to take care of this? I will be happy to help with the implementation of this issue, but I do not have the capacity to check all edge cases especially handling internal IP addresses (`use_internal_ip` parameter in ` GKEStartPodOperator`), handling impersonation.
   
   We can be inspired by how `google-github-actions/get-gke-credentials` action is works
   https://github.com/google-github-actions/get-gke-credentials/blob/fa30d95d807daeddd45dd78b8f594d56c0737a73/src/gkeClient.ts#L186-L222
   We also have access to the source code of gcloud:
   https://github.com/google-cloud-sdk-unofficial/google-cloud-sdk/blob/151b8e4a9d82014cc9ef4b10a3a0be5a1bb95cc0/lib/surface/container/clusters/get_credentials.py
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org