You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Daniel Halperin (JIRA)" <ji...@apache.org> on 2016/04/06 23:19:25 UTC
[jira] [Created] (BEAM-178) stdout vs logging in
DataflowPipelineRunner?
Daniel Halperin created BEAM-178:
------------------------------------
Summary: stdout vs logging in DataflowPipelineRunner?
Key: BEAM-178
URL: https://issues.apache.org/jira/browse/BEAM-178
Project: Beam
Issue Type: Bug
Components: runner-dataflow
Reporter: Daniel Halperin
Assignee: Davor Bonaci
Priority: Minor
We seem to thoroughly intermingle logging and println. Is this deliberate?
e.g.,
{code}
LOG.info("To access the Dataflow monitoring console, please navigate to {}",
MonitoringUtil.getJobMonitoringPageURL(options.getProject(), jobResult.getId()));
System.out.println("Submitted job: " + jobResult.getId());
{code}
Original genesis for this was noticing a println in a backport Cl: https://github.com/apache/incubator-beam/blob/master/sdks/java/core/src/main/java/com/google/cloud/dataflow/sdk/runners/DataflowPipelineRunner.java#L451
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [jira] [Created] (BEAM-178) stdout vs logging in DataflowPipelineRunner?
Posted by Lukasz Cwik <lc...@google.com>.
I think this was because we wanted to make sure the user would get at least
the fact that they submitted a pipeline even if they haven't setup logging
correctly.
On Wed, Apr 6, 2016 at 2:19 PM, Daniel Halperin (JIRA) <ji...@apache.org>
wrote:
> Daniel Halperin created BEAM-178:
> ------------------------------------
>
> Summary: stdout vs logging in DataflowPipelineRunner?
> Key: BEAM-178
> URL: https://issues.apache.org/jira/browse/BEAM-178
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Daniel Halperin
> Assignee: Davor Bonaci
> Priority: Minor
>
>
> We seem to thoroughly intermingle logging and println. Is this deliberate?
>
> e.g.,
>
> {code}
> LOG.info("To access the Dataflow monitoring console, please navigate
> to {}",
> MonitoringUtil.getJobMonitoringPageURL(options.getProject(),
> jobResult.getId()));
> System.out.println("Submitted job: " + jobResult.getId());
> {code}
>
> Original genesis for this was noticing a println in a backport Cl:
> https://github.com/apache/incubator-beam/blob/master/sdks/java/core/src/main/java/com/google/cloud/dataflow/sdk/runners/DataflowPipelineRunner.java#L451
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>
Re: [jira] [Created] (BEAM-178) stdout vs logging in DataflowPipelineRunner?
Posted by Lukasz Cwik <lc...@google.com.INVALID>.
I think this was because we wanted to make sure the user would get at least
the fact that they submitted a pipeline even if they haven't setup logging
correctly.
On Wed, Apr 6, 2016 at 2:19 PM, Daniel Halperin (JIRA) <ji...@apache.org>
wrote:
> Daniel Halperin created BEAM-178:
> ------------------------------------
>
> Summary: stdout vs logging in DataflowPipelineRunner?
> Key: BEAM-178
> URL: https://issues.apache.org/jira/browse/BEAM-178
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Daniel Halperin
> Assignee: Davor Bonaci
> Priority: Minor
>
>
> We seem to thoroughly intermingle logging and println. Is this deliberate?
>
> e.g.,
>
> {code}
> LOG.info("To access the Dataflow monitoring console, please navigate
> to {}",
> MonitoringUtil.getJobMonitoringPageURL(options.getProject(),
> jobResult.getId()));
> System.out.println("Submitted job: " + jobResult.getId());
> {code}
>
> Original genesis for this was noticing a println in a backport Cl:
> https://github.com/apache/incubator-beam/blob/master/sdks/java/core/src/main/java/com/google/cloud/dataflow/sdk/runners/DataflowPipelineRunner.java#L451
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>