[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #470: Add support for displaying variables in the debugger

[GitBox <gi...@apache.org>]

mbeckerle commented on a change in pull request #470:
URL: https://github.com/apache/incubator-daffodil/pull/470#discussion_r556772661



##########
File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/debugger/InteractiveDebugger.scala
##########
@@ -1404,6 +1469,24 @@ class InteractiveDebugger(runner: InteractiveDebuggerRunner, eCompilers: Express
               if (prestate.arrayPos != state.arrayPos) { debugPrintln("occursIndex: %d -> %d".format(prestate.arrayPos, state.arrayPos), "  "); diff = true }
               if (prestate.groupPos != state.groupPos) { debugPrintln("groupIndex: %d -> %d".format(prestate.groupPos, state.groupPos), "  "); diff = true }
               if (prestate.childPos != state.childPos) { debugPrintln("childIndex: %d -> %d".format(prestate.childPos, state.childPos), "  "); diff = true }
+              prestate.variableMap.qnames.foreach { qname =>

Review comment:
       Yeah, this is good. diff shows variables that changed. Great. 
   +1




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org