[jira] [Commented] (SAMZA-1366) ScriptRunner should allow callers to control the child process environment.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111206#comment-16111206 ] 

ASF GitHub Bot commented on SAMZA-1366:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/samza/pull/245


> ScriptRunner should allow callers to control the child process environment.
> ---------------------------------------------------------------------------
>
>                 Key: SAMZA-1366
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1366
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Jake Maes
>            Assignee: Jake Maes
>             Fix For: 0.13.1
>
>
> The ScriptRunner class used by samza-rest currently uses the defaults for ProcessBuilder to construct the child process and by default, all environment variables are forwarded to the child process. 
> This causes problems with log settings (e.g. console vs file), class path, config collisions, etc. 
> The goals of this ticket are:
> 1. Allow the caller to dictate whether to forward the environment variables or start with a clean slate.
> 2. Allow the caller to explicitly specify environment variables to add to the child environment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)