You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tooling.apache.org by "sbp (via GitHub)" <gi...@apache.org> on 2026/09/30 19:51:54 UTC

[I] Document source-control metadata handling for audits (tooling-trusted-releases)

sbp opened a new issue, #1680:
URL: https://github.com/apache/tooling-trusted-releases/issues/1680

   The Puppet deployment manifest clones the application source using Git (`provider => git`), which creates a `.git` directory in the source path. The Docker image is then built from this directory (`cwd => $source_dir`), meaning the `.git` directory is likely included in the container's filesystem. Additionally, the application code in `atr/metadata.py` actively reads the `.git` directory via the `dunamai` library for version detection, confirming the code path expects `.git` to be present.
   
   ```puppet
   # deploy/puppet/manifests/tooling/atr_container.pp
   vcsrepo { $source_dir:
       ensure   => latest,
       provider => git,
       source   => 'https://github.com/apache/tooling-trusted-releases.git',
       revision => $ref,
       user     => $user,
       require  => [Package['git'], File[$source_dir], User[$user]],
   }
   
   exec { "build-docker-image-${title}":
       command     => "make build IMAGE=${image_name}",
       path        => '/bin:/usr/bin',
       cwd         => $source_dir,
       require     => Class['docker'],
       subscribe   => Vcsrepo[$source_dir],
       refreshonly => true,
       timeout     => $build_timeout,
       notify      => Docker::Run[$image_name],
   }
   ```
   
   ```python
   # atr/metadata.py - _get_version_from_git()
   def _get_version_from_git() -> tuple[str, str] | None:
       try:
           import dunamai
       except ImportError:
           return None
       project_root = pathlib.Path(__file__).resolve().parent.parent
       if not (project_root / ".git").exists():
           return None
       version = dunamai.Version.from_git(path=project_root)
       ...
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Document source-control metadata handling for audits (tooling-trusted-releases)

Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp commented on issue #1680:
URL: https://github.com/apache/tooling-trusted-releases/issues/1680#issuecomment-5918538935

   ASVS triage: Park this in the future track for audit guidance. #1124 records that the final deployed image excludes source-control metadata; clarify this for future reviews.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Document source-control metadata handling for audits (tooling-trusted-releases)

Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp closed issue #1680: Document source-control metadata handling for audits
URL: https://github.com/apache/tooling-trusted-releases/issues/1680


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org