You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by charsyam <gi...@git.apache.org> on 2015/04/18 09:10:19 UTC
[GitHub] tajo pull request: TAJO-1570 CatalogUtil newSimpleDataTypeArray sh...
GitHub user charsyam opened a pull request:
https://github.com/apache/tajo/pull/542
TAJO-1570 CatalogUtil newSimpleDataTypeArray should use newSimpleDataType
It is better CatalogUtil's newSimpleDataTypeArray method use newSimpleDataType. Because their purpose is the same.
and it is efficient when someone change newSimpleDataType method.
```java
public static DataType [] newSimpleDataTypeArray(Type... types) {
DataType [] dataTypes = new DataType[types.length];
for (int i = 0; i < types.length; i++)
{ dataTypes[i] = DataType.newBuilder().setType(types[i]).build(); }
return dataTypes;
}
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/charsyam/tajo feature/refactoring-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/542.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #542
----
commit 539069dab0c94b40c5d603059f1964b47a2c8d3f
Author: clark.kang <cl...@kakao.com>
Date: 2015-04-18T06:44:44Z
refactoring
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1570 CatalogUtil newSimpleDataTypeArray sh...
Posted by charsyam <gi...@git.apache.org>.
Github user charsyam commented on the pull request:
https://github.com/apache/tajo/pull/542#issuecomment-94270314
@jihoonson I rebased it. and it passed :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1570 CatalogUtil newSimpleDataTypeArray sh...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/542#issuecomment-94263436
This change is trivial, but will reduce many mistakes.
Would you trigger Travis or Jenkins again after rebasing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1570 CatalogUtil newSimpleDataTypeArray sh...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/542
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1570 CatalogUtil newSimpleDataTypeArray sh...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/542#issuecomment-94270352
+1 thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---