You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org> on 2026/06/19 00:20:21 UTC

[Impala-ASF-CR] CDPD-106263: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24483


Change subject: CDPD-106263: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................

CDPD-106263: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

HIVE-26537 renamed some methods in AbstractThriftHiveMetastore that
were overridden in MetastoreServiceHandler and
CatalogMetastoreServiceHandler, which are instantiated in
CatalogHmsSyncToLatestEventIdTest. Due to this, requests from a
HiveMetaStoreClient were routed to the methods for which there was no
implementation in Impala, causing this Java test to fail. This patch
fixed the issue.

- Testing:
 Verified that CatalogHmsSyncToLatestEventIdTest is fixed with this
 patch.

Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
---
M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
2 files changed, 59 insertions(+), 38 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/24483/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>

[Impala-ASF-CR] IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24483

to look at the new patch set (#10).

Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................

IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

HIVE-26537 renamed some methods in AbstractThriftHiveMetastore that
were overridden in MetastoreServiceHandler and
CatalogMetastoreServiceHandler, which are instantiated in
CatalogHmsSyncToLatestEventIdTest. Due to this, requests from a
HiveMetaStoreClient were routed to the methods for which there was no
implementation in Impala, causing this Java test to fail. This patch
fixed the issue by renaming those overridden methods in Impala.

After renaming those overridden methods in Impala, we also had to fix
some end-to-end tests in test_metastore_service.py in which the
catalog server is started with "--start_hms_server=true" so that the
Hive MetaStore client will submit the requests to the renamed API's.

Testing:
 - Verified that CatalogHmsSyncToLatestEventIdTest is fixed with this
   patch.
 - Verified that the tests in test_metastore_service.py in which the
   catalog server is started with "--start_hms_server=true" are passed
   with this patch.

Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
---
M fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java
M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java
M fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java
M tests/custom_cluster/test_metastore_service.py
6 files changed, 106 insertions(+), 66 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/24483/10
-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 10
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/24483 )

Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................

IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

HIVE-26537 renamed some methods in AbstractThriftHiveMetastore that
were overridden in MetastoreServiceHandler and
CatalogMetastoreServiceHandler, which are instantiated in
CatalogHmsSyncToLatestEventIdTest. Due to this, requests from a
HiveMetaStoreClient were routed to the methods for which there was no
implementation in Impala, causing this Java test to fail. This patch
fixed the issue.

- Testing:
 Verified that CatalogHmsSyncToLatestEventIdTest is fixed with this
 patch.

Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
---
M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
2 files changed, 59 insertions(+), 38 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/24483/2
-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>

[Impala-ASF-CR] CDPD-106263: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24483

to look at the new patch set (#3).

Change subject: CDPD-106263: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................

CDPD-106263: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

HIVE-26537 renamed some methods in AbstractThriftHiveMetastore that
were overridden in MetastoreServiceHandler and
CatalogMetastoreServiceHandler, which are instantiated in
CatalogHmsSyncToLatestEventIdTest. Due to this, requests from a
HiveMetaStoreClient were routed to the methods for which there was no
implementation in Impala, causing this Java test to fail. This patch
fixed the issue by renaming those overridden methods in Impala.

After renaming those overridden methods in Impala, we also had to fix
some end-to-end tests in test_metastore_service.py in which the
catalog server is started with "--start_hms_server=true" so that the
Hive MetaStore client will submit the requests to the renamed API's.

Testing:
 - Verified that CatalogHmsSyncToLatestEventIdTest is fixed with this
   patch.
 - Verified that the tests in test_metastore_service.py in which the
   catalog server is started with "--start_hms_server=true" are passed
   with this patch.

Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
---
M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M tests/custom_cluster/test_metastore_service.py
3 files changed, 90 insertions(+), 46 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/24483/3
-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has abandoned this change. ( http://gerrit.cloudera.org:8080/24483 )

Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................


Abandoned

Abandon this since we will be using https://gerrit.cloudera.org/c/24508/ instead.
-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 9
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24483 )

Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................


Patch Set 3:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/22964/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jun 2026 21:05:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] CDPD-106263: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24483 )

Change subject: CDPD-106263: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................


Patch Set 8:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/22990/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 8
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jun 2026 17:05:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has restored this change. ( http://gerrit.cloudera.org:8080/24483 )

Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................


Restored
-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: restore
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 9
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24483 )

Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................


Patch Set 11: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 11
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Aug 2026 23:49:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24483 )

Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................

IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

HIVE-26537 renamed some methods in AbstractThriftHiveMetastore that
were overridden in MetastoreServiceHandler and
CatalogMetastoreServiceHandler, which are instantiated in
CatalogHmsSyncToLatestEventIdTest. Due to this, requests from a
HiveMetaStoreClient were routed to the methods for which there was no
implementation in Impala, causing this Java test to fail. This patch
fixed the issue by renaming those overridden methods in Impala.

After renaming those overridden methods in Impala, we also had to fix
some end-to-end tests in test_metastore_service.py in which the
catalog server is started with "--start_hms_server=true" so that the
Hive MetaStore client will submit the requests to the renamed API's.

Testing:
 - Verified that CatalogHmsSyncToLatestEventIdTest is fixed with this
   patch.
 - Verified that the tests in test_metastore_service.py in which the
   catalog server is started with "--start_hms_server=true" are passed
   with this patch.

Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Reviewed-on: http://gerrit.cloudera.org:8080/24483
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Fang-Yu Rao <fa...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java
M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java
M fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java
M tests/custom_cluster/test_metastore_service.py
6 files changed, 106 insertions(+), 66 deletions(-)

Approvals:
  Michael Smith: Looks good to me, approved
  Fang-Yu Rao: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 12
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24483 )

Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................


Patch Set 10:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/23774/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 10
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Aug 2026 22:09:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24483 )

Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................


Patch Set 7:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/22969/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 7
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jun 2026 22:42:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] CDPD-106263: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24483 )

Change subject: CDPD-106263: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24483/8//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24483/8//COMMIT_MSG@7
PS8, Line 7: CDPD-106263: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
Shouldn't use CDPD ticket number.


http://gerrit.cloudera.org:8080/#/c/24483/8//COMMIT_MSG@9
PS8, Line 9: HIVE-26537 renamed some methods in AbstractThriftHiveMetastore that
This won't build until we build against a version of Hive with that change.

How are we going to handle this for Hive 2 and Hive 3 compatibility?



-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 8
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jun 2026 17:34:09 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24483 )

Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................


Patch Set 10:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/24483/8//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24483/8//COMMIT_MSG@7
PS8, Line 7: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
> Shouldn't use CDPD ticket number.
Done


http://gerrit.cloudera.org:8080/#/c/24483/8//COMMIT_MSG@9
PS8, Line 9: HIVE-26537 renamed some methods in AbstractThriftHiveMetastore that
> This won't build until we build against a version of Hive with that change.
It turns out this patch could pass https://jenkins.impala.io/job/all-build-options-ub2004/4719/. I also triggered https://jenkins.impala.io/job/gerrit-verify-dryrun-external/3782/ against the chain of commits to see how things are going.


http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java
File fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java:

http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java@50
PS5, Line 50: import org.apache.hadoop.hive.metastore.api.FileMetadata;
> unused import: org.apache.hadoop.hive.metastore.api.FieldSchema
Done


http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
File fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java:

http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@57
PS5, Line 57: import org.apache.hadoop.hive.metastore.api.RenamePartitionRequest;
> unused import: org.apache.hadoop.hive.metastore.api.PrincipalType
Done


http://gerrit.cloudera.org:8080/#/c/24483/6/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
File fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java:

http://gerrit.cloudera.org:8080/#/c/24483/6/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@57
PS6, Line 57: import org.apache.hadoop.hive.metastore.api.RenamePartitionRequest;
> unused import: org.apache.hadoop.hive.metastore.api.PrincipalType
Done


http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java
File fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java:

http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java@41
PS5, Line 41: import org.apache.hadoop.hive.metastore.api.StorageDescriptor;
> unused import: org.apache.hadoop.hive.metastore.api.PrincipalType
Done


http://gerrit.cloudera.org:8080/#/c/24483/6/fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java
File fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java:

http://gerrit.cloudera.org:8080/#/c/24483/6/fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java@41
PS6, Line 41: import org.apache.hadoop.hive.metastore.api.StorageDescriptor;
> unused import: org.apache.hadoop.hive.metastore.api.PrincipalType
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 10
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Aug 2026 22:26:04 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24483

to look at the new patch set (#4).

Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................

IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

HIVE-26537 renamed some methods in AbstractThriftHiveMetastore that
were overridden in MetastoreServiceHandler and
CatalogMetastoreServiceHandler, which are instantiated in
CatalogHmsSyncToLatestEventIdTest. Due to this, requests from a
HiveMetaStoreClient were routed to the methods for which there was no
implementation in Impala, causing this Java test to fail. This patch
fixed the issue by renaming those overridden methods in Impala.

After renaming those overridden methods in Impala, we also had to fix
some end-to-end tests in test_metastore_service.py in which the
catalog server is started with "--start_hms_server=true" so that the
Hive MetaStore client will submit the requests to the renamed API's.

Testing:
 - Verified that CatalogHmsSyncToLatestEventIdTest is fixed with this
   patch.
 - Verified that the tests in test_metastore_service.py in which the
   catalog server is started with "--start_hms_server=true" are passed
   with this patch.

Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
---
M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M tests/custom_cluster/test_metastore_service.py
3 files changed, 90 insertions(+), 46 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/24483/4
-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 4
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24483 )

Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................


Patch Set 6:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/22966/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 6
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jun 2026 21:50:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24483

to look at the new patch set (#9).

Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................

IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

HIVE-26537 renamed some methods in AbstractThriftHiveMetastore that
were overridden in MetastoreServiceHandler and
CatalogMetastoreServiceHandler, which are instantiated in
CatalogHmsSyncToLatestEventIdTest. Due to this, requests from a
HiveMetaStoreClient were routed to the methods for which there was no
implementation in Impala, causing this Java test to fail. This patch
fixed the issue by renaming those overridden methods in Impala.

After renaming those overridden methods in Impala, we also had to fix
some end-to-end tests in test_metastore_service.py in which the
catalog server is started with "--start_hms_server=true" so that the
Hive MetaStore client will submit the requests to the renamed API's.

Testing:
 - Verified that CatalogHmsSyncToLatestEventIdTest is fixed with this
   patch.
 - Verified that the tests in test_metastore_service.py in which the
   catalog server is started with "--start_hms_server=true" are passed
   with this patch.

Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
---
M fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java
M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java
M fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java
M tests/custom_cluster/test_metastore_service.py
6 files changed, 98 insertions(+), 66 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/24483/9
-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 9
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24483 )

Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24483/8//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24483/8//COMMIT_MSG@9
PS8, Line 9: HIVE-26537 renamed some methods in AbstractThriftHiveMetastore that
> How are we going to handle this for Hive 2 and Hive 3 compatibility?

According to my observation, Apache Impala could be compiled even we have HIVE-26537 in CDP Hive. The difference is that with HIVE-26537 some of the tests in Impala will be broken. This patch only fixed the failed tests since compilation was not broken. There is no guarantee that those tests would be passed if we compile Apache Impala with Apache Hive 2 or Apache Hive 3.



-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 10
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Aug 2026 23:03:20 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24483

to look at the new patch set (#5).

Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................

IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

HIVE-26537 renamed some methods in AbstractThriftHiveMetastore that
were overridden in MetastoreServiceHandler and
CatalogMetastoreServiceHandler, which are instantiated in
CatalogHmsSyncToLatestEventIdTest. Due to this, requests from a
HiveMetaStoreClient were routed to the methods for which there was no
implementation in Impala, causing this Java test to fail. This patch
fixed the issue by renaming those overridden methods in Impala.

After renaming those overridden methods in Impala, we also had to fix
some end-to-end tests in test_metastore_service.py in which the
catalog server is started with "--start_hms_server=true" so that the
Hive MetaStore client will submit the requests to the renamed API's.

Testing:
 - Verified that CatalogHmsSyncToLatestEventIdTest is fixed with this
   patch.
 - Verified that the tests in test_metastore_service.py in which the
   catalog server is started with "--start_hms_server=true" are passed
   with this patch.

Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
---
M fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java
M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java
M fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java
M tests/custom_cluster/test_metastore_service.py
6 files changed, 100 insertions(+), 65 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/24483/5
-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 5
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24483 )

Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................


Patch Set 5:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/22965/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 5
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jun 2026 21:49:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24483 )

Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................


Patch Set 6:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24483/6/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
File fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java:

http://gerrit.cloudera.org:8080/#/c/24483/6/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@57
PS6, Line 57: import org.apache.hadoop.hive.metastore.api.PrincipalType;
unused import: org.apache.hadoop.hive.metastore.api.PrincipalType


http://gerrit.cloudera.org:8080/#/c/24483/6/fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java
File fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java:

http://gerrit.cloudera.org:8080/#/c/24483/6/fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java@41
PS6, Line 41: import org.apache.hadoop.hive.metastore.api.PrincipalType;
unused import: org.apache.hadoop.hive.metastore.api.PrincipalType



-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 6
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jun 2026 21:43:26 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24483

to look at the new patch set (#7).

Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................

IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

HIVE-26537 renamed some methods in AbstractThriftHiveMetastore that
were overridden in MetastoreServiceHandler and
CatalogMetastoreServiceHandler, which are instantiated in
CatalogHmsSyncToLatestEventIdTest. Due to this, requests from a
HiveMetaStoreClient were routed to the methods for which there was no
implementation in Impala, causing this Java test to fail. This patch
fixed the issue by renaming those overridden methods in Impala.

After renaming those overridden methods in Impala, we also had to fix
some end-to-end tests in test_metastore_service.py in which the
catalog server is started with "--start_hms_server=true" so that the
Hive MetaStore client will submit the requests to the renamed API's.

Testing:
 - Verified that CatalogHmsSyncToLatestEventIdTest is fixed with this
   patch.
 - Verified that the tests in test_metastore_service.py in which the
   catalog server is started with "--start_hms_server=true" are passed
   with this patch.

Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
---
M fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java
M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java
M fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java
M tests/custom_cluster/test_metastore_service.py
6 files changed, 98 insertions(+), 66 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/24483/7
-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 7
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24483 )

Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24483/8//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24483/8//COMMIT_MSG@9
PS8, Line 9: HIVE-26537 renamed some methods in AbstractThriftHiveMetastore that
> > How are we going to handle this for Hive 2 and Hive 3 compatibility?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 11
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Aug 2026 17:19:07 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24483 )

Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/22941/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jun 2026 00:31:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] CDPD-106263: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24483

to look at the new patch set (#8).

Change subject: CDPD-106263: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................

CDPD-106263: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

HIVE-26537 renamed some methods in AbstractThriftHiveMetastore that
were overridden in MetastoreServiceHandler and
CatalogMetastoreServiceHandler, which are instantiated in
CatalogHmsSyncToLatestEventIdTest. Due to this, requests from a
HiveMetaStoreClient were routed to the methods for which there was no
implementation in Impala, causing this Java test to fail. This patch
fixed the issue by renaming those overridden methods in Impala.

After renaming those overridden methods in Impala, we also had to fix
some end-to-end tests in test_metastore_service.py in which the
catalog server is started with "--start_hms_server=true" so that the
Hive MetaStore client will submit the requests to the renamed API's.

Testing:
 - Verified that CatalogHmsSyncToLatestEventIdTest is fixed with this
   patch.
 - Verified that the tests in test_metastore_service.py in which the
   catalog server is started with "--start_hms_server=true" are passed
   with this patch.

Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
---
M fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java
M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java
M fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java
M tests/custom_cluster/test_metastore_service.py
6 files changed, 98 insertions(+), 66 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/24483/8
-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 8
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24483

to look at the new patch set (#6).

Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................

IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

HIVE-26537 renamed some methods in AbstractThriftHiveMetastore that
were overridden in MetastoreServiceHandler and
CatalogMetastoreServiceHandler, which are instantiated in
CatalogHmsSyncToLatestEventIdTest. Due to this, requests from a
HiveMetaStoreClient were routed to the methods for which there was no
implementation in Impala, causing this Java test to fail. This patch
fixed the issue by renaming those overridden methods in Impala.

After renaming those overridden methods in Impala, we also had to fix
some end-to-end tests in test_metastore_service.py in which the
catalog server is started with "--start_hms_server=true" so that the
Hive MetaStore client will submit the requests to the renamed API's.

Testing:
 - Verified that CatalogHmsSyncToLatestEventIdTest is fixed with this
   patch.
 - Verified that the tests in test_metastore_service.py in which the
   catalog server is started with "--start_hms_server=true" are passed
   with this patch.

Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
---
M fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java
M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java
M fe/src/test/java/org/apache/impala/catalog/metastore/CatalogHmsSyncToLatestEventIdTest.java
M tests/custom_cluster/test_metastore_service.py
6 files changed, 99 insertions(+), 65 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/24483/6
-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 6
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24483 )

Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................


Patch Set 5:

(3 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java
File fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java:

http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/main/java/org/apache/impala/catalog/CatalogHmsAPIHelper.java@50
PS5, Line 50: import org.apache.hadoop.hive.metastore.api.FieldSchema;
unused import: org.apache.hadoop.hive.metastore.api.FieldSchema


http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
File fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java:

http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@57
PS5, Line 57: import org.apache.hadoop.hive.metastore.api.PrincipalType;
unused import: org.apache.hadoop.hive.metastore.api.PrincipalType


http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java
File fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java:

http://gerrit.cloudera.org:8080/#/c/24483/5/fe/src/test/java/org/apache/impala/catalog/MetastoreApiTestUtils.java@41
PS5, Line 41: import org.apache.hadoop.hive.metastore.api.PrincipalType;
unused import: org.apache.hadoop.hive.metastore.api.PrincipalType



-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 5
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jun 2026 21:41:04 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24483 )

Change subject: IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
......................................................................


Patch Set 11: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Gerrit-Change-Number: 24483
Gerrit-PatchSet: 11
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Aug 2026 17:22:08 +0000
Gerrit-HasComments: No