[GitHub] [fineract] ruchiD commented on a diff in pull request #2615: FINERACT-1694 JMS ActiveMQ downstream channel integration for events

[GitBox <gi...@apache.org>]

ruchiD commented on code in PR #2615:
URL: https://github.com/apache/fineract/pull/2615#discussion_r979806969


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/producer/ExternalEventProducerImpl.java:
##########
@@ -18,15 +18,16 @@
  */
 package org.apache.fineract.infrastructure.event.external.producer;
 
-import org.apache.fineract.avro.MessageV1;
 import org.apache.fineract.infrastructure.event.external.exception.AcknowledgementTimeoutException;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
 import org.springframework.stereotype.Service;
 
 @Service
+@ConditionalOnProperty(value = "fineract.events.external.producer.jms.enabled", havingValue = "false")
 public class ExternalEventProducerImpl implements ExternalEventProducer {

Review Comment:
   This class is required for cases when external event posting is disabled.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org