You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/06/13 20:01:54 UTC
[GitHub] [spark] icexelloss commented on issue #24643:
[SPARK-26412][PySpark][SQL] Allow Pandas UDF to take an iterator of
pd.Series or an iterator of tuple of pd.Series
icexelloss commented on issue #24643: [SPARK-26412][PySpark][SQL] Allow Pandas UDF to take an iterator of pd.Series or an iterator of tuple of pd.Series
URL: https://github.com/apache/spark/pull/24643#issuecomment-501857833
Pretty cool stuff! Just want to leave a few thoughts:
The proposed API doesn't seem to point out the notion of "partition", which I think it important here. In other words, just by looking at the API, it's not clear to me that the UDF is going to be invoked once per partition.
Another thought is that exposing the notion of partition isn't really something common in UDFs. I wonder why do we prefer this over sth like mapPartitions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org