You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2010/12/06 17:37:16 UTC
svn commit: r1042713 -
/tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java
Author: markt
Date: Mon Dec 6 16:37:16 2010
New Revision: 1042713
URL: http://svn.apache.org/viewvc?rev=1042713&view=rev
Log:
Fix another mix-up of connectionUploadTimeout and connectionTimeout
Modified:
tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java
Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java?rev=1042713&r1=1042712&r2=1042713&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java Mon Dec 6 16:37:16 2010
@@ -167,7 +167,6 @@ public abstract class AbstractHttp11Prot
public void setSoTimeout( int i ) {
endpoint.setSoTimeout(i);
setAttribute("soTimeout", "" + i);
- setAttribute("timeout", "" + i);
setAttribute("connectionTimeout", "" + i);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1042713 - /tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java
Posted by sebb <se...@gmail.com>.
On 6 December 2010 16:37, <ma...@apache.org> wrote:
> Author: markt
> Date: Mon Dec 6 16:37:16 2010
> New Revision: 1042713
>
> URL: http://svn.apache.org/viewvc?rev=1042713&view=rev
> Log:
> Fix another mix-up of connectionUploadTimeout and connectionTimeout
>
> Modified:
> tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java
>
> Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java?rev=1042713&r1=1042712&r2=1042713&view=diff
> ==============================================================================
> --- tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java (original)
> +++ tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java Mon Dec 6 16:37:16 2010
> @@ -167,7 +167,6 @@ public abstract class AbstractHttp11Prot
> public void setSoTimeout( int i ) {
> endpoint.setSoTimeout(i);
> setAttribute("soTimeout", "" + i);
> - setAttribute("timeout", "" + i);
> setAttribute("connectionTimeout", "" + i);
Just a thought - could perhaps use String constants for these attributes?
The constants could be given descriptive names and Javadoc.
Might make it easier to find all the usages of the attribute name.
Also, if all the constants were collected in one place, it would be
easier to ensure uniqueness of attribute names.
[Some code checkers can be configured to complain about 'magic
numbers' - I wonder if there is a way to find 'magic strings' such as
these?]
> }
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org