You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by bu...@apache.org on 2016/07/25 13:32:42 UTC
[Bug 59898] New: Wrapper script argument processing broken on
Solaris
https://bz.apache.org/bugzilla/show_bug.cgi?id=59898
Bug ID: 59898
Summary: Wrapper script argument processing broken on Solaris
Product: Ant
Version: 1.9.7
Hardware: PC
OS: Solaris
Status: NEW
Severity: normal
Priority: P2
Component: Core
Assignee: notifications@ant.apache.org
Reporter: rasher@gmail.com
The change from Bug 58898 breaks argument processing on Solaris, since Solaris
sed does not process lines that do not end in a newline. All arguments end up
empty. Seen on 11.3, x64.
Changing the printf pattern to '%s\n' does the trick with no ill effects that I
can see (also if using GNU sed).
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59898] Wrapper script argument processing broken on Solaris
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59898
Stefan Bodewig <bo...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |1.9.8
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #1 from Stefan Bodewig <bo...@apache.org> ---
Many thanks!
We've got a couple of bug reports about the change already and I was close to
just reverting the change as I haven't got access to any of the OSes that have
been reported as problematic.
applied your suggested change as git commit ad86305 to 1.9.x and master and
will ask the people who reported Bug 59695, Bug 59683 and Bug 59321 to check
whether it fixes the problem for them.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59898] Wrapper script argument processing broken on Solaris
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59898
Koen Wilde <kw...@bol.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kwilde@bol.com
--- Comment #4 from Koen Wilde <kw...@bol.com> ---
Created attachment 34416
--> https://bz.apache.org/bugzilla/attachment.cgi?id=34416&action=edit
[PATCH] Use poll(2) in posix nb_connect
This issue is caused by limitations of the select(2) system call. From the
(linux) manpage:
> POSIX allows an implementation to define an upper limit, advertised via the
> constant FD_SETSIZE, on the range of file descriptors that can be specified
> in a file descriptor set. The Linux kernel imposes no fixed limit, but the
> glibc implementation makes fd_set a fixed-size type, with FD_SETSIZE defined
> as 1024, and the FD_*() macros operating according to that limit. To
> monitor file descriptors greater than 1023, use poll(2) instead.
As Michiel already noted, poll(2) is already imported in jk_connect.c, so using
poll(2) doesn't add any new dependencies.
I've attached a patch that uses poll(2) if it is available at compile time;
otherwise it falls back to the current select(2) implementation.
On the long run, it would probably be preferable to use some kind of event
library like libuv or libevent that abstracts over the kernel interface, and
automatically uses the optimal one available (e.g. epoll on linux and kqueue on
FreeBSD). This would both improve portability and performance, and possibly
code simplicity.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59898] Wrapper script argument processing broken on Solaris
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59898
Stefan Bodewig <bo...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |michael.michaels@ericsson.c
| |om
--- Comment #9 from Stefan Bodewig <bo...@apache.org> ---
*** Bug 59683 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59898] Wrapper script argument processing broken on Solaris
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59898
--- Comment #5 from Koen Wilde <kw...@bol.com> ---
Ignore my previous comment and the patch, something went wrong and I commented
on the wrong issue!
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59898] Wrapper script argument processing broken on Solaris
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59898
Daniel Poggenpohl <da...@googlemail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|Core |Wrapper scripts
--- Comment #6 from Daniel Poggenpohl <da...@googlemail.com> ---
We're experiencing this bug right now. I nearly opened a new bug for this.
Bless the automatic search function indicating other similar bugs, I'd searched
for the wrong keywords.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59898] Wrapper script argument processing broken on Solaris
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59898
Stefan Bodewig <bo...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |reestman@stratcom.mil
--- Comment #10 from Stefan Bodewig <bo...@apache.org> ---
*** Bug 59695 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59898] Wrapper script argument processing broken on Solaris
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59898
--- Comment #2 from Maarten Coene <ma...@yahoo.com> ---
Stefan,
we had the same problem after upgrading to 1.9.7 and I can confirm this change
fixes the issue.
thanks,
Maarten
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59898] Wrapper script argument processing broken on Solaris
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59898
Stefan Bodewig <bo...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dir@obo.org
--- Comment #11 from Stefan Bodewig <bo...@apache.org> ---
*** Bug 59321 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59898] Wrapper script argument processing broken on Solaris
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59898
Stefan Bodewig <bo...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mk-linux@gmx.net
--- Comment #8 from Stefan Bodewig <bo...@apache.org> ---
*** Bug 60300 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59898] Wrapper script argument processing broken on Solaris
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59898
--- Comment #7 from Stefan Bodewig <bo...@apache.org> ---
Daniel, any chance you could try the wrapper script of the current master
branch -
https://git-wip-us.apache.org/repos/asf?p=ant.git;a=blob_plain;f=src/script/ant;h=5d1d15483c7bc71ecb03279432e7b074e1185662;hb=HEAD
- a try and confirm it fixes the problem for you?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 59898] Wrapper script argument processing broken on Solaris
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59898
--- Comment #3 from Stefan Bodewig <bo...@apache.org> ---
thanks, Maarten.
--
You are receiving this mail because:
You are the assignee for the bug.