You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "jiangML (via GitHub)" <gi...@apache.org> on 2023/04/25 09:18:52 UTC
[GitHub] [skywalking-java] jiangML opened a new pull request, #516: add sharding-sphere-5.3.2-plugin for shardingsphere
jiangML opened a new pull request, #516:
URL: https://github.com/apache/skywalking-java/pull/516
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service-agent/java-agent/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking-java/blob/main/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] jiangML commented on pull request #516: add sharding-sphere-5.3.2-plugin for shardingsphere
Posted by "jiangML (via GitHub)" <gi...@apache.org>.
jiangML commented on PR #516:
URL: https://github.com/apache/skywalking-java/pull/516#issuecomment-1523036663
> Hi, as this is a new plugin, you need to build a test scenario to verify the data.
>
> I can see the old release is tested in [5.0.0](https://github.com/apache/skywalking-java/blob/main/test/plugin/scenarios/shardingsphere-5.0.0-scenario/support-version.list) only, and you have chosen 5.3.2 as your plugin name. How about versions in between?
Ok, I will add relevant tests.
[5.0.0, 5.3.2) use version 5.0.0 of the plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #516: add sharding-sphere-5.3.2-plugin for shardingsphere
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #516:
URL: https://github.com/apache/skywalking-java/pull/516#discussion_r1177583742
##########
docs/en/setup/service-agent/java-agent/Supported-list.md:
##########
@@ -42,7 +42,7 @@ metrics based on the tracing data.
* Mysql Driver 5.x, 6.x, 8.x
* Oracle Driver (Optional¹)
* H2 Driver 1.3.x -> 1.4.x
- * [ShardingSphere](https://github.com/apache/shardingsphere) 3.0.0, 4.0.0, 4.0.1, 4.1.0, 4.1.1, 5.0.0
+ * [ShardingSphere](https://github.com/apache/shardingsphere) 3.0.0, 4.0.0, 4.0.1, 4.1.0, 4.1.1, 5.0.0, 5.1.0, 5.1.1, 5.1.2, 5.2.0, 5.2.1, 5.3.0, 5.3.1, 5.3.2
Review Comment:
We can't accept a lot of codes just for a single version. That is hard to maintain.
ShardingSphere keeps rapid changes and breaking everything.
It is very hard for us to follow. The codebases of ShardingSphere are much bigger than any other frameworks we met.
So, please try to provide a more adoptive version for plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng closed pull request #516: add sharding-sphere-5.3.2-plugin for shardingsphere
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed pull request #516: add sharding-sphere-5.3.2-plugin for shardingsphere
URL: https://github.com/apache/skywalking-java/pull/516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #516: add sharding-sphere-5.3.2-plugin for shardingsphere
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #516:
URL: https://github.com/apache/skywalking-java/pull/516#discussion_r1177639739
##########
test/plugin/scenarios/shardingsphere-5.3.2-scenario/src/main/resources/application.yaml:
##########
@@ -1,5 +1,20 @@
-
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+s
Review Comment:
I believe this s is unexpected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #516: add sharding-sphere-5.3.2-plugin for shardingsphere
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #516:
URL: https://github.com/apache/skywalking-java/pull/516#issuecomment-1521465592
Hi, as this is a new plugin, you need to build a test scenario to verify the data.
I can see the old release is tested in [5.0.0](https://github.com/apache/skywalking-java/blob/main/test/plugin/scenarios/shardingsphere-5.0.0-scenario/support-version.list) only, and you have chosen 5.3.2 as your plugin name. How about versions in between?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] jiangML commented on a diff in pull request #516: add sharding-sphere-5.3.2-plugin for shardingsphere
Posted by "jiangML (via GitHub)" <gi...@apache.org>.
jiangML commented on code in PR #516:
URL: https://github.com/apache/skywalking-java/pull/516#discussion_r1177612334
##########
test/plugin/scenarios/shardingsphere-5.3.2-scenario/support-version.list:
##########
@@ -0,0 +1,17 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+5.3.2
Review Comment:
At present, the old plug-in is really not enough, so a new plug-in is needed. Adaptation will be considered in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #516: add sharding-sphere-5.3.2-plugin for shardingsphere
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #516:
URL: https://github.com/apache/skywalking-java/pull/516#issuecomment-1521468436
And, supported-list.md and plugin-list.md should be updated according to your supported version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #516: add sharding-sphere-5.3.2-plugin for shardingsphere
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #516:
URL: https://github.com/apache/skywalking-java/pull/516#discussion_r1177569577
##########
docs/en/setup/service-agent/java-agent/Supported-list.md:
##########
@@ -42,7 +42,7 @@ metrics based on the tracing data.
* Mysql Driver 5.x, 6.x, 8.x
* Oracle Driver (Optional¹)
* H2 Driver 1.3.x -> 1.4.x
- * [ShardingSphere](https://github.com/apache/shardingsphere) 3.0.0, 4.0.0, 4.0.1, 4.1.0, 4.1.1, 5.0.0
+ * [ShardingSphere](https://github.com/apache/shardingsphere) 3.0.0, 4.0.0, 4.0.1, 4.1.0, 4.1.1, 5.0.0, 5.1.0, 5.1.1, 5.1.2, 5.2.0, 5.2.1, 5.3.0, 5.3.1, 5.3.2
Review Comment:
Are 5.0.x to 5.2.2 tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] jiangML commented on a diff in pull request #516: add sharding-sphere-5.3.2-plugin for shardingsphere
Posted by "jiangML (via GitHub)" <gi...@apache.org>.
jiangML commented on code in PR #516:
URL: https://github.com/apache/skywalking-java/pull/516#discussion_r1177582625
##########
test/plugin/scenarios/shardingsphere-5.3.2-scenario/support-version.list:
##########
@@ -0,0 +1,17 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+5.3.2
Review Comment:
ok, you're right, other versions are not tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #516: add sharding-sphere-5.3.2-plugin for shardingsphere
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #516:
URL: https://github.com/apache/skywalking-java/pull/516#discussion_r1177583742
##########
docs/en/setup/service-agent/java-agent/Supported-list.md:
##########
@@ -42,7 +42,7 @@ metrics based on the tracing data.
* Mysql Driver 5.x, 6.x, 8.x
* Oracle Driver (Optional¹)
* H2 Driver 1.3.x -> 1.4.x
- * [ShardingSphere](https://github.com/apache/shardingsphere) 3.0.0, 4.0.0, 4.0.1, 4.1.0, 4.1.1, 5.0.0
+ * [ShardingSphere](https://github.com/apache/shardingsphere) 3.0.0, 4.0.0, 4.0.1, 4.1.0, 4.1.1, 5.0.0, 5.1.0, 5.1.1, 5.1.2, 5.2.0, 5.2.1, 5.3.0, 5.3.1, 5.3.2
Review Comment:
We can't accept a lot of codes just for a single version. That is hard to maintain.
ShardingSphere keeps rapid changes and breaking everything.
It is very hard for us to follow. The codebases of ShardingSphere plugins are much bigger than any other frameworks we met.
So, please try to provide a more adoptive version for plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #516: add sharding-sphere-5.3.2-plugin for shardingsphere
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #516:
URL: https://github.com/apache/skywalking-java/pull/516#discussion_r1177576604
##########
test/plugin/scenarios/shardingsphere-5.3.2-scenario/support-version.list:
##########
@@ -0,0 +1,17 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+5.3.2
Review Comment:
You only have new added 5.3.2.
But we don't know whether other versions work or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] jiangML commented on pull request #516: add sharding-sphere-5.3.2-plugin for shardingsphere
Posted by "jiangML (via GitHub)" <gi...@apache.org>.
jiangML commented on PR #516:
URL: https://github.com/apache/skywalking-java/pull/516#issuecomment-1523168906
> Please make the test passed locally. Your test requires my manual approve to run every time. And we need your solution for various versions first.
Ok, let's think about it first, how to adapt multiple versions in the old plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #516: add sharding-sphere-5.3.2-plugin for shardingsphere
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #516:
URL: https://github.com/apache/skywalking-java/pull/516#discussion_r1177577356
##########
test/plugin/scenarios/shardingsphere-5.3.2-scenario/support-version.list:
##########
@@ -0,0 +1,17 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+5.3.2
Review Comment:
If old plugin works, please update this file in the old test scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] jiangML commented on a diff in pull request #516: add sharding-sphere-5.3.2-plugin for shardingsphere
Posted by "jiangML (via GitHub)" <gi...@apache.org>.
jiangML commented on code in PR #516:
URL: https://github.com/apache/skywalking-java/pull/516#discussion_r1177578547
##########
docs/en/setup/service-agent/java-agent/Supported-list.md:
##########
@@ -42,7 +42,7 @@ metrics based on the tracing data.
* Mysql Driver 5.x, 6.x, 8.x
* Oracle Driver (Optional¹)
* H2 Driver 1.3.x -> 1.4.x
- * [ShardingSphere](https://github.com/apache/shardingsphere) 3.0.0, 4.0.0, 4.0.1, 4.1.0, 4.1.1, 5.0.0
+ * [ShardingSphere](https://github.com/apache/shardingsphere) 3.0.0, 4.0.0, 4.0.1, 4.1.0, 4.1.1, 5.0.0, 5.1.0, 5.1.1, 5.1.2, 5.2.0, 5.2.1, 5.3.0, 5.3.1, 5.3.2
Review Comment:
Ok, the other version is indeed not tested, I will remove the other version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] jiangML commented on a diff in pull request #516: add sharding-sphere-5.3.2-plugin for shardingsphere
Posted by "jiangML (via GitHub)" <gi...@apache.org>.
jiangML commented on code in PR #516:
URL: https://github.com/apache/skywalking-java/pull/516#discussion_r1177610804
##########
docs/en/setup/service-agent/java-agent/Supported-list.md:
##########
@@ -42,7 +42,7 @@ metrics based on the tracing data.
* Mysql Driver 5.x, 6.x, 8.x
* Oracle Driver (Optional¹)
* H2 Driver 1.3.x -> 1.4.x
- * [ShardingSphere](https://github.com/apache/shardingsphere) 3.0.0, 4.0.0, 4.0.1, 4.1.0, 4.1.1, 5.0.0
+ * [ShardingSphere](https://github.com/apache/shardingsphere) 3.0.0, 4.0.0, 4.0.1, 4.1.0, 4.1.1, 5.0.0, 5.1.0, 5.1.1, 5.1.2, 5.2.0, 5.2.1, 5.3.0, 5.3.1, 5.3.2
Review Comment:
You are right that one plugin per version does make maintenance difficult. At present, the old plug-in cannot meet the new version, so a new plug-in needs to be added. In the future, multiple versions of a plugin will be considered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #516: add sharding-sphere-5.3.2-plugin for shardingsphere
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #516:
URL: https://github.com/apache/skywalking-java/pull/516#discussion_r1177616344
##########
docs/en/setup/service-agent/java-agent/Supported-list.md:
##########
@@ -42,7 +42,7 @@ metrics based on the tracing data.
* Mysql Driver 5.x, 6.x, 8.x
* Oracle Driver (Optional¹)
* H2 Driver 1.3.x -> 1.4.x
- * [ShardingSphere](https://github.com/apache/shardingsphere) 3.0.0, 4.0.0, 4.0.1, 4.1.0, 4.1.1, 5.0.0
+ * [ShardingSphere](https://github.com/apache/shardingsphere) 3.0.0, 4.0.0, 4.0.1, 4.1.0, 4.1.1, 5.0.0, 5.1.0, 5.1.1, 5.1.2, 5.2.0, 5.2.1, 5.3.0, 5.3.1, 5.3.2
Review Comment:
We don't want that 5.x has multiple plugins. Please try to merge them, and verify all released 5.x versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #516: add sharding-sphere-5.3.2-plugin for shardingsphere
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #516:
URL: https://github.com/apache/skywalking-java/pull/516#issuecomment-1523132846
Please make the test passed. Your test requires my manual approve to run every time.
And we need your solution for various versions first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] jiangML commented on pull request #516: add sharding-sphere-5.3.2-plugin for shardingsphere
Posted by "jiangML (via GitHub)" <gi...@apache.org>.
jiangML commented on PR #516:
URL: https://github.com/apache/skywalking-java/pull/516#issuecomment-1523034918
> And, supported-list.md and plugin-list.md should be updated according to your supported version.
ok let me update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #516: add sharding-sphere-5.3.2-plugin for shardingsphere
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #516:
URL: https://github.com/apache/skywalking-java/pull/516#issuecomment-1537848086
Is there any update here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org