[jira] [Updated] (YARN-4413) Nodes in the includes list should not be listed as decommissioned in the UI

["Daniel Templeton (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/YARN-4413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Templeton updated YARN-4413:
-----------------------------------
    Attachment: YARN-4413.001.patch

Here's the approach I propose.

I should note that I noticed that the graceful decommission code allows an illegal state transition:

{code}
        if (entry.getValue().getState() == NodeState.DECOMMISSIONING
            || entry.getValue().getState() == NodeState.DECOMMISSIONED) {
          this.rmContext.getDispatcher().getEventHandler()
              .handle(new RMNodeEvent(nodeId, RMNodeEventType.RECOMMISSION));
        }
{code}

DECOMMISSIONED -> RECOMMISSION is not allowed.  This issue is coincidentally fixed by this patch.

> Nodes in the includes list should not be listed as decommissioned in the UI
> ---------------------------------------------------------------------------
>
>                 Key: YARN-4413
>                 URL: https://issues.apache.org/jira/browse/YARN-4413
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>    Affects Versions: 2.7.1
>            Reporter: Daniel Templeton
>            Assignee: Daniel Templeton
>         Attachments: YARN-4413.001.patch
>
>
> If I decommission a node and then move it from the excludes list back to the includes list, but I don't restart the node, the node will still be listed by the web UI as decomissioned until either the NM or RM is restarted.  Ideally, removing the node from the excludes list and putting it back into the includes list should cause the node to be reported as shutdown instead.
> CC [~kshukla]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)