[jira] [Commented] (DRILL-5215) CTTAS: disallow temp tables in view expansion logic

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848763#comment-15848763 ] 

ASF GitHub Bot commented on DRILL-5215:
---------------------------------------

Github user jinfengni commented on the issue:

    https://github.com/apache/drill/pull/725
  
    +1
    
    LGTM


> CTTAS: disallow temp tables in view expansion logic
> ---------------------------------------------------
>
>                 Key: DRILL-5215
>                 URL: https://issues.apache.org/jira/browse/DRILL-5215
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.10.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>             Fix For: 1.10.0
>
>
> This Jira is addressing last two CR comments in PR for Jira DRILL-4956:
> 1. Disallow temp tables in view expansion logic.
> Steps to reproduce:
> a. use default temporary workspace.
> b. create persistent table with name t:
> c. create view over persistent table.
> d. drop persistent table.
> e. create temporary table with the same name as persistent table.
> f. select from view 
> Currently Drill returns result on step f but should return error message.
> {noformat}
> VALIDATION ERROR: Temporary tables usage is disallowed. Used temporary table name: t
> {noformat}
> {noformat}
> use dfs.tmp;
> create table t as select 'TABLE' from (values(1));
> create view v as select * from t;
> select * from v;
> +---------+
> | EXPR$0  |
> +---------+
> | TABLE   |
> +---------+
> drop table t;
> create temporary table t as select 'TEMP' from (values(1));
> select * from v;
> +---------+
> | EXPR$0  |
> +---------+
> | TEMP    |
> +---------+
> {noformat}
> 2. Replace link to gist with CTTAS design doc to Jira link.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)