You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by Piotr Nowojski <pi...@gmail.com> on 2023/11/07 13:08:57 UTC
[DISCUSS] FLIP-385: Add OpenTelemetryTraceReporter and OpenTelemetryMetricReporter
Hey, sorry for the misclick. Fixed.
wt., 7 lis 2023 o 14:00 Timo Walther <tw...@apache.org> napisał(a):
> Thanks for the FLIP, Piotr.
>
> In order to follow the FLIP process[1], please prefix the email subject
> with "[DISCUSS]".
>
> Also, some people might have added filters to their email clients to
> highlight those discussions.
>
> Thanks,
> Timo
>
> [1]
>
> https://cwiki.apache.org/confluence/display/Flink/Flink+Improvement+Proposals#FlinkImprovementProposals-Process
>
> On 07.11.23 09:35, Piotr Nowojski wrote:
> > Hi all!
> >
> > I would like to start a discussion on a follow up of FLIP-384: Introduce
> > TraceReporter and use it to create checkpointing and recovery traces [1]:
> >
> > *FLIP-385: Add OpenTelemetryTraceReporter and
> OpenTelemetryMetricReporter[
> > 2]*
> >
> > This FLIP proposes to add both MetricReporter and TraceReporter
> integrating
> > Flink with OpenTelemetry [4].
> >
> > There is also another follow up FLIP-386 [3], which improves recovery
> > traces.
> >
> > Please let me know what you think!
> >
> > Best,
> > Piotr Nowojski
> >
> > [1]
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-384%3A+Introduce+TraceReporter+and+use+it+to+create+checkpointing+and+recovery+traces
> > [2]
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-385%3A+Add+OpenTelemetryTraceReporter+and+OpenTelemetryMetricReporter
> > [3]
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-386%3A+Support+adding+custom+metrics+in+Recovery+Spans
> > [4] https://opentelemetry.io/
> >
>
>
Re: [DISCUSS] FLIP-385: Add OpenTelemetryTraceReporter and OpenTelemetryMetricReporter
Posted by Jing Ge <ji...@ververica.com.INVALID>.
Thanks Piotr for driving it! Really like the idea of
supporting OpenTelemetry.
Best regards,
Jing
On Tue, Nov 21, 2023 at 6:20 PM Piotr Nowojski <pn...@apache.org> wrote:
> Thanks Roman. It kind of does depend, as the API is defined in the
> FLIP-384. But the voting thread for that FLIP has started, so I think we
> can also start the voting process here.
>
> Best,
> Piotrek
>
> czw., 16 lis 2023 o 15:24 Roman Khachatryan <ro...@apache.org> napisał(a):
>
> > Thanks Piotr, the proposal totally makes sense to me.
> >
> > Does it depend on FLIP-384 for voting?
> > Otherwise, we could probably start the vote already as there're no
> counter
> > proposals or objections.
> >
> > Regards,
> > Roman
> >
> > On Tue, Nov 7, 2023, 1:19 PM Piotr Nowojski <pi...@gmail.com>
> > wrote:
> >
> > > Hey, sorry for the misclick. Fixed.
> > >
> > > wt., 7 lis 2023 o 14:00 Timo Walther <tw...@apache.org> napisał(a):
> > >
> > > > Thanks for the FLIP, Piotr.
> > > >
> > > > In order to follow the FLIP process[1], please prefix the email
> subject
> > > > with "[DISCUSS]".
> > > >
> > > > Also, some people might have added filters to their email clients to
> > > > highlight those discussions.
> > > >
> > > > Thanks,
> > > > Timo
> > > >
> > > > [1]
> > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/Flink/Flink+Improvement+Proposals#FlinkImprovementProposals-Process
> > > >
> > > > On 07.11.23 09:35, Piotr Nowojski wrote:
> > > > > Hi all!
> > > > >
> > > > > I would like to start a discussion on a follow up of FLIP-384:
> > > Introduce
> > > > > TraceReporter and use it to create checkpointing and recovery
> traces
> > > [1]:
> > > > >
> > > > > *FLIP-385: Add OpenTelemetryTraceReporter and
> > > > OpenTelemetryMetricReporter[
> > > > > 2]*
> > > > >
> > > > > This FLIP proposes to add both MetricReporter and TraceReporter
> > > > integrating
> > > > > Flink with OpenTelemetry [4].
> > > > >
> > > > > There is also another follow up FLIP-386 [3], which improves
> recovery
> > > > > traces.
> > > > >
> > > > > Please let me know what you think!
> > > > >
> > > > > Best,
> > > > > Piotr Nowojski
> > > > >
> > > > > [1]
> > > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-384%3A+Introduce+TraceReporter+and+use+it+to+create+checkpointing+and+recovery+traces
> > > > > [2]
> > > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-385%3A+Add+OpenTelemetryTraceReporter+and+OpenTelemetryMetricReporter
> > > > > [3]
> > > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-386%3A+Support+adding+custom+metrics+in+Recovery+Spans
> > > > > [4] https://opentelemetry.io/
> > > > >
> > > >
> > > >
> > >
> >
>
Re: [DISCUSS] FLIP-385: Add OpenTelemetryTraceReporter and OpenTelemetryMetricReporter
Posted by Piotr Nowojski <pn...@apache.org>.
Thanks Roman. It kind of does depend, as the API is defined in the
FLIP-384. But the voting thread for that FLIP has started, so I think we
can also start the voting process here.
Best,
Piotrek
czw., 16 lis 2023 o 15:24 Roman Khachatryan <ro...@apache.org> napisał(a):
> Thanks Piotr, the proposal totally makes sense to me.
>
> Does it depend on FLIP-384 for voting?
> Otherwise, we could probably start the vote already as there're no counter
> proposals or objections.
>
> Regards,
> Roman
>
> On Tue, Nov 7, 2023, 1:19 PM Piotr Nowojski <pi...@gmail.com>
> wrote:
>
> > Hey, sorry for the misclick. Fixed.
> >
> > wt., 7 lis 2023 o 14:00 Timo Walther <tw...@apache.org> napisał(a):
> >
> > > Thanks for the FLIP, Piotr.
> > >
> > > In order to follow the FLIP process[1], please prefix the email subject
> > > with "[DISCUSS]".
> > >
> > > Also, some people might have added filters to their email clients to
> > > highlight those discussions.
> > >
> > > Thanks,
> > > Timo
> > >
> > > [1]
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/Flink/Flink+Improvement+Proposals#FlinkImprovementProposals-Process
> > >
> > > On 07.11.23 09:35, Piotr Nowojski wrote:
> > > > Hi all!
> > > >
> > > > I would like to start a discussion on a follow up of FLIP-384:
> > Introduce
> > > > TraceReporter and use it to create checkpointing and recovery traces
> > [1]:
> > > >
> > > > *FLIP-385: Add OpenTelemetryTraceReporter and
> > > OpenTelemetryMetricReporter[
> > > > 2]*
> > > >
> > > > This FLIP proposes to add both MetricReporter and TraceReporter
> > > integrating
> > > > Flink with OpenTelemetry [4].
> > > >
> > > > There is also another follow up FLIP-386 [3], which improves recovery
> > > > traces.
> > > >
> > > > Please let me know what you think!
> > > >
> > > > Best,
> > > > Piotr Nowojski
> > > >
> > > > [1]
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-384%3A+Introduce+TraceReporter+and+use+it+to+create+checkpointing+and+recovery+traces
> > > > [2]
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-385%3A+Add+OpenTelemetryTraceReporter+and+OpenTelemetryMetricReporter
> > > > [3]
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-386%3A+Support+adding+custom+metrics+in+Recovery+Spans
> > > > [4] https://opentelemetry.io/
> > > >
> > >
> > >
> >
>
Re: [DISCUSS] FLIP-385: Add OpenTelemetryTraceReporter and OpenTelemetryMetricReporter
Posted by Roman Khachatryan <ro...@apache.org>.
Thanks Piotr, the proposal totally makes sense to me.
Does it depend on FLIP-384 for voting?
Otherwise, we could probably start the vote already as there're no counter
proposals or objections.
Regards,
Roman
On Tue, Nov 7, 2023, 1:19 PM Piotr Nowojski <pi...@gmail.com>
wrote:
> Hey, sorry for the misclick. Fixed.
>
> wt., 7 lis 2023 o 14:00 Timo Walther <tw...@apache.org> napisał(a):
>
> > Thanks for the FLIP, Piotr.
> >
> > In order to follow the FLIP process[1], please prefix the email subject
> > with "[DISCUSS]".
> >
> > Also, some people might have added filters to their email clients to
> > highlight those discussions.
> >
> > Thanks,
> > Timo
> >
> > [1]
> >
> >
> https://cwiki.apache.org/confluence/display/Flink/Flink+Improvement+Proposals#FlinkImprovementProposals-Process
> >
> > On 07.11.23 09:35, Piotr Nowojski wrote:
> > > Hi all!
> > >
> > > I would like to start a discussion on a follow up of FLIP-384:
> Introduce
> > > TraceReporter and use it to create checkpointing and recovery traces
> [1]:
> > >
> > > *FLIP-385: Add OpenTelemetryTraceReporter and
> > OpenTelemetryMetricReporter[
> > > 2]*
> > >
> > > This FLIP proposes to add both MetricReporter and TraceReporter
> > integrating
> > > Flink with OpenTelemetry [4].
> > >
> > > There is also another follow up FLIP-386 [3], which improves recovery
> > > traces.
> > >
> > > Please let me know what you think!
> > >
> > > Best,
> > > Piotr Nowojski
> > >
> > > [1]
> > >
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-384%3A+Introduce+TraceReporter+and+use+it+to+create+checkpointing+and+recovery+traces
> > > [2]
> > >
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-385%3A+Add+OpenTelemetryTraceReporter+and+OpenTelemetryMetricReporter
> > > [3]
> > >
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-386%3A+Support+adding+custom+metrics+in+Recovery+Spans
> > > [4] https://opentelemetry.io/
> > >
> >
> >
>