You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by seyfe <gi...@git.apache.org> on 2016/11/04 21:53:40 UTC
[GitHub] spark pull request #15774: [SPARK-18189] [SQL] [Followup] [Branch 2.0] Move ...
GitHub user seyfe opened a pull request:
https://github.com/apache/spark/pull/15774
[SPARK-18189] [SQL] [Followup] [Branch 2.0] Move test from ReplSuite to prevent java.lang.ClassCircularityError
## What changes were proposed in this pull request?
Move the test which is causing java.lang.ClassCircularityError from ReplSuite to DatasetSuite.
## How was this patch tested?
> build/mvn -DskipTests -Phadoop-2.3 -Pyarn -Phive -Phive-thriftserver -Pkinesis-asl -Pmesos clean package
> build/mvn -Dtest=none -DwildcardSuites=org.apache.spark.repl.ReplSuite test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/seyfe/spark fix_replsuite_test_error_branch2.0
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15774.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15774
----
commit bd513b1b25f6915b03e7c7c5cb536aecac7bfc15
Author: Ergin Seyfe <es...@fb.com>
Date: 2016-11-04T21:26:39Z
Move test from ReplSuite to prevent java.lang.ClassCircularityError
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15774: [SPARK-18189] [SQL] [Followup] Move test from ReplSuite ...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15774
+1 thanks @seyfe . That's a weird error and I think this is the right way to play it right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #15774: [SPARK-18189] [SQL] [Followup] Move test from Rep...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15774
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15774: [SPARK-18189] [SQL] [Followup] Move test from ReplSuite ...
Posted by seyfe <gi...@git.apache.org>.
Github user seyfe commented on the issue:
https://github.com/apache/spark/pull/15774
Yes @rxin, please merge into all 3 branches. master/branch-2.1/branch-2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15774: [SPARK-18189] [SQL] [Followup] [Branch 2.0] Move test fr...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15774
Is this not an issue with the master branch and branch-2.1?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15774: [SPARK-18189] [SQL] [Followup] Move test from ReplSuite ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15774
**[Test build #3415 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3415/consoleFull)** for PR 15774 at commit [`bd513b1`](https://github.com/apache/spark/commit/bd513b1b25f6915b03e7c7c5cb536aecac7bfc15).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15774: [SPARK-18189] [SQL] [Followup] [Branch 2.0] Move test fr...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15774
LGTM pending Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15774: [SPARK-18189] [SQL] [Followup] Move test from ReplSuite ...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15774
Thanks - merging in master/branch-2.1/branch-2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15774: [SPARK-18189] [SQL] [Followup] Move test from ReplSuite ...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/15774
So master/branch-2.1 is failing too right? I should merge this into master, branch-2.1, and branch-2.0?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15774: [SPARK-18189] [SQL] [Followup] [Branch 2.0] Move test fr...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15774
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15774: [SPARK-18189] [SQL] [Followup] [Branch 2.0] Move test fr...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15774
**[Test build #3415 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3415/consoleFull)** for PR 15774 at commit [`bd513b1`](https://github.com/apache/spark/commit/bd513b1b25f6915b03e7c7c5cb536aecac7bfc15).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15774: [SPARK-18189] [SQL] [Followup] [Branch 2.0] Move test fr...
Posted by seyfe <gi...@git.apache.org>.
Github user seyfe commented on the issue:
https://github.com/apache/spark/pull/15774
Hi @rxin ,
According to https://github.com/apache/spark/pull/15706 it was failing the maven tests for 2.0.2 RC2.
I checked and see that this is actually causing failures for master and branch-2.1 as well. sbt builds are good.
https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-maven-hadoop-2.4/2216/
https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-branch-2.1-test-maven-hadoop-2.7/15/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org