[GitHub] [incubator-pinot] siddharthteotia edited a comment on pull request #6067: Always quote literal when converting from PinotQuery to BrokerRequest

[GitBox <gi...@apache.org>]

siddharthteotia edited a comment on pull request #6067:
URL: https://github.com/apache/incubator-pinot/pull/6067#issuecomment-700365888


   So this has been a known issue with SQL where the SQL compiler expects the string literals to be single-quoted as opposed to double quoted since it treats the latter as identifiers. How was this working all this while if the PinotQuery to BrokerRequest conversion wasn't doing the right thing?
   
   Is it only happening for transform/agg functions which can take string literals as arguments? Few weeks ago, I ran the following query in SQL  and it was worked fine:
   
   `"select TIMECONVERT(\"timestamp\", 'MILLISECONDS', 'SECONDS'), count(*) from foo group by TIMECONVERT(\"timestamp\", 'MILLISECONDS', 'SECONDS')"`
   
   The function is taking string arguments in single quotes (as needed by SQL) and query runs fine. Changing 'MILLISECONDS' to "MILLISECONDS" will fail because it will become an identifier. So, how come it is working for other functions and not for `idset(A, 'fpp=0.05')`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org