[GitHub] [iceberg] stevenzwu commented on pull request #5967: Flink: Support read options in flink source

[GitBox <gi...@apache.org>]

stevenzwu commented on PR #5967:
URL: https://github.com/apache/iceberg/pull/5967#issuecomment-1332953683

   > The configurations `ScanContext` are table-level which means they only work when pass from SQL hint or from source builder while configurations in `FlinkConfigOptions` are job-level configs that are passed in as `readableConfig` already have prefix `table.exec.iceberg`.
   
   @chenjunjiedada `FlinkConfigOptions` have the prefix `table.exec.iceberg`.  We are talking about `FlinkWriteConf/FlinkWriteOptions` and the new `FlinkReadConf/FlinkReadOptions` (from this PR) that support hierarchical overrides (table property, Flink job config, SQL hint options). those configs don't have prefix. E.g. check out the unit test from this PR. `streaming` for table env config doesn't have . 
   
   ```
    getTableEnv().getConfig().set("streaming", "true");
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org