[GitHub] aaronmarkham commented on a change in pull request #8825: Update install-mxnet-osx-python.sh

[GitBox <gi...@apache.org>]

aaronmarkham commented on a change in pull request #8825: Update install-mxnet-osx-python.sh
URL: https://github.com/apache/incubator-mxnet/pull/8825#discussion_r153313437
 
 

 ##########
 File path: setup-utils/install-mxnet-osx-python.sh
 ##########
 @@ -362,19 +360,16 @@ download_mxnet() {
 
 	echo " "
 	echo "MXNET GIT Path = ${MXNET_GITPATH}"
-	#echo "MXNET Tag = ${MXNET_TAG}"
-	#echo "You can set \$MXNET_TAG to the appropriate github repo tag"
-	#echo "If not set, the default value used is the latest release"
-	echo " "
+	echo "MXNET Tag = ${MXNET_TAG}"
+    	echo "You can set \$MXNET_TAG to the appropriate github repo tag"
+    	echo "If not set, the default value used is the latest version on master"
+    	echo " "
 
 Review comment:
   It tells you what version it is about to install without a y/n prompt, and I think it would be good to include that, so users now seeing that they can use an env var to switch versions they won?t have to break out of the script manually to do so (and that?s if they even notice it). Here's an [example prompt](https://github.com/srochel/incubator-mxnet/blob/44813dd69fd6b3e7c9b98b56a55bced7f955fbdd/setup-utils/install-mxnet-osx-python.sh#L129-L135).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services