You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "George Harley (JIRA)" <ji...@apache.org> on 2006/06/29 15:02:30 UTC
[jira] Resolved: (HARMONY-703) [classlib][logging]
java.util.logging.Level constructors should throw NPE if name == null
[ http://issues.apache.org/jira/browse/HARMONY-703?page=all ]
George Harley resolved HARMONY-703:
-----------------------------------
Resolution: Fixed
Hi Vladimir,
Great catch ! Thank you very much for this fix which has been committed in revision 418031. I made one very minor change to your unit test patch which was to replace the use of a boolean variable to check whether the expected exception had been thrown with the more common JUnit idiom of calling the TestCase.fail() method if a line of code is reached that ought not to be. Please forgive me, I mean well :-)
Could you please verify if you are happy with the way things have been applied and we can move to close this issue.
Best regards,
George
> [classlib][logging] java.util.logging.Level constructors should throw NPE if name == null
> -----------------------------------------------------------------------------------------
>
> Key: HARMONY-703
> URL: http://issues.apache.org/jira/browse/HARMONY-703
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Vladimir Ivanov
> Assignee: George Harley
> Attachments: Level.patch, LevelTest.patch, LevelTest2.patch
>
> The j2se spec says for java.util.logging.Level constructors: "NPE- if the name is null" but harmony doesn't throw it.
> =============== test.java ============================
> import java.util.logging.*;
> import java.io.*;
> public class test {
> public static void main (String[] args) {
> try {
> System.out.println("Should be NPE: " + new test().new MockLevel(null, 4));
> } catch (NullPointerException e) {
> System.out.println("OK");
> }
> try {
> System.out.println("Should be NPE: " + new test().new MockLevel(null, 4, "str"));
> } catch (NullPointerException e) {
> System.out.println("OK");
> }
> }
> public class MockLevel extends Level implements Serializable {
> private static final long serialVersionUID = 1L;
> public MockLevel(String name, int value) {
> super(name, value);
> }
> public MockLevel(String name, int value, String resourceBundleName) {
> super(name, value, resourceBundleName);
> }
> }
> }
> ==================================================
>
> Output:
> C:\tmp\tmp17>C:\jrockit-jdk1.5.0-windows-ia32\bin\java.exe -showversion test
> java version "1.5.0"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0-b64)
> BEA WebLogic JRockit(R) (build dra-38972-20041208-2001-win-ia32, R25.0.0-75, GC: System optimized over throughput (initial strategy singleparpar))
> OK
> OK
> C:\tmp\tmp17>C:\harmony\trunk_0427\deploy\jdk\jre\bin\java.exe -showversion test
> java version 1.5 (subset)
> (c) Copyright 1991, 2006 The Apache Software Foundation or its licensors, as applicable.
> Should be NPE: null
> Should be NPE: null
> C:\tmp\tmp17>C:\harmony\drlvm\trunk\build\win_ia32_msvc_release\deploy\jre\bin\ij -showversion test
> Apache Harmony DRLVM HEAD-4807 (2006-05-02), Windows/ia32/msvc 1310, release
> Should be NPE: null
> Should be NPE: null
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira