[GitHub] [celix] PengZheng opened a new issue, #499: Use (argc, argv) instead of a single CommandLine in Shell command

["PengZheng (via GitHub)" <gi...@apache.org>]

PengZheng opened a new issue, #499:
URL: https://github.com/apache/celix/issues/499

   The main advantages of using `(argc, argv)` over a single string `CommandLine` are:
   
   * Avoid all the hassle of strdup/strtok. 
   * Deal with command line argument containing white spaces correctly.
   * Make integrating with 3rd party library wuch as https://github.com/argtable/argtable3 easier.
   
   _Originally posted by @PengZheng in https://github.com/apache/celix/pull/476#discussion_r1111655952_
               


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [celix] pnoltes commented on issue #499: Pass (argc, argv) in Shell interface

["pnoltes (via GitHub)" <gi...@apache.org>]

pnoltes commented on issue #499:
URL: https://github.com/apache/celix/issues/499#issuecomment-1494581122

   I think this can be done by introducing a new shell command interface (v2) based on the current one:
   https://github.com/apache/celix/blob/rel/celix-2.3.0/bundles/shell/shell/api/celix_shell_command.h
   
   We currently already support 2 shell commands version and if we remove the current deprecated version (
   https://github.com/apache/celix/blob/rel/celix-2.3.0/bundles/shell/shell/deprecated_api/command.h) when preparing for a Apache Celix 3.0.0 we could introduce a argc/argv variant and deprecated celix_shell_command.h.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org