You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/27 13:49:48 UTC

[GitHub] [arrow-datafusion] jackwener opened a new issue, #4392: Proposal: split the `planner`

jackwener opened a new issue, #4392:
URL: https://github.com/apache/arrow-datafusion/issues/4392

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   The current planner file is too large, we can split it.
   
   Like 
   - query.rs
   - select.rs
   - set_expr.rs
   - ....
   
   **Describe the solution you'd like**
   A clear and concise description of what you want to happen.
   
   **Describe alternatives you've considered**
   A clear and concise description of any alternative solutions or features you've considered.
   
   **Additional context**
   Add any other context or screenshots about the feature request here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on issue #4392: Enhancement: split the `planner`

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #4392:
URL: https://github.com/apache/arrow-datafusion/issues/4392#issuecomment-1329660788

   I agree this would be a good first issue as it will be mostly a software engineering exercise and doesn't require much datafusion internals knowledge. Thank you @jackwener 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] jackwener commented on issue #4392: Proposal: split the `planner`

Posted by GitBox <gi...@apache.org>.
jackwener commented on issue #4392:
URL: https://github.com/apache/arrow-datafusion/issues/4392#issuecomment-1328251334

   @mingmwang @andygrove @liukun4515 @alamb 
   How do you think about it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on issue #4392: Enhancement: split the `planner`

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #4392:
URL: https://github.com/apache/arrow-datafusion/issues/4392#issuecomment-1329659405

   
   I agree this would be an excellent idea
   
   The planner code I think is the code that translates from SQL statements to LogicalPlan: https://github.com/apache/arrow-datafusion/blob/a31b44eae236920d43ddd3ef7fadf8f9abf18976/datafusion/sql/src/planner.rs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] jackwener commented on issue #4392: Enhancement: split the `planner`

Posted by GitBox <gi...@apache.org>.
jackwener commented on issue #4392:
URL: https://github.com/apache/arrow-datafusion/issues/4392#issuecomment-1328255671

   Maybe we can add label `good-first-issue`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb closed issue #4392: Enhancement: split the SQL `planner` into smaller modules

Posted by GitBox <gi...@apache.org>.
alamb closed issue #4392: Enhancement: split the SQL `planner` into smaller modules
URL: https://github.com/apache/arrow-datafusion/issues/4392


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org