You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Oleg Kalnichevski (JIRA)" <ji...@apache.org> on 2013/10/03 09:41:44 UTC

[jira] [Commented] (HTTPCLIENT-1411) Http Client may throw an IllegalArgumentException with certain cookies

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13784896#comment-13784896 ] 

Oleg Kalnichevski commented on HTTPCLIENT-1411:
-----------------------------------------------

Hmm. This does not look like a problem with a cookie. In this case the offending hostname value is taken directly from the execution context. Quite frankly I am not sure I have any rational explanation how this could happen other than someone explicitly used a HttpHost value with a blank hostname as a parameter to HttpClient#execute. For the time being I am just going to re-assign this bug to HttpCore and add a check for hostname value being blank to HttpHost.

Oleg

> Http Client may throw an IllegalArgumentException with certain cookies
> ----------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1411
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1411
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.3 Final
>            Reporter: Sebastiano Vigna
>            Priority: Minor
>
> During a crawl of the EU web we got this exception:
> 2013-10-03 00:06:16,495 26567121 ERROR [FetchingThread-1927] i.u.d.l.b.f.FetchingThread - Unexpected exception
> java.lang.IllegalArgumentException: Host may not be blank
>         at org.apache.http.util.Args.notBlank(Args.java:68) ~[httpcore.jar:4.3]
>         at org.apache.http.cookie.CookieOrigin.<init>(CookieOrigin.java:50) ~[httpclient.jar:4.3]
>         at org.apache.http.client.protocol.RequestAddCookies.process(RequestAddCookies.java:141) ~[httpclient.jar:4.3]
>         at org.apache.http.protocol.ImmutableHttpProcessor.process(ImmutableHttpProcessor.java:131) ~[httpcore.jar:4.3]
>         at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:192) ~[httpclient.jar:4.3]
>         at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:85) ~[httpclient.jar:4.3]
>         at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:108) ~[httpclient.jar:4.3]
>         at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:186) ~[httpclient.jar:4.3]
>         at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:72) ~[httpclient.jar:4.3]
>         at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:214) ~[httpclient.jar:4.3]
>         at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:185) ~[httpclient.jar:4.3]
>         at it.unimi.di.law.bubing.util.FetchData.fetch(FetchData.java:308) ~[bubing-2.1.jar:na]
> Apparently some poisoned Cookie caused a mistake in the parsing process. Unfortunately due to the level of logging we are using we have no way to know which Cookie caused the problem, but maybe this rings a bell.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org