You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2016/11/24 10:41:28 UTC

Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/
-----------------------------------------------------------

Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.


Repository: atlas


Description
-------

ATLAS-1311: Integration tests for the V2 Entity APIs


Diffs
-----

  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 40866fe 
  client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
  client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
  client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c 
  client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
  intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9 
  typesystem/src/test/resources/atlas-application.properties 108630b 
  webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 8322bc6 
  webapp/src/main/java/org/apache/atlas/util/RestUtils.java bc937e4 
  webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb 
  webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java e746855 
  webapp/src/main/java/org/apache/atlas/web/errors/AllExceptionMapper.java 9042e88 
  webapp/src/main/java/org/apache/atlas/web/errors/AtlasBaseExceptionMapper.java 70b2482 
  webapp/src/main/java/org/apache/atlas/web/errors/ExceptionMapperUtil.java a14f939 
  webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 1ff8000 
  webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationEntryPoint.java 382b494 
  webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java 3307015 
  webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthorizationFilter.java 5bd2bd7 
  webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java 3cc83c5 
  webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java 75a884d 
  webapp/src/main/java/org/apache/atlas/web/filters/NullServletContext.java 25621c6 
  webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 3bab650 
  webapp/src/main/java/org/apache/atlas/web/model/User.java 54a19c5 
  webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b1 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c2 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1 
  webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207 
  webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c 
  webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f 
  webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e57 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java aea939a 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java b99a30a 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationProvider.java 953d737 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasFileAuthenticationProvider.java 3e1e2e6 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java 468daf6 
  webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java a6af5a2 
  webapp/src/main/java/org/apache/atlas/web/service/ServiceModule.java 2128b7c 
  webapp/src/main/java/org/apache/atlas/web/service/UserService.java 33101e2 
  webapp/src/main/resources/spring-security.xml 4ba3025 
  webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 
  webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd 
  webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
  webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459 
  webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java f06f791 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 265b650 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 2a75773 
  webapp/src/test/java/org/apache/atlas/web/filters/ActiveServerFilterTest.java b3ec8de 
  webapp/src/test/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilterTest.java a742dd5 
  webapp/src/test/java/org/apache/atlas/web/listeners/LoginProcessorIT.java 42692cd 
  webapp/src/test/java/org/apache/atlas/web/listeners/TestGuiceServletConfig.java 88cfc63 
  webapp/src/test/java/org/apache/atlas/web/listeners/TestModule.java b00080f 
  webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
  webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java f9e4c40 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityResourceTest.java 3fe8e11 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 9aff145 
  webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 3f20453 
  webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java ea55698 
  webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java b6dae4d 
  webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java ff2cfc3 
  webapp/src/test/java/org/apache/atlas/web/security/FileAuthenticationTest.java 44b7cac 
  webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java 6823c83 
  webapp/src/test/java/org/apache/atlas/web/security/UserDaoTest.java 2648ca7 
  webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceElectorServiceTest.java c0ffc6e 
  webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceStateTest.java 599e9cb 
  webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTestBase.java 455f121 
  webapp/src/test/java/org/apache/atlas/web/setup/SetupStepsTest.java 82abc1b 
  webapp/src/test/java/org/apache/atlas/web/util/ServletsTest.java e732dbf 

Diff: https://reviews.apache.org/r/54058/diff/


Testing
-------


Thanks,

Apoorv Naik

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Apoorv Naik <na...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/#review157336
-----------------------------------------------------------



Needs update after the FormatAdapter changes.

- Apoorv Naik


On Nov. 29, 2016, 7:49 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54058/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 7:49 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1311
>     https://issues.apache.org/jira/browse/ATLAS-1311
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1311: Integration tests for the V2 Entity APIs
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 40866fe 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
>   client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b1 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c2 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f 
>   webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e57 
>   webapp/src/main/resources/spring-security.xml 4ba3025 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java 2fa1602 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 
> 
> Diff: https://reviews.apache.org/r/54058/diff/
> 
> 
> Testing
> -------
> 
> UTs and ITs are running fine. mvn clean install -Pdist was successful
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Apoorv Naik <na...@gmail.com>.


> On Dec. 6, 2016, 2:45 a.m., Suma Shivaprasad wrote:
> > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java, line 123
> > <https://reviews.apache.org/r/54058/diff/4/?file=1573397#file1573397line123>
> >
> >     will cause timing issues if we dont wait and match the notification that we need here.

Was debugging hence commented it out.


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/#review158112
-----------------------------------------------------------


On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54058/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2016, 11:22 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1311
>     https://issues.apache.org/jira/browse/ATLAS-1311
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1311: Integration tests for the V2 Entity APIs
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
>   client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b1 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c2 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f 
>   webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e57 
>   webapp/src/main/resources/spring-security.xml 4ba3025 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java 2fa1602 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 
> 
> Diff: https://reviews.apache.org/r/54058/diff/
> 
> 
> Testing
> -------
> 
> UTs and ITs are running fine. mvn clean install -Pdist was successful
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Suma Shivaprasad <su...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/#review158112
-----------------------------------------------------------




webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java (line 123)
<https://reviews.apache.org/r/54058/#comment228820>

    will cause timing issues if we dont wait and match the notification that we need here.


- Suma Shivaprasad


On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54058/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2016, 11:22 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1311
>     https://issues.apache.org/jira/browse/ATLAS-1311
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1311: Integration tests for the V2 Entity APIs
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
>   client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b1 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c2 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f 
>   webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e57 
>   webapp/src/main/resources/spring-security.xml 4ba3025 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java 2fa1602 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 
> 
> Diff: https://reviews.apache.org/r/54058/diff/
> 
> 
> Testing
> -------
> 
> UTs and ITs are running fine. mvn clean install -Pdist was successful
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Suma Shivaprasad <su...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/#review158110
-----------------------------------------------------------




webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java (line 65)
<https://reviews.apache.org/r/54058/#comment228818>

    remove if not needed


- Suma Shivaprasad


On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54058/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2016, 11:22 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1311
>     https://issues.apache.org/jira/browse/ATLAS-1311
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1311: Integration tests for the V2 Entity APIs
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
>   client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b1 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c2 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f 
>   webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e57 
>   webapp/src/main/resources/spring-security.xml 4ba3025 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java 2fa1602 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 
> 
> Diff: https://reviews.apache.org/r/54058/diff/
> 
> 
> Testing
> -------
> 
> UTs and ITs are running fine. mvn clean install -Pdist was successful
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Apoorv Naik <na...@gmail.com>.


> On Dec. 6, 2016, 2:25 a.m., Suma Shivaprasad wrote:
> > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java, line 104
> > <https://reviews.apache.org/r/54058/diff/4/?file=1573392#file1573392line104>
> >
> >     Use constants for qualifiedName, clusterName in all the tests

will do.


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/#review158107
-----------------------------------------------------------


On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54058/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2016, 11:22 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1311
>     https://issues.apache.org/jira/browse/ATLAS-1311
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1311: Integration tests for the V2 Entity APIs
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
>   client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b1 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c2 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f 
>   webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e57 
>   webapp/src/main/resources/spring-security.xml 4ba3025 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java 2fa1602 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 
> 
> Diff: https://reviews.apache.org/r/54058/diff/
> 
> 
> Testing
> -------
> 
> UTs and ITs are running fine. mvn clean install -Pdist was successful
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Suma Shivaprasad <su...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/#review158107
-----------------------------------------------------------




webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java (line 104)
<https://reviews.apache.org/r/54058/#comment228812>

    Use constants for qualifiedName, clusterName in all the tests


- Suma Shivaprasad


On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54058/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2016, 11:22 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1311
>     https://issues.apache.org/jira/browse/ATLAS-1311
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1311: Integration tests for the V2 Entity APIs
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
>   client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b1 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c2 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f 
>   webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e57 
>   webapp/src/main/resources/spring-security.xml 4ba3025 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java 2fa1602 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 
> 
> Diff: https://reviews.apache.org/r/54058/diff/
> 
> 
> Testing
> -------
> 
> UTs and ITs are running fine. mvn clean install -Pdist was successful
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Suma Shivaprasad <su...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/#review158108
-----------------------------------------------------------




webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java (line 179)
<https://reviews.apache.org/r/54058/#comment228813>

    if we support search by typeName, can remove the TODO


- Suma Shivaprasad


On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54058/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2016, 11:22 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1311
>     https://issues.apache.org/jira/browse/ATLAS-1311
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1311: Integration tests for the V2 Entity APIs
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
>   client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b1 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c2 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f 
>   webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e57 
>   webapp/src/main/resources/spring-security.xml 4ba3025 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java 2fa1602 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 
> 
> Diff: https://reviews.apache.org/r/54058/diff/
> 
> 
> Testing
> -------
> 
> UTs and ITs are running fine. mvn clean install -Pdist was successful
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Apoorv Naik <na...@gmail.com>.


> On Dec. 6, 2016, 2:42 a.m., Suma Shivaprasad wrote:
> > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java, line 486
> > <https://reviews.apache.org/r/54058/diff/4/?file=1573393#file1573393line486>
> >
> >     would be good to add columns attribute since its a composite attribute

Column additions are present in the test code, so I think we can skip it here.


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/#review158111
-----------------------------------------------------------


On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54058/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2016, 11:22 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1311
>     https://issues.apache.org/jira/browse/ATLAS-1311
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1311: Integration tests for the V2 Entity APIs
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
>   client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b1 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c2 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f 
>   webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e57 
>   webapp/src/main/resources/spring-security.xml 4ba3025 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java 2fa1602 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 
> 
> Diff: https://reviews.apache.org/r/54058/diff/
> 
> 
> Testing
> -------
> 
> UTs and ITs are running fine. mvn clean install -Pdist was successful
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Suma Shivaprasad <su...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/#review158111
-----------------------------------------------------------




webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java (line 474)
<https://reviews.apache.org/r/54058/#comment228819>

    would be good to add columns attribute since its a composite attribute


- Suma Shivaprasad


On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54058/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2016, 11:22 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1311
>     https://issues.apache.org/jira/browse/ATLAS-1311
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1311: Integration tests for the V2 Entity APIs
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
>   client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b1 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c2 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f 
>   webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e57 
>   webapp/src/main/resources/spring-security.xml 4ba3025 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java 2fa1602 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 
> 
> Diff: https://reviews.apache.org/r/54058/diff/
> 
> 
> Testing
> -------
> 
> UTs and ITs are running fine. mvn clean install -Pdist was successful
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Apoorv Naik <na...@gmail.com>.


> On Dec. 22, 2016, 5:48 p.m., David Radley wrote:
> > I am looking for tests that drive the Entity V2 API with updates to LIST and SET attributes for foreign keys and map from refs. It would be good to show how to update a LIST - for eaxmple can you add a member into the middle of the list. Is this be in scope for this Jira?

No actually the goal was to port over the existing tests to work with V2 api. The LIST and SET attribute task can be taken up in a different JIRA.


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/#review159980
-----------------------------------------------------------


On Dec. 21, 2016, 2:25 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54058/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2016, 2:25 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1311
>     https://issues.apache.org/jira/browse/ATLAS-1311
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1311: Integration tests for the V2 Entity APIs
> 
> 
> Diffs
> -----
> 
>   .gitignore d2fbdc01 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java e5bd65a8 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java a95bf32d 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 47231a87 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 16556c8c 
>   client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7cf 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java a1935247 
>   intg/src/main/java/org/apache/atlas/model/SearchFilter.java 4d8b258e 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 35f2f144 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 1a3c31c9 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 6b2b2166 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcbe 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb5 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b14 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c28 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1a 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 2529f0dd 
>   webapp/src/main/resources/spring-security.xml 4ba30255 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605d 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java 01e4d483 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java ec62112f 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459b 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java e37839a2 
>   webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java 2a4babae 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 325c25b4 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java 7e4db13f 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 22bcc027 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java c681a0f9 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java ed37c3a1 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java 87bf9a89 
> 
> Diff: https://reviews.apache.org/r/54058/diff/
> 
> 
> Testing
> -------
> 
> UTs and ITs are running fine. mvn clean install -Pdist was successful
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by David Radley <da...@uk.ibm.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/#review159980
-----------------------------------------------------------



I am looking for tests that drive the Entity V2 API with updates to LIST and SET attributes for foreign keys and map from refs. It would be good to show how to update a LIST - for eaxmple can you add a member into the middle of the list. Is this be in scope for this Jira?

- David Radley


On Dec. 21, 2016, 2:25 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54058/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2016, 2:25 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1311
>     https://issues.apache.org/jira/browse/ATLAS-1311
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1311: Integration tests for the V2 Entity APIs
> 
> 
> Diffs
> -----
> 
>   .gitignore d2fbdc01 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java e5bd65a8 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java a95bf32d 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 47231a87 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 16556c8c 
>   client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7cf 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java a1935247 
>   intg/src/main/java/org/apache/atlas/model/SearchFilter.java 4d8b258e 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 35f2f144 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 1a3c31c9 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 6b2b2166 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcbe 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb5 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b14 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c28 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1a 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 2529f0dd 
>   webapp/src/main/resources/spring-security.xml 4ba30255 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605d 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java 01e4d483 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java ec62112f 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459b 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java e37839a2 
>   webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java 2a4babae 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 325c25b4 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java 7e4db13f 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 22bcc027 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java c681a0f9 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java ed37c3a1 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java 87bf9a89 
> 
> Diff: https://reviews.apache.org/r/54058/diff/
> 
> 
> Testing
> -------
> 
> UTs and ITs are running fine. mvn clean install -Pdist was successful
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Apoorv Naik <na...@gmail.com>.


> On Dec. 22, 2016, 2:47 p.m., David Radley wrote:
> > I run the testng tests for atlas-intg in Eclipse and get 6 failures with null pointer exceptions and 106 successful tests.

Hey David, the apache build is successful. Maybe some environment issue?  Can you post the logs on the related jira?


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/#review159959
-----------------------------------------------------------


On Dec. 21, 2016, 2:25 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54058/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2016, 2:25 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1311
>     https://issues.apache.org/jira/browse/ATLAS-1311
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1311: Integration tests for the V2 Entity APIs
> 
> 
> Diffs
> -----
> 
>   .gitignore d2fbdc01 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java e5bd65a8 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java a95bf32d 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 47231a87 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 16556c8c 
>   client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7cf 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java a1935247 
>   intg/src/main/java/org/apache/atlas/model/SearchFilter.java 4d8b258e 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 35f2f144 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 1a3c31c9 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 6b2b2166 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcbe 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb5 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b14 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c28 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1a 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 2529f0dd 
>   webapp/src/main/resources/spring-security.xml 4ba30255 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605d 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java 01e4d483 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java ec62112f 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459b 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java e37839a2 
>   webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java 2a4babae 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 325c25b4 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java 7e4db13f 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 22bcc027 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java c681a0f9 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java ed37c3a1 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java 87bf9a89 
> 
> Diff: https://reviews.apache.org/r/54058/diff/
> 
> 
> Testing
> -------
> 
> UTs and ITs are running fine. mvn clean install -Pdist was successful
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by David Radley <da...@uk.ibm.com>.


> On Dec. 22, 2016, 2:47 p.m., David Radley wrote:
> > I run the testng tests for atlas-intg in Eclipse and get 6 failures with null pointer exceptions and 106 successful tests.
> 
> Apoorv Naik wrote:
>     Hey David, the apache build is successful. Maybe some environment issue?  Can you post the logs on the related jira?

Hi Apoorv, I did a little digging and have updated the Jira with what I have found,   many thanks, David.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/#review159959
-----------------------------------------------------------


On Dec. 21, 2016, 2:25 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54058/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2016, 2:25 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1311
>     https://issues.apache.org/jira/browse/ATLAS-1311
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1311: Integration tests for the V2 Entity APIs
> 
> 
> Diffs
> -----
> 
>   .gitignore d2fbdc01 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java e5bd65a8 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java a95bf32d 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 47231a87 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 16556c8c 
>   client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7cf 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java a1935247 
>   intg/src/main/java/org/apache/atlas/model/SearchFilter.java 4d8b258e 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 35f2f144 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 1a3c31c9 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 6b2b2166 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcbe 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb5 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b14 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c28 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1a 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 2529f0dd 
>   webapp/src/main/resources/spring-security.xml 4ba30255 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605d 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java 01e4d483 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java ec62112f 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459b 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java e37839a2 
>   webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java 2a4babae 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 325c25b4 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java 7e4db13f 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 22bcc027 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java c681a0f9 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java ed37c3a1 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java 87bf9a89 
> 
> Diff: https://reviews.apache.org/r/54058/diff/
> 
> 
> Testing
> -------
> 
> UTs and ITs are running fine. mvn clean install -Pdist was successful
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by David Radley <da...@uk.ibm.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/#review159959
-----------------------------------------------------------



I run the testng tests for atlas-intg in Eclipse and get 6 failures with null pointer exceptions and 106 successful tests.

- David Radley


On Dec. 21, 2016, 2:25 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54058/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2016, 2:25 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1311
>     https://issues.apache.org/jira/browse/ATLAS-1311
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1311: Integration tests for the V2 Entity APIs
> 
> 
> Diffs
> -----
> 
>   .gitignore d2fbdc01 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java e5bd65a8 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java a95bf32d 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 47231a87 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 16556c8c 
>   client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7cf 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java a1935247 
>   intg/src/main/java/org/apache/atlas/model/SearchFilter.java 4d8b258e 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 35f2f144 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 1a3c31c9 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 6b2b2166 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcbe 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb5 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b14 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c28 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1a 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 2529f0dd 
>   webapp/src/main/resources/spring-security.xml 4ba30255 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605d 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java 01e4d483 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java ec62112f 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459b 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java e37839a2 
>   webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java 2a4babae 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 325c25b4 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java 7e4db13f 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 22bcc027 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java c681a0f9 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java ed37c3a1 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java 87bf9a89 
> 
> Diff: https://reviews.apache.org/r/54058/diff/
> 
> 
> Testing
> -------
> 
> UTs and ITs are running fine. mvn clean install -Pdist was successful
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Apoorv Naik <na...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/
-----------------------------------------------------------

(Updated Dec. 21, 2016, 2:25 a.m.)


Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.


Changes
-------

Addressed review comments.


Bugs: ATLAS-1311
    https://issues.apache.org/jira/browse/ATLAS-1311


Repository: atlas


Description
-------

ATLAS-1311: Integration tests for the V2 Entity APIs


Diffs (updated)
-----

  .gitignore d2fbdc01 
  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java e5bd65a8 
  client/src/main/java/org/apache/atlas/AtlasBaseClient.java a95bf32d 
  client/src/main/java/org/apache/atlas/AtlasClient.java 47231a87 
  client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 16556c8c 
  client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7cf 
  client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java a1935247 
  intg/src/main/java/org/apache/atlas/model/SearchFilter.java 4d8b258e 
  intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 35f2f144 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 1a3c31c9 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 6b2b2166 
  webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcbe 
  webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb5 
  webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b14 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c28 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1a 
  webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207c 
  webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12c 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 2529f0dd 
  webapp/src/main/resources/spring-security.xml 4ba30255 
  webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605d 
  webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java 01e4d483 
  webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java ec62112f 
  webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459b 
  webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java e37839a2 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java 2a4babae 
  webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 325c25b4 
  webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java 7e4db13f 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 22bcc027 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java c681a0f9 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java ed37c3a1 
  webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java 87bf9a89 

Diff: https://reviews.apache.org/r/54058/diff/


Testing
-------

UTs and ITs are running fine. mvn clean install -Pdist was successful


Thanks,

Apoorv Naik

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Madhan Neethiraj <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/#review159764
-----------------------------------------------------------


Fix it, then Ship it!





client/src/main/java/org/apache/atlas/AtlasBaseClient.java (line 280)
<https://reviews.apache.org/r/54058/#comment230814>

    Consider wrapping this inside: LOG.isDebugEnabled().



client/src/main/java/org/apache/atlas/AtlasBaseClient.java (line 299)
<https://reviews.apache.org/r/54058/#comment230815>

    is ".toString()" necessary here?



typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystemProvider.java (line 19)
<https://reviews.apache.org/r/54058/#comment230839>

    This file has white-space changes only. Please review and revert.


- Madhan Neethiraj


On Dec. 19, 2016, 8:21 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54058/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2016, 8:21 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1311
>     https://issues.apache.org/jira/browse/ATLAS-1311
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1311: Integration tests for the V2 Entity APIs
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java e5bd65a8 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java a95bf32d 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 47231a87 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 16556c8c 
>   client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7cf 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java a1935247 
>   intg/src/main/java/org/apache/atlas/model/SearchFilter.java 4d8b258e 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 35f2f144 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 1a3c31c9 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 6b2b2166 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystemProvider.java 4e1cd36b 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcbe 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb5 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b14 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c28 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1a 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 2529f0dd 
>   webapp/src/main/resources/spring-security.xml 4ba30255 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605d 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java 01e4d483 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java ec62112f 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459b 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java e37839a2 
>   webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java 2a4babae 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 325c25b4 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java 7e4db13f 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 22bcc027 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java c681a0f9 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java ed37c3a1 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java 87bf9a89 
> 
> Diff: https://reviews.apache.org/r/54058/diff/
> 
> 
> Testing
> -------
> 
> UTs and ITs are running fine. mvn clean install -Pdist was successful
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Apoorv Naik <na...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/
-----------------------------------------------------------

(Updated Dec. 19, 2016, 8:21 p.m.)


Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.


Changes
-------

Updated some comments and TODOs were removed.


Bugs: ATLAS-1311
    https://issues.apache.org/jira/browse/ATLAS-1311


Repository: atlas


Description
-------

ATLAS-1311: Integration tests for the V2 Entity APIs


Diffs (updated)
-----

  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java e5bd65a8 
  client/src/main/java/org/apache/atlas/AtlasBaseClient.java a95bf32d 
  client/src/main/java/org/apache/atlas/AtlasClient.java 47231a87 
  client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 16556c8c 
  client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7cf 
  client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java a1935247 
  intg/src/main/java/org/apache/atlas/model/SearchFilter.java 4d8b258e 
  intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 35f2f144 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 1a3c31c9 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 6b2b2166 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystemProvider.java 4e1cd36b 
  webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcbe 
  webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb5 
  webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b14 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c28 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1a 
  webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207c 
  webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12c 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 2529f0dd 
  webapp/src/main/resources/spring-security.xml 4ba30255 
  webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605d 
  webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java 01e4d483 
  webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java ec62112f 
  webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459b 
  webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java e37839a2 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java 2a4babae 
  webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 325c25b4 
  webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java 7e4db13f 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 22bcc027 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java c681a0f9 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java ed37c3a1 
  webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java 87bf9a89 

Diff: https://reviews.apache.org/r/54058/diff/


Testing
-------

UTs and ITs are running fine. mvn clean install -Pdist was successful


Thanks,

Apoorv Naik

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Apoorv Naik <na...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/
-----------------------------------------------------------

(Updated Dec. 13, 2016, 11:30 p.m.)


Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.


Changes
-------

Addressed review comments.


Bugs: ATLAS-1311
    https://issues.apache.org/jira/browse/ATLAS-1311


Repository: atlas


Description
-------

ATLAS-1311: Integration tests for the V2 Entity APIs


Diffs (updated)
-----

  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea3 
  client/src/main/java/org/apache/atlas/AtlasBaseClient.java a95bf32d 
  client/src/main/java/org/apache/atlas/AtlasClient.java 47231a87 
  client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 16556c8c 
  client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7cf 
  client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java a1935247 
  intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f41187 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9d 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 6b2b2166 
  webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcbe 
  webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb5 
  webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b14 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c28 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1a 
  webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207c 
  webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12c 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 2529f0dd 
  webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e578 
  webapp/src/main/resources/spring-security.xml 4ba30255 
  webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605d 
  webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd2 
  webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java ec62112f 
  webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459b 
  webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java 961154b8 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java 2a4babae 
  webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 325c25b4 
  webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java 7e4db13f 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java b5af111f 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java c681a0f9 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java ed37c3a1 
  webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java 87bf9a89 

Diff: https://reviews.apache.org/r/54058/diff/


Testing
-------

UTs and ITs are running fine. mvn clean install -Pdist was successful


Thanks,

Apoorv Naik

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Apoorv Naik <na...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/
-----------------------------------------------------------

(Updated Dec. 13, 2016, 6:47 a.m.)


Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.


Changes
-------

IT passing for webapp module.


Bugs: ATLAS-1311
    https://issues.apache.org/jira/browse/ATLAS-1311


Repository: atlas


Description
-------

ATLAS-1311: Integration tests for the V2 Entity APIs


Diffs (updated)
-----

  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea3 
  client/src/main/java/org/apache/atlas/AtlasBaseClient.java a95bf32d 
  client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 16556c8c 
  client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7cf 
  client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java a1935247 
  intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f41187 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9d 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 6b2b2166 
  webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcbe 
  webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb5 
  webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b14 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c28 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1a 
  webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207c 
  webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12c 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 2529f0dd 
  webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e578 
  webapp/src/main/resources/spring-security.xml 4ba30255 
  webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605d 
  webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd2 
  webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java ec62112f 
  webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459b 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java 2a4babae 
  webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 325c25b4 
  webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java 7e4db13f 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java b5af111f 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java c681a0f9 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java ed37c3a1 
  webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java 87bf9a89 

Diff: https://reviews.apache.org/r/54058/diff/


Testing
-------

UTs and ITs are running fine. mvn clean install -Pdist was successful


Thanks,

Apoorv Naik

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Apoorv Naik <na...@gmail.com>.


> On Dec. 6, 2016, 2:48 a.m., Suma Shivaprasad wrote:
> > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java, line 288
> > <https://reviews.apache.org/r/54058/diff/4/?file=1573397#file1573397line288>
> >
> >     is this not available for test already in the same patch through EntitiesREST.searchEntities?
> 
> Apoorv Naik wrote:
>     Search was marked as a todo feature, hence added a todo here as well.

The search functionality is being added to the store, right now the code doesn't utilize the store code. Once that's in place we can add corresponding tests.


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/#review158113
-----------------------------------------------------------


On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54058/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2016, 11:22 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1311
>     https://issues.apache.org/jira/browse/ATLAS-1311
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1311: Integration tests for the V2 Entity APIs
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
>   client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b1 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c2 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f 
>   webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e57 
>   webapp/src/main/resources/spring-security.xml 4ba3025 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java 2fa1602 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 
> 
> Diff: https://reviews.apache.org/r/54058/diff/
> 
> 
> Testing
> -------
> 
> UTs and ITs are running fine. mvn clean install -Pdist was successful
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Apoorv Naik <na...@gmail.com>.


> On Dec. 6, 2016, 2:48 a.m., Suma Shivaprasad wrote:
> > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java, line 288
> > <https://reviews.apache.org/r/54058/diff/4/?file=1573397#file1573397line288>
> >
> >     is this not available for test already in the same patch through EntitiesREST.searchEntities?

Search was marked as a todo feature, hence added a todo here as well.


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/#review158113
-----------------------------------------------------------


On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54058/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2016, 11:22 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1311
>     https://issues.apache.org/jira/browse/ATLAS-1311
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1311: Integration tests for the V2 Entity APIs
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
>   client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b1 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c2 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f 
>   webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e57 
>   webapp/src/main/resources/spring-security.xml 4ba3025 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java 2fa1602 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 
> 
> Diff: https://reviews.apache.org/r/54058/diff/
> 
> 
> Testing
> -------
> 
> UTs and ITs are running fine. mvn clean install -Pdist was successful
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Suma Shivaprasad <su...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/#review158113
-----------------------------------------------------------




webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java (line 288)
<https://reviews.apache.org/r/54058/#comment228821>

    is this not available for test already in the same patch through EntitiesREST.searchEntities?


- Suma Shivaprasad


On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54058/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2016, 11:22 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1311
>     https://issues.apache.org/jira/browse/ATLAS-1311
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1311: Integration tests for the V2 Entity APIs
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
>   client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b1 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c2 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f 
>   webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e57 
>   webapp/src/main/resources/spring-security.xml 4ba3025 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java 2fa1602 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 
> 
> Diff: https://reviews.apache.org/r/54058/diff/
> 
> 
> Testing
> -------
> 
> UTs and ITs are running fine. mvn clean install -Pdist was successful
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Apoorv Naik <na...@gmail.com>.


> On Dec. 6, 2016, 2:22 a.m., Suma Shivaprasad wrote:
> > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java, line 197
> > <https://reviews.apache.org/r/54058/diff/4/?file=1573384#file1573384line197>
> >
> >     add validations to have typename or supertype in the request to be provided mandatorily. Else it will end up running a query which may not be indexed.
> 
> Apoorv Naik wrote:
>     I've added a todo section for this in the store class.

Will be adding this as a part of the actual V2 implementation.


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/#review158102
-----------------------------------------------------------


On Dec. 13, 2016, 6:47 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54058/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2016, 6:47 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1311
>     https://issues.apache.org/jira/browse/ATLAS-1311
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1311: Integration tests for the V2 Entity APIs
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea3 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java a95bf32d 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 16556c8c 
>   client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7cf 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java a1935247 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f41187 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9d 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 6b2b2166 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcbe 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb5 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b14 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c28 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1a 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 2529f0dd 
>   webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e578 
>   webapp/src/main/resources/spring-security.xml 4ba30255 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605d 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd2 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java ec62112f 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459b 
>   webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java 2a4babae 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 325c25b4 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java 7e4db13f 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java b5af111f 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java c681a0f9 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java ed37c3a1 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java 87bf9a89 
> 
> Diff: https://reviews.apache.org/r/54058/diff/
> 
> 
> Testing
> -------
> 
> UTs and ITs are running fine. mvn clean install -Pdist was successful
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Apoorv Naik <na...@gmail.com>.


> On Dec. 6, 2016, 2:22 a.m., Suma Shivaprasad wrote:
> > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java, line 197
> > <https://reviews.apache.org/r/54058/diff/4/?file=1573384#file1573384line197>
> >
> >     add validations to have typename or supertype in the request to be provided mandatorily. Else it will end up running a query which may not be indexed.

I've added a todo section for this in the store class.


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/#review158102
-----------------------------------------------------------


On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54058/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2016, 11:22 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1311
>     https://issues.apache.org/jira/browse/ATLAS-1311
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1311: Integration tests for the V2 Entity APIs
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
>   client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b1 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c2 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f 
>   webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e57 
>   webapp/src/main/resources/spring-security.xml 4ba3025 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java 2fa1602 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 
> 
> Diff: https://reviews.apache.org/r/54058/diff/
> 
> 
> Testing
> -------
> 
> UTs and ITs are running fine. mvn clean install -Pdist was successful
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Suma Shivaprasad <su...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/#review158102
-----------------------------------------------------------




webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java (line 189)
<https://reviews.apache.org/r/54058/#comment228809>

    add validations to have typename or supertype in the request to be provided mandatorily. Else it will end up running a query which may not be indexed.


- Suma Shivaprasad


On Nov. 30, 2016, 11:22 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54058/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2016, 11:22 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1311
>     https://issues.apache.org/jira/browse/ATLAS-1311
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1311: Integration tests for the V2 Entity APIs
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
>   client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b1 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c2 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f 
>   webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e57 
>   webapp/src/main/resources/spring-security.xml 4ba3025 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java 2fa1602 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 
> 
> Diff: https://reviews.apache.org/r/54058/diff/
> 
> 
> Testing
> -------
> 
> UTs and ITs are running fine. mvn clean install -Pdist was successful
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Apoorv Naik <na...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/
-----------------------------------------------------------

(Updated Nov. 30, 2016, 11:22 p.m.)


Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.


Changes
-------

Updated the test and added a helper function.


Bugs: ATLAS-1311
    https://issues.apache.org/jira/browse/ATLAS-1311


Repository: atlas


Description
-------

ATLAS-1311: Integration tests for the V2 Entity APIs


Diffs (updated)
-----

  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea 
  client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
  client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
  client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c 
  client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
  intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9 
  webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb 
  webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb 
  webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b1 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c2 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1 
  webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207 
  webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c 
  webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f 
  webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e57 
  webapp/src/main/resources/spring-security.xml 4ba3025 
  webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 
  webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd 
  webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
  webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459 
  webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
  webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
  webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java 2fa1602 
  webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 

Diff: https://reviews.apache.org/r/54058/diff/


Testing
-------

UTs and ITs are running fine. mvn clean install -Pdist was successful


Thanks,

Apoorv Naik

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Apoorv Naik <na...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/
-----------------------------------------------------------

(Updated Nov. 29, 2016, 10:17 p.m.)


Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.


Changes
-------

Fix after rebase.


Bugs: ATLAS-1311
    https://issues.apache.org/jira/browse/ATLAS-1311


Repository: atlas


Description
-------

ATLAS-1311: Integration tests for the V2 Entity APIs


Diffs (updated)
-----

  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 40866fe 
  client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
  client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
  client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c 
  client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
  intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9 
  webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb 
  webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb 
  webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b1 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c2 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1 
  webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207 
  webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c 
  webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f 
  webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e57 
  webapp/src/main/resources/spring-security.xml 4ba3025 
  webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 
  webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd 
  webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
  webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459 
  webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
  webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
  webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java 2fa1602 
  webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 

Diff: https://reviews.apache.org/r/54058/diff/


Testing
-------

UTs and ITs are running fine. mvn clean install -Pdist was successful


Thanks,

Apoorv Naik

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Apoorv Naik <na...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/
-----------------------------------------------------------

(Updated Nov. 29, 2016, 7:49 p.m.)


Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.


Changes
-------

Reverting code rearrangment/ import-only changes.


Bugs: ATLAS-1311
    https://issues.apache.org/jira/browse/ATLAS-1311


Repository: atlas


Description
-------

ATLAS-1311: Integration tests for the V2 Entity APIs


Diffs (updated)
-----

  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 40866fe 
  client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
  client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
  client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c 
  client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
  intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9 
  webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcb 
  webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b1 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c2 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1 
  webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207 
  webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c 
  webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f 
  webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e57 
  webapp/src/main/resources/spring-security.xml 4ba3025 
  webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 
  webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd 
  webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
  webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459 
  webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
  webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java d9f14d0 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 13ef503 
  webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java 2fa1602 
  webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java fd15544 

Diff: https://reviews.apache.org/r/54058/diff/


Testing (updated)
-------

UTs and ITs are running fine. mvn clean install -Pdist was successful


Thanks,

Apoorv Naik

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Apoorv Naik <na...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/#review157292
-----------------------------------------------------------



Need to revert import only changes in several files.


typesystem/src/test/resources/atlas-application.properties (line 38)
<https://reviews.apache.org/r/54058/#comment227815>

    Need to revert this.



typesystem/src/test/resources/atlas-application.properties (line 84)
<https://reviews.apache.org/r/54058/#comment227816>

    Same here.


- Apoorv Naik


On Nov. 29, 2016, 6:20 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54058/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 6:20 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1311
>     https://issues.apache.org/jira/browse/ATLAS-1311
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1311: Integration tests for the V2 Entity APIs
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 40866fe 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
>   client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c 
>   client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9 
>   typesystem/src/test/resources/atlas-application.properties 108630b 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 8322bc6 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java bc937e4 
>   webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb 
>   webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java e746855 
>   webapp/src/main/java/org/apache/atlas/web/errors/AllExceptionMapper.java 9042e88 
>   webapp/src/main/java/org/apache/atlas/web/errors/AtlasBaseExceptionMapper.java 70b2482 
>   webapp/src/main/java/org/apache/atlas/web/errors/ExceptionMapperUtil.java a14f939 
>   webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 1ff8000 
>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationEntryPoint.java 382b494 
>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java 3307015 
>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthorizationFilter.java 5bd2bd7 
>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java 3cc83c5 
>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java 75a884d 
>   webapp/src/main/java/org/apache/atlas/web/filters/NullServletContext.java 25621c6 
>   webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 3bab650 
>   webapp/src/main/java/org/apache/atlas/web/model/User.java 54a19c5 
>   webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b1 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c2 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f 
>   webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e57 
>   webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java aea939a 
>   webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java b99a30a 
>   webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationProvider.java 953d737 
>   webapp/src/main/java/org/apache/atlas/web/security/AtlasFileAuthenticationProvider.java 3e1e2e6 
>   webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java 468daf6 
>   webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java a6af5a2 
>   webapp/src/main/java/org/apache/atlas/web/service/ServiceModule.java 2128b7c 
>   webapp/src/main/java/org/apache/atlas/web/service/UserService.java 33101e2 
>   webapp/src/main/resources/spring-security.xml 4ba3025 
>   webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd 
>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java f06f791 
>   webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 265b650 
>   webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 2a75773 
>   webapp/src/test/java/org/apache/atlas/web/filters/ActiveServerFilterTest.java b3ec8de 
>   webapp/src/test/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilterTest.java a742dd5 
>   webapp/src/test/java/org/apache/atlas/web/listeners/LoginProcessorIT.java 42692cd 
>   webapp/src/test/java/org/apache/atlas/web/listeners/TestGuiceServletConfig.java 88cfc63 
>   webapp/src/test/java/org/apache/atlas/web/listeners/TestModule.java b00080f 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
>   webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java f9e4c40 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityResourceTest.java 3fe8e11 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 9aff145 
>   webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 3f20453 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java ea55698 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java b6dae4d 
>   webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java ff2cfc3 
>   webapp/src/test/java/org/apache/atlas/web/security/FileAuthenticationTest.java 44b7cac 
>   webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java 6823c83 
>   webapp/src/test/java/org/apache/atlas/web/security/UserDaoTest.java 2648ca7 
>   webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceElectorServiceTest.java c0ffc6e 
>   webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceStateTest.java 599e9cb 
>   webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTestBase.java 455f121 
>   webapp/src/test/java/org/apache/atlas/web/setup/SetupStepsTest.java 82abc1b 
>   webapp/src/test/java/org/apache/atlas/web/util/ServletsTest.java e732dbf 
> 
> Diff: https://reviews.apache.org/r/54058/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

Posted by Apoorv Naik <na...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54058/
-----------------------------------------------------------

(Updated Nov. 29, 2016, 6:20 p.m.)


Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.


Bugs: ATLAS-1311
    https://issues.apache.org/jira/browse/ATLAS-1311


Repository: atlas


Description
-------

ATLAS-1311: Integration tests for the V2 Entity APIs


Diffs
-----

  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 40866fe 
  client/src/main/java/org/apache/atlas/AtlasBaseClient.java 04a418a 
  client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java fae4dd8 
  client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7c 
  client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java cf86e7a 
  intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 84608d9 
  typesystem/src/test/resources/atlas-application.properties 108630b 
  webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 8322bc6 
  webapp/src/main/java/org/apache/atlas/util/RestUtils.java bc937e4 
  webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb 
  webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java e746855 
  webapp/src/main/java/org/apache/atlas/web/errors/AllExceptionMapper.java 9042e88 
  webapp/src/main/java/org/apache/atlas/web/errors/AtlasBaseExceptionMapper.java 70b2482 
  webapp/src/main/java/org/apache/atlas/web/errors/ExceptionMapperUtil.java a14f939 
  webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 1ff8000 
  webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationEntryPoint.java 382b494 
  webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java 3307015 
  webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthorizationFilter.java 5bd2bd7 
  webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java 3cc83c5 
  webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java 75a884d 
  webapp/src/main/java/org/apache/atlas/web/filters/NullServletContext.java 25621c6 
  webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 3bab650 
  webapp/src/main/java/org/apache/atlas/web/model/User.java 54a19c5 
  webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b1 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c2 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1 
  webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207 
  webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 6bbc69c 
  webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f 
  webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e57 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java aea939a 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java b99a30a 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationProvider.java 953d737 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasFileAuthenticationProvider.java 3e1e2e6 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java 468daf6 
  webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java a6af5a2 
  webapp/src/main/java/org/apache/atlas/web/service/ServiceModule.java 2128b7c 
  webapp/src/main/java/org/apache/atlas/web/service/UserService.java 33101e2 
  webapp/src/main/resources/spring-security.xml 4ba3025 
  webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605 
  webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd 
  webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java 081d5ca 
  webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459 
  webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java f06f791 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 265b650 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 2a75773 
  webapp/src/test/java/org/apache/atlas/web/filters/ActiveServerFilterTest.java b3ec8de 
  webapp/src/test/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilterTest.java a742dd5 
  webapp/src/test/java/org/apache/atlas/web/listeners/LoginProcessorIT.java 42692cd 
  webapp/src/test/java/org/apache/atlas/web/listeners/TestGuiceServletConfig.java 88cfc63 
  webapp/src/test/java/org/apache/atlas/web/listeners/TestModule.java b00080f 
  webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 1777f75 
  webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java f9e4c40 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 38c823a 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java cf25814 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityResourceTest.java 3fe8e11 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION 
  webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 9aff145 
  webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 3f20453 
  webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java ea55698 
  webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java b6dae4d 
  webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java ff2cfc3 
  webapp/src/test/java/org/apache/atlas/web/security/FileAuthenticationTest.java 44b7cac 
  webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java 6823c83 
  webapp/src/test/java/org/apache/atlas/web/security/UserDaoTest.java 2648ca7 
  webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceElectorServiceTest.java c0ffc6e 
  webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceStateTest.java 599e9cb 
  webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTestBase.java 455f121 
  webapp/src/test/java/org/apache/atlas/web/setup/SetupStepsTest.java 82abc1b 
  webapp/src/test/java/org/apache/atlas/web/util/ServletsTest.java e732dbf 

Diff: https://reviews.apache.org/r/54058/diff/


Testing
-------


Thanks,

Apoorv Naik