You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "shunping (via GitHub)" <gi...@apache.org> on 2025/10/10 12:30:28 UTC
[PR] Enable real-time clock in prism by default. [beam]
shunping opened a new pull request, #36473:
URL: https://github.com/apache/beam/pull/36473
This may potentially affect processing timer/triggers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable real-time clock in prism by default. [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on PR #36473:
URL: https://github.com/apache/beam/pull/36473#issuecomment-3398990812
Thanks a lot for your time to review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Enable real-time clock in prism by default. [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36473:
URL: https://github.com/apache/beam/pull/36473#issuecomment-3392799754
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable real-time clock in prism by default. [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on PR #36473:
URL: https://github.com/apache/beam/pull/36473#issuecomment-3497660434
After this PR, real-time clock is enabled in prism by default. So I think we can close #32786.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Enable real-time clock in prism by default. [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on PR #36473:
URL: https://github.com/apache/beam/pull/36473#issuecomment-3392796975
CC: @lostluck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Enable real-time clock in prism by default. [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on PR #36473:
URL: https://github.com/apache/beam/pull/36473#issuecomment-3392796558
R: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable real-time clock in prism by default. [beam]
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on code in PR #36473:
URL: https://github.com/apache/beam/pull/36473#discussion_r2426983002
##########
sdks/go/test/integration/primitives/timers.go:
##########
@@ -298,6 +316,6 @@ func TimersProcessingTime_Bounded(s beam.Scope) {
func TimersProcessingTime_Unbounded(s beam.Scope) {
timersProcessingTimePipelineBuilder(func(s beam.Scope) beam.PCollection {
now := time.Now()
- return periodic.Impulse(s, now, now.Add(10*time.Second), 0, false)
+ return periodic.Impulse(s, now, now.Add(10*time.Second), 5*time.Second, false)
Review Comment:
Is the goal here is to have the transform fire twice, not once?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable real-time clock in prism by default. [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping merged PR #36473:
URL: https://github.com/apache/beam/pull/36473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable real-time clock in prism by default. [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on code in PR #36473:
URL: https://github.com/apache/beam/pull/36473#discussion_r2427002944
##########
sdks/go/test/integration/primitives/timers.go:
##########
@@ -298,6 +316,6 @@ func TimersProcessingTime_Bounded(s beam.Scope) {
func TimersProcessingTime_Unbounded(s beam.Scope) {
timersProcessingTimePipelineBuilder(func(s beam.Scope) beam.PCollection {
now := time.Now()
- return periodic.Impulse(s, now, now.Add(10*time.Second), 0, false)
+ return periodic.Impulse(s, now, now.Add(10*time.Second), 5*time.Second, false)
Review Comment:
Exactly!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable real-time clock in prism by default. [beam]
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #36473:
URL: https://github.com/apache/beam/pull/36473#issuecomment-3397927309
I am going to get to it today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org