You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Tao-Zhang9876 (via GitHub)" <gi...@apache.org> on 2023/11/11 07:00:34 UTC

[PR] [FLINK-33524][ API / DataStream] fix IntervalJoinOperator 's judgment on isLate function bug [flink]

Tao-Zhang9876 opened a new pull request, #23699:
URL: https://github.com/apache/flink/pull/23699

   Due to the Watermark calculation method :
   
   ```
   public void onPeriodicEmit(WatermarkOutput output) {
               output.emitWatermark(new Watermark(maxTs - delayTime - 1L));
           }
   
   ```
   
   When data with an event time of 1000ms enters, the Watermark will be pushed to 999.
   At this point, data with an event time of 999ms enters.Will be judged as non late data.
   
   ```
   private boolean isLate(long timestamp) {
       long currentWatermark = internalTimerService.currentWatermark();
       return timestamp < currentWatermark;
   } 
   ```
   
   It is necessary to modify the judgment criteria
   
   fix:
   ```
   private boolean isLate(long timestamp) {
       long currentWatermark = internalTimerService.currentWatermark();
       return timestamp < currentWatermark;
   } 
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33524][ API / DataStream] fix IntervalJoinOperator 's judgment on isLate function bug [flink]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] closed pull request #23699: [FLINK-33524][ API / DataStream] fix IntervalJoinOperator 's judgment on isLate function bug
URL: https://github.com/apache/flink/pull/23699


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33524][ API / DataStream] fix IntervalJoinOperator 's judgment on isLate function bug [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.

flinkbot commented on PR #23699:
URL: https://github.com/apache/flink/pull/23699#issuecomment-1806722894

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0bc5397f48610d1a26681974af917ac9230d17be",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0bc5397f48610d1a26681974af917ac9230d17be",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0bc5397f48610d1a26681974af917ac9230d17be UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33524][ API / DataStream] fix IntervalJoinOperator 's judgment on isLate function bug [flink]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #23699:
URL: https://github.com/apache/flink/pull/23699#issuecomment-2850023483

   This PR has been closed since it has not had any activity in 120 days. 
   If you feel like this was a mistake, or you would like to continue working on it, 
   please feel free to re-open the PR and ask for a review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33524][ API / DataStream] fix IntervalJoinOperator 's judgment on isLate function bug [flink]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #23699:
URL: https://github.com/apache/flink/pull/23699#issuecomment-2777667865

   This PR is being marked as stale since it has not had any activity in the last 90 days. 
   If you would like to keep this PR alive, please leave a comment asking for a review. 
   If the PR has merge conflicts, update it with the latest from the base branch.
   
   If you are having difficulty finding a reviewer, please reach out to the 
   community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
   
   If this PR is no longer valid or desired, please feel free to close it. 
   If no activity occurs in the next 30 days, it will be automatically closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org