You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/18 06:57:31 UTC

[GitHub] [flink] seunjjs opened a new pull request #13675: [FLINK-19655][flink-table-runtime-blink] add super.open() and write unit test for temporal process join

seunjjs opened a new pull request #13675:
URL: https://github.com/apache/flink/pull/13675


   
   
   <!--
   Fixes #
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   The ultimate goal of this PR is to fix a bug where NPE is thrown when using blink planner and TemporalTableFunction after setting IdleStateRetentionTime .TemporalProcessTimeJoinOperator should initialize timer service for processing time.
   See #FLINK-19655
   
   
   ## Brief change log
     - Add super.open() in LegacyTemporalProcessTimeJoinOperator#open() to solve NPE
     - Write two unit test for LegacyTemporalProcessTimeJoinOperator to verify the code worked fine
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
     - Added test that validates that:
       - 1.test proctime temporal join when non state clear. 
       - 2.test proctime temporal join when set state clear.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`:  no
     - The serializers:   no 
     - The runtime per-record code paths (performance sensitive):  no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper:  no 
     - The S3 file system connector: no 
   
   ## Documentation
   
     - Does this pull request introduce a new feature?  no
     - If yes, how is the feature documented?  not documented
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13675: [FLINK-19655][flink-table-runtime-blink] add super.open() and write unit test for temporal process join

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13675:
URL: https://github.com/apache/flink/pull/13675#issuecomment-711127350


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7800",
       "triggerID" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ecab94cd14e004566cd5b4f4a212123dd2ba7c78",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7872",
       "triggerID" : "ecab94cd14e004566cd5b4f4a212123dd2ba7c78",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ecab94cd14e004566cd5b4f4a212123dd2ba7c78 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7872) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13675: [FLINK-19655][flink-table-runtime-blink] add super.open() and write unit test for temporal process join

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13675:
URL: https://github.com/apache/flink/pull/13675#issuecomment-711127350


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7800",
       "triggerID" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ecab94cd14e004566cd5b4f4a212123dd2ba7c78",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7872",
       "triggerID" : "ecab94cd14e004566cd5b4f4a212123dd2ba7c78",
       "triggerType" : "PUSH"
     }, {
       "hash" : "73572634efa485ad88df75ba50d3b6ff0755ec8a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7954",
       "triggerID" : "73572634efa485ad88df75ba50d3b6ff0755ec8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a519bdb797522fb8fa35fa54ff6572a56ef5596f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8028",
       "triggerID" : "a519bdb797522fb8fa35fa54ff6572a56ef5596f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a519bdb797522fb8fa35fa54ff6572a56ef5596f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8028) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13675: [FLINK-19655][flink-table-runtime-blink] add super.open() and write unit test for temporal process join

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13675:
URL: https://github.com/apache/flink/pull/13675#issuecomment-711127350


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7800",
       "triggerID" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ecab94cd14e004566cd5b4f4a212123dd2ba7c78",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7872",
       "triggerID" : "ecab94cd14e004566cd5b4f4a212123dd2ba7c78",
       "triggerType" : "PUSH"
     }, {
       "hash" : "73572634efa485ad88df75ba50d3b6ff0755ec8a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "73572634efa485ad88df75ba50d3b6ff0755ec8a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ecab94cd14e004566cd5b4f4a212123dd2ba7c78 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7872) 
   * 73572634efa485ad88df75ba50d3b6ff0755ec8a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13675: [FLINK-19655][flink-table-runtime-blink] add super.open() and write unit test for temporal process join

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13675:
URL: https://github.com/apache/flink/pull/13675#issuecomment-711127350


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7800",
       "triggerID" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ecab94cd14e004566cd5b4f4a212123dd2ba7c78",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7872",
       "triggerID" : "ecab94cd14e004566cd5b4f4a212123dd2ba7c78",
       "triggerType" : "PUSH"
     }, {
       "hash" : "73572634efa485ad88df75ba50d3b6ff0755ec8a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7954",
       "triggerID" : "73572634efa485ad88df75ba50d3b6ff0755ec8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a519bdb797522fb8fa35fa54ff6572a56ef5596f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a519bdb797522fb8fa35fa54ff6572a56ef5596f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 73572634efa485ad88df75ba50d3b6ff0755ec8a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7954) 
   * a519bdb797522fb8fa35fa54ff6572a56ef5596f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13675: [FLINK-19655][flink-table-runtime-blink] add super.open() and write unit test for temporal process join

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13675:
URL: https://github.com/apache/flink/pull/13675#issuecomment-711127350


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7800",
       "triggerID" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ecab94cd14e004566cd5b4f4a212123dd2ba7c78",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7872",
       "triggerID" : "ecab94cd14e004566cd5b4f4a212123dd2ba7c78",
       "triggerType" : "PUSH"
     }, {
       "hash" : "73572634efa485ad88df75ba50d3b6ff0755ec8a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7954",
       "triggerID" : "73572634efa485ad88df75ba50d3b6ff0755ec8a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ecab94cd14e004566cd5b4f4a212123dd2ba7c78 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7872) 
   * 73572634efa485ad88df75ba50d3b6ff0755ec8a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7954) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13675: [FLINK-19655][flink-table-runtime-blink] add super.open() and write unit test for temporal process join

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13675:
URL: https://github.com/apache/flink/pull/13675#issuecomment-711127350


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7800",
       "triggerID" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ecab94cd14e004566cd5b4f4a212123dd2ba7c78",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7872",
       "triggerID" : "ecab94cd14e004566cd5b4f4a212123dd2ba7c78",
       "triggerType" : "PUSH"
     }, {
       "hash" : "73572634efa485ad88df75ba50d3b6ff0755ec8a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7954",
       "triggerID" : "73572634efa485ad88df75ba50d3b6ff0755ec8a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 73572634efa485ad88df75ba50d3b6ff0755ec8a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7954) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13675: [FLINK-19655][flink-table-runtime-blink] add super.open() and write unit test for temporal process join

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13675:
URL: https://github.com/apache/flink/pull/13675#issuecomment-711126413


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 448ec948b7aed52ae72d0229acfbc70f39eacd1a (Sun Oct 18 07:00:14 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] leonardBang commented on a change in pull request #13675: [FLINK-19655][flink-table-runtime-blink] add super.open() and write unit test for temporal process join

Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #13675:
URL: https://github.com/apache/flink/pull/13675#discussion_r507323519



##########
File path: flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/runtime/operators/join/temporal/LegacyTemporalProcessTimeJoinOperatorTest.java
##########
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.operators.join.temporal;
+
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.streaming.util.KeyedTwoInputStreamOperatorTestHarness;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.runtime.generated.GeneratedJoinCondition;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+import org.apache.flink.table.runtime.util.BinaryRowDataKeySelector;
+import org.apache.flink.table.runtime.util.RowDataHarnessAssertor;
+import org.apache.flink.table.types.logical.BigIntType;
+import org.apache.flink.table.types.logical.VarCharType;
+
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.apache.flink.table.runtime.util.StreamRecordUtils.insertRecord;
+
+

Review comment:
       single blank line

##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/join/temporal/LegacyTemporalProcessTimeJoinOperator.java
##########
@@ -73,6 +73,7 @@ public void open() throws Exception {
 		this.outRow = new JoinedRowData();
 		// consider watermark from left stream only.
 		super.processWatermark2(Watermark.MAX_WATERMARK);
+		super.open();

Review comment:
       move function call of super to the beginning

##########
File path: flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/runtime/operators/join/temporal/LegacyTemporalProcessTimeJoinOperatorTest.java
##########
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.operators.join.temporal;
+
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.streaming.util.KeyedTwoInputStreamOperatorTestHarness;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.runtime.generated.GeneratedJoinCondition;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+import org.apache.flink.table.runtime.util.BinaryRowDataKeySelector;
+import org.apache.flink.table.runtime.util.RowDataHarnessAssertor;
+import org.apache.flink.table.types.logical.BigIntType;
+import org.apache.flink.table.types.logical.VarCharType;
+
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.apache.flink.table.runtime.util.StreamRecordUtils.insertRecord;
+
+
+/**
+ * Test for {@link LegacyTemporalProcessTimeJoinOperator}.
+ */
+public class LegacyTemporalProcessTimeJoinOperatorTest {
+
+	private int keyIdx = 0;
+	private InternalTypeInfo<RowData> rowType = InternalTypeInfo.ofFields(
+			new BigIntType(),
+			new VarCharType(VarCharType.MAX_LENGTH));
+	private TypeInformation<RowData> keyType = InternalTypeInfo.ofFields();
+	private BinaryRowDataKeySelector keySelector = new BinaryRowDataKeySelector(
+			new int[]{keyIdx},
+			rowType.toRowFieldTypes());
+	private InternalTypeInfo<RowData> outputRowType = InternalTypeInfo.ofFields(
+			new BigIntType(),
+			new VarCharType(VarCharType.MAX_LENGTH),
+			new BigIntType(),
+			new VarCharType(VarCharType.MAX_LENGTH));
+	private RowDataHarnessAssertor assertor = new RowDataHarnessAssertor(outputRowType.toRowFieldTypes());
+	private String funcCode =
+			"public class ProcTimeTemporalJoinCondition extends org.apache.flink.api.common.functions.AbstractRichFunction implements org.apache.flink.table.runtime.generated.JoinCondition {\n"
+					+ "\n"
+					+ "    public ProcTimeTemporalJoinCondition(Object[] reference) {\n"
+					+ "    }\n"
+					+ "\n"
+					+ "    @Override\n"
+					+ "    public boolean apply(org.apache.flink.table.data.RowData in1, org.apache.flink.table.data.RowData in2) {\n"
+					+ "        return true;\n"
+					+ "    }\n"
+					+ "}\n";
+
+	private GeneratedJoinCondition joinCondition = new GeneratedJoinCondition(
+			"ProcTimeTemporalJoinCondition",
+			funcCode,
+			new Object[0]);
+
+	/** test proctime temporal join when non state clear. **/
+	@Test
+	public void testProcTimeTemporalJoin() throws Exception {
+		LegacyTemporalProcessTimeJoinOperator joinOperator = new LegacyTemporalProcessTimeJoinOperator(
+				rowType,
+				joinCondition,
+				0,
+				0);
+		KeyedTwoInputStreamOperatorTestHarness<RowData, RowData, RowData, RowData> testHarness = createTestHarness(
+				joinOperator);
+		testHarness.open();
+		testHarness.setProcessingTime(1);
+		testHarness.processElement1(insertRecord(1L, "1a1"));
+
+		testHarness.setProcessingTime(2);
+		testHarness.processElement2(insertRecord(2L, "2a2"));
+
+		testHarness.setProcessingTime(3);
+		testHarness.processElement1(insertRecord(2L, "2a3"));
+
+		testHarness.setProcessingTime(4);
+		testHarness.processElement2(insertRecord(1L, "1a4"));
+
+		testHarness.setProcessingTime(5);
+		testHarness.processElement1(insertRecord(1L, "1a5"));
+
+		List<Object> expectedOutput = new ArrayList<>();
+		expectedOutput.add(insertRecord(2L, "2a3", 2L, "2a2"));
+		expectedOutput.add(insertRecord(1L, "1a5", 1L, "1a4"));
+		assertor.assertOutputEquals("output wrong.", expectedOutput, testHarness.getOutput());
+		testHarness.close();
+	}
+
+	/** test proctime temporal join when set state clear. **/
+	@Test
+	public void testStateCleanUp() throws Exception {
+		final int minRetentionTime = 10;
+		LegacyTemporalProcessTimeJoinOperator joinOperator = new LegacyTemporalProcessTimeJoinOperator(
+				rowType,
+				joinCondition,
+				minRetentionTime,
+				minRetentionTime * 3 / 2);
+		KeyedTwoInputStreamOperatorTestHarness<RowData, RowData, RowData, RowData> testHarness = createTestHarness(
+				joinOperator);
+		testHarness.open();
+		testHarness.setProcessingTime(1);
+		testHarness.processElement1(insertRecord(1L, "1a1"));
+
+		testHarness.setProcessingTime(2);
+		testHarness.processElement2(insertRecord(2L, "2a2"));
+
+		testHarness.setProcessingTime(3);
+		testHarness.processElement1(insertRecord(2L, "2a3"));
+
+		testHarness.setProcessingTime(3 + minRetentionTime * 3 / 2);
+		testHarness.processElement1(insertRecord(2L, "1a5"));
+
+		List<Object> expectedOutput = new ArrayList<>();
+		expectedOutput.add(insertRecord(2L, "2a3", 2L, "2a2"));
+
+		assertor.assertOutputEquals("output wrong.", expectedOutput, testHarness.getOutput());
+		testHarness.close();
+	}
+
+	private KeyedTwoInputStreamOperatorTestHarness<RowData, RowData, RowData, RowData> createTestHarness(
+			LegacyTemporalProcessTimeJoinOperator temporalJoinOperator)
+			throws Exception {
+
+		return new KeyedTwoInputStreamOperatorTestHarness<>(
+				temporalJoinOperator,
+				keySelector,
+				keySelector,
+				keyType);
+	}
+
+}

Review comment:
       checkstyle: one blank line at the end of file

##########
File path: flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/runtime/operators/join/temporal/LegacyTemporalProcessTimeJoinOperatorTest.java
##########
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.operators.join.temporal;
+
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.streaming.util.KeyedTwoInputStreamOperatorTestHarness;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.runtime.generated.GeneratedJoinCondition;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+import org.apache.flink.table.runtime.util.BinaryRowDataKeySelector;
+import org.apache.flink.table.runtime.util.RowDataHarnessAssertor;
+import org.apache.flink.table.types.logical.BigIntType;
+import org.apache.flink.table.types.logical.VarCharType;
+
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.apache.flink.table.runtime.util.StreamRecordUtils.insertRecord;
+
+
+/**
+ * Test for {@link LegacyTemporalProcessTimeJoinOperator}.
+ */
+public class LegacyTemporalProcessTimeJoinOperatorTest {
+
+	private int keyIdx = 0;
+	private InternalTypeInfo<RowData> rowType = InternalTypeInfo.ofFields(
+			new BigIntType(),
+			new VarCharType(VarCharType.MAX_LENGTH));
+	private TypeInformation<RowData> keyType = InternalTypeInfo.ofFields();
+	private BinaryRowDataKeySelector keySelector = new BinaryRowDataKeySelector(
+			new int[]{keyIdx},
+			rowType.toRowFieldTypes());
+	private InternalTypeInfo<RowData> outputRowType = InternalTypeInfo.ofFields(
+			new BigIntType(),
+			new VarCharType(VarCharType.MAX_LENGTH),
+			new BigIntType(),
+			new VarCharType(VarCharType.MAX_LENGTH));
+	private RowDataHarnessAssertor assertor = new RowDataHarnessAssertor(outputRowType.toRowFieldTypes());
+	private String funcCode =
+			"public class ProcTimeTemporalJoinCondition extends org.apache.flink.api.common.functions.AbstractRichFunction implements org.apache.flink.table.runtime.generated.JoinCondition {\n"
+					+ "\n"
+					+ "    public ProcTimeTemporalJoinCondition(Object[] reference) {\n"
+					+ "    }\n"
+					+ "\n"
+					+ "    @Override\n"
+					+ "    public boolean apply(org.apache.flink.table.data.RowData in1, org.apache.flink.table.data.RowData in2) {\n"
+					+ "        return true;\n"
+					+ "    }\n"
+					+ "}\n";
+
+	private GeneratedJoinCondition joinCondition = new GeneratedJoinCondition(
+			"ProcTimeTemporalJoinCondition",
+			funcCode,
+			new Object[0]);
+
+	/** test proctime temporal join when non state clear. **/
+	@Test
+	public void testProcTimeTemporalJoin() throws Exception {
+		LegacyTemporalProcessTimeJoinOperator joinOperator = new LegacyTemporalProcessTimeJoinOperator(
+				rowType,
+				joinCondition,
+				0,
+				0);
+		KeyedTwoInputStreamOperatorTestHarness<RowData, RowData, RowData, RowData> testHarness = createTestHarness(
+				joinOperator);
+		testHarness.open();
+		testHarness.setProcessingTime(1);
+		testHarness.processElement1(insertRecord(1L, "1a1"));
+
+		testHarness.setProcessingTime(2);
+		testHarness.processElement2(insertRecord(2L, "2a2"));
+
+		testHarness.setProcessingTime(3);
+		testHarness.processElement1(insertRecord(2L, "2a3"));
+
+		testHarness.setProcessingTime(4);
+		testHarness.processElement2(insertRecord(1L, "1a4"));
+
+		testHarness.setProcessingTime(5);
+		testHarness.processElement1(insertRecord(1L, "1a5"));
+
+		List<Object> expectedOutput = new ArrayList<>();
+		expectedOutput.add(insertRecord(2L, "2a3", 2L, "2a2"));
+		expectedOutput.add(insertRecord(1L, "1a5", 1L, "1a4"));
+		assertor.assertOutputEquals("output wrong.", expectedOutput, testHarness.getOutput());
+		testHarness.close();
+	}
+
+	/** test proctime temporal join when set state clear. **/
+	@Test
+	public void testStateCleanUp() throws Exception {
+		final int minRetentionTime = 10;
+		LegacyTemporalProcessTimeJoinOperator joinOperator = new LegacyTemporalProcessTimeJoinOperator(
+				rowType,
+				joinCondition,
+				minRetentionTime,
+				minRetentionTime * 3 / 2);

Review comment:
       `final int maxRententionTime = minRetentionTime * 3 / 2`
   we can reuse  `maxRententionTime` in following code

##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/join/temporal/LegacyTemporalProcessTimeJoinOperator.java
##########
@@ -73,6 +73,7 @@ public void open() throws Exception {
 		this.outRow = new JoinedRowData();
 		// consider watermark from left stream only.
 		super.processWatermark2(Watermark.MAX_WATERMARK);
+		super.open();

Review comment:
       and I believe `TemporalRowTimeJoinOperator.java` exists same problem, could you help fix?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13675: [FLINK-19655][flink-table-runtime-blink] add super.open() and write unit test for temporal process join

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13675:
URL: https://github.com/apache/flink/pull/13675#issuecomment-711127350


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 448ec948b7aed52ae72d0229acfbc70f39eacd1a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] seunjjs commented on a change in pull request #13675: [FLINK-19655][flink-table-runtime-blink] add super.open() and write unit test for temporal process join

Posted by GitBox <gi...@apache.org>.
seunjjs commented on a change in pull request #13675:
URL: https://github.com/apache/flink/pull/13675#discussion_r508573357



##########
File path: flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/runtime/operators/join/temporal/LegacyTemporalProcessTimeJoinOperatorTest.java
##########
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.operators.join.temporal;
+
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.streaming.util.KeyedTwoInputStreamOperatorTestHarness;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.runtime.generated.GeneratedJoinCondition;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+import org.apache.flink.table.runtime.util.BinaryRowDataKeySelector;
+import org.apache.flink.table.runtime.util.RowDataHarnessAssertor;
+import org.apache.flink.table.types.logical.BigIntType;
+import org.apache.flink.table.types.logical.VarCharType;
+
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.apache.flink.table.runtime.util.StreamRecordUtils.insertRecord;
+
+
+/**
+ * Test for {@link LegacyTemporalProcessTimeJoinOperator}.
+ */
+public class LegacyTemporalProcessTimeJoinOperatorTest {
+
+	private int keyIdx = 0;
+	private InternalTypeInfo<RowData> rowType = InternalTypeInfo.ofFields(
+			new BigIntType(),
+			new VarCharType(VarCharType.MAX_LENGTH));
+	private TypeInformation<RowData> keyType = InternalTypeInfo.ofFields();
+	private BinaryRowDataKeySelector keySelector = new BinaryRowDataKeySelector(
+			new int[]{keyIdx},
+			rowType.toRowFieldTypes());
+	private InternalTypeInfo<RowData> outputRowType = InternalTypeInfo.ofFields(
+			new BigIntType(),
+			new VarCharType(VarCharType.MAX_LENGTH),
+			new BigIntType(),
+			new VarCharType(VarCharType.MAX_LENGTH));
+	private RowDataHarnessAssertor assertor = new RowDataHarnessAssertor(outputRowType.toRowFieldTypes());
+	private String funcCode =
+			"public class ProcTimeTemporalJoinCondition extends org.apache.flink.api.common.functions.AbstractRichFunction implements org.apache.flink.table.runtime.generated.JoinCondition {\n"
+					+ "\n"
+					+ "    public ProcTimeTemporalJoinCondition(Object[] reference) {\n"
+					+ "    }\n"
+					+ "\n"
+					+ "    @Override\n"
+					+ "    public boolean apply(org.apache.flink.table.data.RowData in1, org.apache.flink.table.data.RowData in2) {\n"
+					+ "        return true;\n"
+					+ "    }\n"
+					+ "}\n";
+
+	private GeneratedJoinCondition joinCondition = new GeneratedJoinCondition(
+			"ProcTimeTemporalJoinCondition",
+			funcCode,
+			new Object[0]);
+
+	/** test proctime temporal join when non state clear. **/
+	@Test
+	public void testProcTimeTemporalJoin() throws Exception {
+		LegacyTemporalProcessTimeJoinOperator joinOperator = new LegacyTemporalProcessTimeJoinOperator(
+				rowType,
+				joinCondition,
+				0,
+				0);
+		KeyedTwoInputStreamOperatorTestHarness<RowData, RowData, RowData, RowData> testHarness = createTestHarness(
+				joinOperator);
+		testHarness.open();
+		testHarness.setProcessingTime(1);
+		testHarness.processElement1(insertRecord(1L, "1a1"));
+
+		testHarness.setProcessingTime(2);
+		testHarness.processElement2(insertRecord(2L, "2a2"));
+
+		testHarness.setProcessingTime(3);
+		testHarness.processElement1(insertRecord(2L, "2a3"));
+
+		testHarness.setProcessingTime(4);
+		testHarness.processElement2(insertRecord(1L, "1a4"));
+
+		testHarness.setProcessingTime(5);
+		testHarness.processElement1(insertRecord(1L, "1a5"));
+
+		List<Object> expectedOutput = new ArrayList<>();
+		expectedOutput.add(insertRecord(2L, "2a3", 2L, "2a2"));
+		expectedOutput.add(insertRecord(1L, "1a5", 1L, "1a4"));
+		assertor.assertOutputEquals("output wrong.", expectedOutput, testHarness.getOutput());
+		testHarness.close();
+	}
+
+	/** test proctime temporal join when set state clear. **/
+	@Test
+	public void testStateCleanUp() throws Exception {
+		final int minRetentionTime = 10;
+		LegacyTemporalProcessTimeJoinOperator joinOperator = new LegacyTemporalProcessTimeJoinOperator(
+				rowType,
+				joinCondition,
+				minRetentionTime,
+				minRetentionTime * 3 / 2);

Review comment:
       fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] seunjjs commented on a change in pull request #13675: [FLINK-19655][flink-table-runtime-blink] add super.open() and write unit test for temporal process join

Posted by GitBox <gi...@apache.org>.
seunjjs commented on a change in pull request #13675:
URL: https://github.com/apache/flink/pull/13675#discussion_r508574982



##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/join/temporal/LegacyTemporalProcessTimeJoinOperator.java
##########
@@ -73,6 +73,7 @@ public void open() throws Exception {
 		this.outRow = new JoinedRowData();
 		// consider watermark from left stream only.
 		super.processWatermark2(Watermark.MAX_WATERMARK);
+		super.open();

Review comment:
       fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] seunjjs commented on a change in pull request #13675: [FLINK-19655][flink-table-runtime-blink] add super.open() and write unit test for temporal process join

Posted by GitBox <gi...@apache.org>.
seunjjs commented on a change in pull request #13675:
URL: https://github.com/apache/flink/pull/13675#discussion_r508571422



##########
File path: flink-table/flink-table-runtime-blink/src/test/java/org/apache/flink/table/runtime/operators/join/temporal/LegacyTemporalProcessTimeJoinOperatorTest.java
##########
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.operators.join.temporal;
+
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.streaming.util.KeyedTwoInputStreamOperatorTestHarness;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.runtime.generated.GeneratedJoinCondition;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+import org.apache.flink.table.runtime.util.BinaryRowDataKeySelector;
+import org.apache.flink.table.runtime.util.RowDataHarnessAssertor;
+import org.apache.flink.table.types.logical.BigIntType;
+import org.apache.flink.table.types.logical.VarCharType;
+
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.apache.flink.table.runtime.util.StreamRecordUtils.insertRecord;
+
+

Review comment:
       fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13675: [FLINK-19655][flink-table-runtime-blink] add super.open() and write unit test for temporal process join

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13675:
URL: https://github.com/apache/flink/pull/13675#issuecomment-711127350


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7800",
       "triggerID" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ecab94cd14e004566cd5b4f4a212123dd2ba7c78",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7872",
       "triggerID" : "ecab94cd14e004566cd5b4f4a212123dd2ba7c78",
       "triggerType" : "PUSH"
     }, {
       "hash" : "73572634efa485ad88df75ba50d3b6ff0755ec8a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7954",
       "triggerID" : "73572634efa485ad88df75ba50d3b6ff0755ec8a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a519bdb797522fb8fa35fa54ff6572a56ef5596f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8028",
       "triggerID" : "a519bdb797522fb8fa35fa54ff6572a56ef5596f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 73572634efa485ad88df75ba50d3b6ff0755ec8a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7954) 
   * a519bdb797522fb8fa35fa54ff6572a56ef5596f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8028) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] leonardBang commented on pull request #13675: [FLINK-19655][flink-table-runtime-blink] add super.open() and write unit test for temporal process join

Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #13675:
URL: https://github.com/apache/flink/pull/13675#issuecomment-714185454


   > Thank you. My system is win10, and I have followed this guide [https://ci.apache.org/projects/flink/flink-docs-release-1.11/flinkDev/ide_setup.html#checkstyle-for-java](url) to set Checkstyle-IDEA plugin. But if I run ctrl+alt+l, then the code style is different from yours. Do you know how can I get the right checkstyle plugin config on windows?😥
   
   I also followed this guide, I'm using mac, I think you've set right check style, the only difference between us is using single tab or double tabs before a new line, both the two formats exits in Flink codebase and can pass the code style check well. 
   I also improve a little about the note, parameter name and redundant blank lines, that's why I add the format commit.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13675: [FLINK-19655][flink-table-runtime-blink] add super.open() and write unit test for temporal process join

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13675:
URL: https://github.com/apache/flink/pull/13675#issuecomment-711127350


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7800",
       "triggerID" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ecab94cd14e004566cd5b4f4a212123dd2ba7c78",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7872",
       "triggerID" : "ecab94cd14e004566cd5b4f4a212123dd2ba7c78",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 448ec948b7aed52ae72d0229acfbc70f39eacd1a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7800) 
   * ecab94cd14e004566cd5b4f4a212123dd2ba7c78 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7872) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] leonardBang commented on pull request #13675: [FLINK-19655][flink-table-runtime-blink] add super.open() and write unit test for temporal process join

Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #13675:
URL: https://github.com/apache/flink/pull/13675#issuecomment-713367708


   @seunjjs Thanks for the update, the code looks fine, but the code check style is a little missy maybe you're using windows system.
   I add a commit to help format that, you can cherry-pick this https://github.com/leonardBang/flink/commit/cd333bf537031e7ff5049b3a59da38d7859f416b directly.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong merged pull request #13675: [FLINK-19655][flink-table-runtime-blink] add super.open() and write unit test for temporal process join

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #13675:
URL: https://github.com/apache/flink/pull/13675


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] seunjjs commented on pull request #13675: [FLINK-19655][flink-table-runtime-blink] add super.open() and write unit test for temporal process join

Posted by GitBox <gi...@apache.org>.
seunjjs commented on pull request #13675:
URL: https://github.com/apache/flink/pull/13675#issuecomment-713628331


   Thank you. My system is win10, and I have followed this guide [https://ci.apache.org/projects/flink/flink-docs-release-1.11/flinkDev/ide_setup.html#checkstyle-for-java](url) to set Checkstyle-IDEA plugin. But if I run ctrl+alt+l, then the code style is different from yours. Do you know how can I get the right checkstyle plugin config on windows?😥


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13675: [FLINK-19655][flink-table-runtime-blink] add super.open() and write unit test for temporal process join

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13675:
URL: https://github.com/apache/flink/pull/13675#issuecomment-711127350


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7800",
       "triggerID" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 448ec948b7aed52ae72d0229acfbc70f39eacd1a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7800) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13675: [FLINK-19655][flink-table-runtime-blink] add super.open() and write unit test for temporal process join

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13675:
URL: https://github.com/apache/flink/pull/13675#issuecomment-711127350


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7800",
       "triggerID" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ecab94cd14e004566cd5b4f4a212123dd2ba7c78",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ecab94cd14e004566cd5b4f4a212123dd2ba7c78",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 448ec948b7aed52ae72d0229acfbc70f39eacd1a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7800) 
   * ecab94cd14e004566cd5b4f4a212123dd2ba7c78 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13675: [FLINK-19655][flink-table-runtime-blink] add super.open() and write unit test for temporal process join

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13675:
URL: https://github.com/apache/flink/pull/13675#issuecomment-711127350


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7800",
       "triggerID" : "448ec948b7aed52ae72d0229acfbc70f39eacd1a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 448ec948b7aed52ae72d0229acfbc70f39eacd1a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7800) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org