You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/05 09:29:51 UTC
[GitHub] [flink] RocMarshal opened a new pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
RocMarshal opened a new pull request #17692:
URL: https://github.com/apache/flink/pull/17692
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748841
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d04e7822113ea65023d9311494cb67343d92fc34 (Fri Nov 05 09:34:26 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-24489).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
}, {
"hash" : "a392282483107bb6b985d9ff724d65d602a86a73",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337",
"triggerID" : "a392282483107bb6b985d9ff724d65d602a86a73",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a392282483107bb6b985d9ff724d65d602a86a73 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337)
* 22a0824281feec714d8182e287e1abe275b4c4ff Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-979931489
@AHeise Thank you very much for your help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
}, {
"hash" : "a392282483107bb6b985d9ff724d65d602a86a73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337",
"triggerID" : "a392282483107bb6b985d9ff724d65d602a86a73",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "970413494",
"triggerType" : "MANUAL"
}, {
"hash" : "5ee2449e410094eec0c7523a4dfee58091668398",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27678",
"triggerID" : "5ee2449e410094eec0c7523a4dfee58091668398",
"triggerType" : "PUSH"
}, {
"hash" : "5378879134e1c08ada5239c650d2ce77cff0f3e3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5378879134e1c08ada5239c650d2ce77cff0f3e3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5ee2449e410094eec0c7523a4dfee58091668398 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27678)
* 5378879134e1c08ada5239c650d2ce77cff0f3e3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal removed a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
RocMarshal removed a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-970413494
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d04e7822113ea65023d9311494cb67343d92fc34 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017)
* d1a9dd220650005d60138be5f69ed5df511c263d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
}, {
"hash" : "a392282483107bb6b985d9ff724d65d602a86a73",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a392282483107bb6b985d9ff724d65d602a86a73",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 59391b06ac7eb512b298dfcaa49847d20bb32c7e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254)
* a392282483107bb6b985d9ff724d65d602a86a73 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d1a9dd220650005d60138be5f69ed5df511c263d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074)
* 59391b06ac7eb512b298dfcaa49847d20bb32c7e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
AHeise edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-975326825
> In my limited read, if the positive significance of the pr is bigger than the side-effects of the pr, it would be worthy to do. And Please let me know what do you think of it.
~~Yes, I agree. So if you could address my initial comments (making the description more easy to understand for high-level CEP users), then I could merge it.~~ So that it's in the test case, so I will review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
RocMarshal edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-969035044
> The situation is a bit odd. I think we shouldn't have a cache on top of rocks DB at all. We could think about having a cache in rocks DB itself.
>
> Nevertheless, the cache is there and causes trouble for you. I understood now that your changes are not impacting correctness but only performance, so I think your contribution certainly is welcome.
>
> To reiterate from my first rough review: Could you please add a (unit) test and make the configuration descriptions easier to understand for folks that have not read the CEP code?
Thanks so much for your @AHeise reply and explanation, which makes me suddenly see the light.
As updated in the `CEPCacheOptions`:
`
And it could accelerate the CEP operate process speed and limit the capacity of cache in pure memory. Note: It's only effective to limit usage of memory when 'state.backend' was set as 'rocksdb', which would transport the elements exceeded the number of the cache into the rocksdb state storage instead of memory state storage.
`
The minor pr is really helpful for memory limitation when the `state.backend` is set as `rocksdb`.
By contrast，when the `state.backend` is set as not `rocksdb`, the current cache in the pr would cause performance decreased. Compared with old cache , the state part will contain more elements swapped out from new guava-cache ,which would make it heavier to `copy on write` for state .
In my limited read, if the positive significance of the pr is bigger than the side-effects of the pr, it would be worthy to do.
And Please let me know what do you think of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
RocMarshal edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-963105801
@Airblader @twalthr Could you help me to review this pr ? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
RocMarshal edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-963105801
@Airblader @twalthr @klion26 Could you help me to review this pr ? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
RocMarshal edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-979931489
@AHeise
Thank you very much for your help. Happy Thanksgiving Day!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17692:
URL: https://github.com/apache/flink/pull/17692#discussion_r754103757
##########
File path: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/SharedBuffer.java
##########
@@ -73,33 +88,105 @@
private final MapState<NodeId, Lockable<SharedBufferNode>> entries;
/** The cache of eventsBuffer State. */
- private final Map<EventId, Lockable<V>> eventsBufferCache = new HashMap<>();
+ private final Cache<EventId, Lockable<V>> eventsBufferCache;
/** The cache of sharedBufferNode. */
- private final Map<NodeId, Lockable<SharedBufferNode>> entryCache = new HashMap<>();
+ private final Cache<NodeId, Lockable<SharedBufferNode>> entryCache;
+
+ private final Timer cacheStatisticsTimer;
+ @VisibleForTesting
public SharedBuffer(KeyedStateStore stateStore, TypeSerializer<V> valueSerializer) {
+ this(stateStore, valueSerializer, new Configuration());
+ }
+
+ public SharedBuffer(
+ KeyedStateStore stateStore,
+ TypeSerializer<V> valueSerializer,
+ ExecutionConfig.GlobalJobParameters globalJobParameters) {
Review comment:
Instead of passing `GlobalJobParameters`, you should pass only the setting values directly.
Alternatively, you can extract a small immutable class that captures only these values. Using `GlobalJobParameters` makes testing harder and couples the classes closer than they need to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
AHeise edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-975326825
> In my limited read, if the positive significance of the pr is bigger than the side-effects of the pr, it would be worthy to do. And Please let me know what do you think of it.
~~Yes, I agree. So if you could address my initial comments (making the description more easy to understand for high-level CEP users), then I could merge it.~~ I saw that it's in the test case commit, so I will review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
}, {
"hash" : "a392282483107bb6b985d9ff724d65d602a86a73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337",
"triggerID" : "a392282483107bb6b985d9ff724d65d602a86a73",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "970413494",
"triggerType" : "MANUAL"
}, {
"hash" : "5ee2449e410094eec0c7523a4dfee58091668398",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27678",
"triggerID" : "5ee2449e410094eec0c7523a4dfee58091668398",
"triggerType" : "PUSH"
}, {
"hash" : "5378879134e1c08ada5239c650d2ce77cff0f3e3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27776",
"triggerID" : "5378879134e1c08ada5239c650d2ce77cff0f3e3",
"triggerType" : "PUSH"
}, {
"hash" : "f618e423b7998cbde46da324ac80e78d24e9f1c1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27810",
"triggerID" : "f618e423b7998cbde46da324ac80e78d24e9f1c1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5378879134e1c08ada5239c650d2ce77cff0f3e3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27776)
* f618e423b7998cbde46da324ac80e78d24e9f1c1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27810)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-988924984
Please rebase and squash, so that I can merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d04e7822113ea65023d9311494cb67343d92fc34 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
}, {
"hash" : "a392282483107bb6b985d9ff724d65d602a86a73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337",
"triggerID" : "a392282483107bb6b985d9ff724d65d602a86a73",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "970413494",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 22a0824281feec714d8182e287e1abe275b4c4ff Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
}, {
"hash" : "a392282483107bb6b985d9ff724d65d602a86a73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337",
"triggerID" : "a392282483107bb6b985d9ff724d65d602a86a73",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "970413494",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 22a0824281feec714d8182e287e1abe275b4c4ff Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d04e7822113ea65023d9311494cb67343d92fc34 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-963105801
@Airblader Could you help me to review this pr ? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
}, {
"hash" : "a392282483107bb6b985d9ff724d65d602a86a73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337",
"triggerID" : "a392282483107bb6b985d9ff724d65d602a86a73",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "970413494",
"triggerType" : "MANUAL"
}, {
"hash" : "5ee2449e410094eec0c7523a4dfee58091668398",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27678",
"triggerID" : "5ee2449e410094eec0c7523a4dfee58091668398",
"triggerType" : "PUSH"
}, {
"hash" : "5378879134e1c08ada5239c650d2ce77cff0f3e3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27776",
"triggerID" : "5378879134e1c08ada5239c650d2ce77cff0f3e3",
"triggerType" : "PUSH"
}, {
"hash" : "f618e423b7998cbde46da324ac80e78d24e9f1c1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27810",
"triggerID" : "f618e423b7998cbde46da324ac80e78d24e9f1c1",
"triggerType" : "PUSH"
}, {
"hash" : "221c55a17c058548d778f414ec97a70ef182aa2c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27834",
"triggerID" : "221c55a17c058548d778f414ec97a70ef182aa2c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 221c55a17c058548d778f414ec97a70ef182aa2c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27834)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17692:
URL: https://github.com/apache/flink/pull/17692#discussion_r764695828
##########
File path: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/sharedbuffer/SharedBufferTest.java
##########
@@ -37,12 +43,25 @@
import static org.junit.Assert.assertTrue;
/** Tests for {@link SharedBuffer}. */
+@RunWith(Parameterized.class)
public class SharedBufferTest extends TestLogger {
+ public static final SharedBufferCacheConfig MINI_CACHE_CONFIG =
+ new SharedBufferCacheConfig(1, 1, Duration.ofSeconds(1L));
+ public static final SharedBufferCacheConfig BIG_CACHE_CONFIG =
+ new SharedBufferCacheConfig(10240, 10240, Duration.ofSeconds(1L));
+
+ @Parameterized.Parameter public SharedBufferCacheConfig jobParameters;
Review comment:
nit: rename to cache config.
##########
File path: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/sharedbuffer/SharedBufferTest.java
##########
@@ -289,7 +308,7 @@ public void testSharedBufferCountersClearing() throws Exception {
@Test
public void testSharedBufferAccessor() throws Exception {
TestSharedBuffer<Event> sharedBuffer =
- TestSharedBuffer.createTestBuffer(Event.createTypeSerializer());
+ TestSharedBuffer.createTestBuffer(Event.createTypeSerializer(), BIG_CACHE_CONFIG);
Review comment:
This should probably use `jobParameters`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
}, {
"hash" : "a392282483107bb6b985d9ff724d65d602a86a73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337",
"triggerID" : "a392282483107bb6b985d9ff724d65d602a86a73",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "970413494",
"triggerType" : "MANUAL"
}, {
"hash" : "5ee2449e410094eec0c7523a4dfee58091668398",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27678",
"triggerID" : "5ee2449e410094eec0c7523a4dfee58091668398",
"triggerType" : "PUSH"
}, {
"hash" : "5378879134e1c08ada5239c650d2ce77cff0f3e3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27776",
"triggerID" : "5378879134e1c08ada5239c650d2ce77cff0f3e3",
"triggerType" : "PUSH"
}, {
"hash" : "f618e423b7998cbde46da324ac80e78d24e9f1c1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27810",
"triggerID" : "f618e423b7998cbde46da324ac80e78d24e9f1c1",
"triggerType" : "PUSH"
}, {
"hash" : "221c55a17c058548d778f414ec97a70ef182aa2c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27834",
"triggerID" : "221c55a17c058548d778f414ec97a70ef182aa2c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f618e423b7998cbde46da324ac80e78d24e9f1c1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27810)
* 221c55a17c058548d778f414ec97a70ef182aa2c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27834)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
RocMarshal edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-988966271
@AHeise Thank you very much for your comments, which makes us closer to higher quality step by step. It's really great. I have benefited a lot.
I have been striving for the best improvement according to your suggestions, which makes me unable to reply to you in time. So sorry for this.
I added some documentation about the new configuration parameters, Maybe it could meet our will for the standard.
If there is anything wrong, I am very happy to make the next change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
}, {
"hash" : "a392282483107bb6b985d9ff724d65d602a86a73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337",
"triggerID" : "a392282483107bb6b985d9ff724d65d602a86a73",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "970413494",
"triggerType" : "MANUAL"
}, {
"hash" : "5ee2449e410094eec0c7523a4dfee58091668398",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27678",
"triggerID" : "5ee2449e410094eec0c7523a4dfee58091668398",
"triggerType" : "PUSH"
}, {
"hash" : "5378879134e1c08ada5239c650d2ce77cff0f3e3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27776",
"triggerID" : "5378879134e1c08ada5239c650d2ce77cff0f3e3",
"triggerType" : "PUSH"
}, {
"hash" : "f618e423b7998cbde46da324ac80e78d24e9f1c1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f618e423b7998cbde46da324ac80e78d24e9f1c1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5378879134e1c08ada5239c650d2ce77cff0f3e3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27776)
* f618e423b7998cbde46da324ac80e78d24e9f1c1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d1a9dd220650005d60138be5f69ed5df511c263d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074)
* 59391b06ac7eb512b298dfcaa49847d20bb32c7e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 59391b06ac7eb512b298dfcaa49847d20bb32c7e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on a change in pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on a change in pull request #17692:
URL: https://github.com/apache/flink/pull/17692#discussion_r763635002
##########
File path: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/SharedBuffer.java
##########
@@ -73,33 +88,105 @@
private final MapState<NodeId, Lockable<SharedBufferNode>> entries;
/** The cache of eventsBuffer State. */
- private final Map<EventId, Lockable<V>> eventsBufferCache = new HashMap<>();
+ private final Cache<EventId, Lockable<V>> eventsBufferCache;
/** The cache of sharedBufferNode. */
- private final Map<NodeId, Lockable<SharedBufferNode>> entryCache = new HashMap<>();
+ private final Cache<NodeId, Lockable<SharedBufferNode>> entryCache;
+
+ private final Timer cacheStatisticsTimer;
+ @VisibleForTesting
public SharedBuffer(KeyedStateStore stateStore, TypeSerializer<V> valueSerializer) {
+ this(stateStore, valueSerializer, new Configuration());
+ }
+
+ public SharedBuffer(
+ KeyedStateStore stateStore,
+ TypeSerializer<V> valueSerializer,
+ ExecutionConfig.GlobalJobParameters globalJobParameters) {
Review comment:
@AHeise Thanks a lot for the reply. And I updated it bases on your comments. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d1a9dd220650005d60138be5f69ed5df511c263d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-969035044
> The situation is a bit odd. I think we shouldn't have a cache on top of rocks DB at all. We could think about having a cache in rocks DB itself.
>
> Nevertheless, the cache is there and causes trouble for you. I understood now that your changes are not impacting correctness but only performance, so I think your contribution certainly is welcome.
>
> To reiterate from my first rough review: Could you please add a (unit) test and make the configuration descriptions easier to understand for folks that have not read the CEP code?
Thanks so much for your @AHeise reply and explanation, which make me suddenly see the light.
As updated in the `CEPCacheOptions`:
`
And it could accelerate the CEP operate process speed and limit the capacity of cache in pure memory. Note: It's only effective to limit usage of memory when 'state.backend' was set as 'rocksdb', which would transport the elements exceeded the number of the cache into the rocksdb state storage instead of memory state storage.
`
The minor pr is really helpful for memory limitation when the `state.backend` is set as `rocksdb`.
By contrast，when the `state.backend` is set as not `rocksdb`, the current cache in the pr would cause performance decreased. Compared with old cache , the state part will contain more elements swapped out from new guava-cache ,which would make it heavier to `copy on write` for state .
In my limited read, if the positive significance of the pr is bigger than the side-effects of the pr, it would be worthy to do.
And Please let me know what do you think of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-968890973
The situation is a bit odd. I think we shouldn't have a cache on top of rocks DB at all. We could think about having a cache in rocks DB itself.
Nevertheless, the cache is there and causes trouble for you. I understood now that your changes are not impacting correctness but only performance, so I think your contribution certainly is welcome.
To reiterate from my first rough review: Could you please add a (unit) test and make the configuration descriptions easier to understand for folks that have not read the CEP code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
}, {
"hash" : "a392282483107bb6b985d9ff724d65d602a86a73",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337",
"triggerID" : "a392282483107bb6b985d9ff724d65d602a86a73",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 59391b06ac7eb512b298dfcaa49847d20bb32c7e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254)
* a392282483107bb6b985d9ff724d65d602a86a73 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
RocMarshal edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-963105801
@Airblader @AHeise @klion26 Could you help me to review this pr ? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-966724208
> What are you trying to solve? Could you please fill out the PR form correctly? I understand what your are doing on technical side but I don't understand why it's necessary. The ticket is also not giving any context information whatsoever.
>
> I'm also interested in the side-effects. If we remove events prematurely do we miss certain patterns? Are we trading memory for correctness here?
>
> You also should supply a test for your change.
@AHeise I'm very sorry for such hasty description for the jira ticket and the PR. I uploaded the jvm memory dump file analyze result in the ticket and added a comment. I'm much obliged to you for helping me looking into the significance of the ticket.
And after the discussion result of the ticket , I'll make response in closing it or re-filling out the PR form to advance it for the PR.
Thanks again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
}, {
"hash" : "a392282483107bb6b985d9ff724d65d602a86a73",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337",
"triggerID" : "a392282483107bb6b985d9ff724d65d602a86a73",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a392282483107bb6b985d9ff724d65d602a86a73 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337)
* 22a0824281feec714d8182e287e1abe275b4c4ff UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
}, {
"hash" : "a392282483107bb6b985d9ff724d65d602a86a73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337",
"triggerID" : "a392282483107bb6b985d9ff724d65d602a86a73",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "970413494",
"triggerType" : "MANUAL"
}, {
"hash" : "5ee2449e410094eec0c7523a4dfee58091668398",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27678",
"triggerID" : "5ee2449e410094eec0c7523a4dfee58091668398",
"triggerType" : "PUSH"
}, {
"hash" : "5378879134e1c08ada5239c650d2ce77cff0f3e3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27776",
"triggerID" : "5378879134e1c08ada5239c650d2ce77cff0f3e3",
"triggerType" : "PUSH"
}, {
"hash" : "f618e423b7998cbde46da324ac80e78d24e9f1c1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27810",
"triggerID" : "f618e423b7998cbde46da324ac80e78d24e9f1c1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f618e423b7998cbde46da324ac80e78d24e9f1c1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27810)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise merged pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
AHeise merged pull request #17692:
URL: https://github.com/apache/flink/pull/17692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
}, {
"hash" : "a392282483107bb6b985d9ff724d65d602a86a73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337",
"triggerID" : "a392282483107bb6b985d9ff724d65d602a86a73",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "970413494",
"triggerType" : "MANUAL"
}, {
"hash" : "5ee2449e410094eec0c7523a4dfee58091668398",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27678",
"triggerID" : "5ee2449e410094eec0c7523a4dfee58091668398",
"triggerType" : "PUSH"
}, {
"hash" : "5378879134e1c08ada5239c650d2ce77cff0f3e3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27776",
"triggerID" : "5378879134e1c08ada5239c650d2ce77cff0f3e3",
"triggerType" : "PUSH"
}, {
"hash" : "f618e423b7998cbde46da324ac80e78d24e9f1c1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27810",
"triggerID" : "f618e423b7998cbde46da324ac80e78d24e9f1c1",
"triggerType" : "PUSH"
}, {
"hash" : "221c55a17c058548d778f414ec97a70ef182aa2c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "221c55a17c058548d778f414ec97a70ef182aa2c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f618e423b7998cbde46da324ac80e78d24e9f1c1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27810)
* 221c55a17c058548d778f414ec97a70ef182aa2c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
}, {
"hash" : "a392282483107bb6b985d9ff724d65d602a86a73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337",
"triggerID" : "a392282483107bb6b985d9ff724d65d602a86a73",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "970413494",
"triggerType" : "MANUAL"
}, {
"hash" : "5ee2449e410094eec0c7523a4dfee58091668398",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27678",
"triggerID" : "5ee2449e410094eec0c7523a4dfee58091668398",
"triggerType" : "PUSH"
}, {
"hash" : "5378879134e1c08ada5239c650d2ce77cff0f3e3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27776",
"triggerID" : "5378879134e1c08ada5239c650d2ce77cff0f3e3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5378879134e1c08ada5239c650d2ce77cff0f3e3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27776)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
}, {
"hash" : "a392282483107bb6b985d9ff724d65d602a86a73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337",
"triggerID" : "a392282483107bb6b985d9ff724d65d602a86a73",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "970413494",
"triggerType" : "MANUAL"
}, {
"hash" : "5ee2449e410094eec0c7523a4dfee58091668398",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27678",
"triggerID" : "5ee2449e410094eec0c7523a4dfee58091668398",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5ee2449e410094eec0c7523a4dfee58091668398 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27678)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
}, {
"hash" : "a392282483107bb6b985d9ff724d65d602a86a73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337",
"triggerID" : "a392282483107bb6b985d9ff724d65d602a86a73",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "970413494",
"triggerType" : "MANUAL"
}, {
"hash" : "5ee2449e410094eec0c7523a4dfee58091668398",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5ee2449e410094eec0c7523a4dfee58091668398",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22a0824281feec714d8182e287e1abe275b4c4ff Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546)
* 5ee2449e410094eec0c7523a4dfee58091668398 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
}, {
"hash" : "a392282483107bb6b985d9ff724d65d602a86a73",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337",
"triggerID" : "a392282483107bb6b985d9ff724d65d602a86a73",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a392282483107bb6b985d9ff724d65d602a86a73 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d04e7822113ea65023d9311494cb67343d92fc34 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d04e7822113ea65023d9311494cb67343d92fc34 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017)
* d1a9dd220650005d60138be5f69ed5df511c263d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
}, {
"hash" : "a392282483107bb6b985d9ff724d65d602a86a73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337",
"triggerID" : "a392282483107bb6b985d9ff724d65d602a86a73",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "970413494",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 22a0824281feec714d8182e287e1abe275b4c4ff Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal removed a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
RocMarshal removed a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-979931489
@AHeise
Thank you very much for your help. Happy Thanksgiving Day!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-975326825
> In my limited read, if the positive significance of the pr is bigger than the side-effects of the pr, it would be worthy to do. And Please let me know what do you think of it.
Yes, I agree. So if you could address my initial comments (making the description more easy to understand for high-level CEP users), then I could merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17692:
URL: https://github.com/apache/flink/pull/17692#discussion_r764120930
##########
File path: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/configuration/SharedBufferCacheConfig.java
##########
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.cep.configuration;
+
+import org.apache.flink.api.common.ExecutionConfig;
+import org.apache.flink.configuration.Configuration;
+
+import java.io.Serializable;
+import java.time.Duration;
+
+import static org.apache.flink.cep.configuration.CEPCacheOptions.CEP_CACHE_STATISTICS_INTERVAL;
+import static org.apache.flink.cep.configuration.CEPCacheOptions.CEP_SHARED_BUFFER_ENTRY_CACHE_SLOTS;
+import static org.apache.flink.cep.configuration.CEPCacheOptions.CEP_SHARED_BUFFER_EVENT_CACHE_SLOTS;
+
+/** Configuration immutable class. */
+public final class SharedBufferCacheConfig implements Serializable {
+ private final int eventsBufferCacheSlots;
+ private final int entryCacheSlots;
+ private final Duration cacheStatisticsInterval;
+
+ public int getEventsBufferCacheSlots() {
+ return eventsBufferCacheSlots;
+ }
+
+ public int getEntryCacheSlots() {
+ return entryCacheSlots;
+ }
+
+ public Duration getCacheStatisticsInterval() {
+ return cacheStatisticsInterval;
+ }
+
+ public SharedBufferCacheConfig() {
+ this.cacheStatisticsInterval = CEP_CACHE_STATISTICS_INTERVAL.defaultValue();
+ this.entryCacheSlots = CEP_SHARED_BUFFER_ENTRY_CACHE_SLOTS.defaultValue();
+ this.eventsBufferCacheSlots = CEP_SHARED_BUFFER_EVENT_CACHE_SLOTS.defaultValue();
+ }
+
+ public SharedBufferCacheConfig(
+ final int eventsBufferCacheSlots,
+ final int entryCacheSlots,
+ final Duration cacheStatisticsInterval) {
+ this.cacheStatisticsInterval = cacheStatisticsInterval;
+ this.entryCacheSlots = entryCacheSlots;
+ this.eventsBufferCacheSlots = eventsBufferCacheSlots;
+ }
+
+ public static SharedBufferCacheConfig of(
+ ExecutionConfig.GlobalJobParameters globalJobParameters) {
Review comment:
Please use `ReadableConfig` here. `GlobalJobParameters` is only for pure user code.
##########
File path: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/sharedbuffer/SharedBufferTest.java
##########
@@ -18,31 +18,47 @@
package org.apache.flink.cep.nfa.sharedbuffer;
+import org.apache.flink.api.common.ExecutionConfig;
import org.apache.flink.cep.Event;
import org.apache.flink.cep.nfa.DeweyNumber;
import org.apache.flink.cep.utils.TestSharedBuffer;
+import org.apache.flink.configuration.Configuration;
import org.apache.flink.util.TestLogger;
import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
import java.util.HashMap;
import java.util.Iterator;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
+import static org.apache.flink.cep.utils.TestSharedBuffer.BIG_CACHE_CONFIG;
+import static org.apache.flink.cep.utils.TestSharedBuffer.MINI_CACHE_CONFIG;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
/** Tests for {@link SharedBuffer}. */
+@RunWith(Parameterized.class)
public class SharedBufferTest extends TestLogger {
+ @Parameterized.Parameter public ExecutionConfig.GlobalJobParameters jobParameters;
Review comment:
Can we directly use `SharedBufferCacheConfig` here?
##########
File path: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/CepOperator.java
##########
@@ -180,7 +181,12 @@ public void initializeState(StateInitializationContext context) throws Exception
new ValueStateDescriptor<>(
NFA_STATE_NAME, new NFAStateSerializer()));
- partialMatches = new SharedBuffer<>(context.getKeyedStateStore(), inputSerializer);
+ partialMatches =
+ new SharedBuffer<>(
+ context.getKeyedStateStore(),
+ inputSerializer,
+ SharedBufferCacheConfig.of(
+ cepRuntimeContext.getExecutionConfig().getGlobalJobParameters()));
Review comment:
`getOperatorConfig().getConfiguration()`
##########
File path: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/utils/TestSharedBuffer.java
##########
@@ -30,27 +31,57 @@
import org.apache.flink.api.common.state.ValueState;
import org.apache.flink.api.common.state.ValueStateDescriptor;
import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.cep.configuration.CEPCacheOptions;
+import org.apache.flink.cep.configuration.SharedBufferCacheConfig;
import org.apache.flink.cep.nfa.sharedbuffer.SharedBuffer;
+import org.apache.flink.configuration.Configuration;
import java.io.IOException;
+import java.time.Duration;
import java.util.Collections;
import java.util.HashMap;
import java.util.Iterator;
import java.util.Map;
+import java.util.concurrent.TimeUnit;
/**
* Extends {@link SharedBuffer} with methods for checking the number of state accesses. It does not
* use a proper StateBackend, but uses stubs over java collections.
*/
public class TestSharedBuffer<V> extends SharedBuffer<V> {
+ public static final Configuration MINI_CACHE_CONFIG = new Configuration();
+ public static final Configuration BIG_CACHE_CONFIG = new Configuration();
+
+ static {
+ MINI_CACHE_CONFIG.set(CEPCacheOptions.CEP_SHARED_BUFFER_ENTRY_CACHE_SLOTS, 1);
+ MINI_CACHE_CONFIG.set(CEPCacheOptions.CEP_SHARED_BUFFER_EVENT_CACHE_SLOTS, 1);
+ MINI_CACHE_CONFIG.set(
+ CEPCacheOptions.CEP_CACHE_STATISTICS_INTERVAL,
+ Duration.ofMillis(TimeUnit.SECONDS.toMillis(1)));
+
+ BIG_CACHE_CONFIG.set(CEPCacheOptions.CEP_SHARED_BUFFER_ENTRY_CACHE_SLOTS, 10240);
+ BIG_CACHE_CONFIG.set(CEPCacheOptions.CEP_SHARED_BUFFER_EVENT_CACHE_SLOTS, 10240);
+ BIG_CACHE_CONFIG.set(
+ CEPCacheOptions.CEP_CACHE_STATISTICS_INTERVAL,
+ Duration.ofMillis(TimeUnit.SECONDS.toMillis(1)));
+ }
+
Review comment:
Use `SharedBufferCacheConfig`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-988966271
@AHeise Thank you very much for your comments, which makes us closer to higher quality step by step. It's really great. I have benefited a lot.
I have been striving for the best improvement according to your suggestions, which makes me unable to reply to you in time. So sorry for this.
I added some documentation about the new configuration parameters, Maybe it could meet our will for the standard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
}, {
"hash" : "a392282483107bb6b985d9ff724d65d602a86a73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337",
"triggerID" : "a392282483107bb6b985d9ff724d65d602a86a73",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "970413494",
"triggerType" : "MANUAL"
}, {
"hash" : "5ee2449e410094eec0c7523a4dfee58091668398",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27678",
"triggerID" : "5ee2449e410094eec0c7523a4dfee58091668398",
"triggerType" : "PUSH"
}, {
"hash" : "5378879134e1c08ada5239c650d2ce77cff0f3e3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27776",
"triggerID" : "5378879134e1c08ada5239c650d2ce77cff0f3e3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5ee2449e410094eec0c7523a4dfee58091668398 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27678)
* 5378879134e1c08ada5239c650d2ce77cff0f3e3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27776)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
}, {
"hash" : "a392282483107bb6b985d9ff724d65d602a86a73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337",
"triggerID" : "a392282483107bb6b985d9ff724d65d602a86a73",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "970413494",
"triggerType" : "MANUAL"
}, {
"hash" : "5ee2449e410094eec0c7523a4dfee58091668398",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27678",
"triggerID" : "5ee2449e410094eec0c7523a4dfee58091668398",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22a0824281feec714d8182e287e1abe275b4c4ff Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546)
* 5ee2449e410094eec0c7523a4dfee58091668398 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27678)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #17692:
URL: https://github.com/apache/flink/pull/17692#discussion_r747261841
##########
File path: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/configuration/CEPCacheOptions.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.cep.configuration;
+
+import org.apache.flink.configuration.ConfigOption;
+import org.apache.flink.configuration.ConfigOptions;
+import org.apache.flink.util.TimeUtils;
+
+import java.time.Duration;
+
+/** CEP Cache Options. */
+public class CEPCacheOptions {
+
+ private CEPCacheOptions() {}
+
+ public static final ConfigOption<Integer> CEP_SHARED_BUFFER_EVENT_CACHE_SLOTS =
+ ConfigOptions.key("pipeline.global-job-parameters.cep.sharedbuffer.event-cache-slots")
Review comment:
The cache options seem to be described way too technical. How should an end-user understand what's going on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-961748638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d04e7822113ea65023d9311494cb67343d92fc34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26017",
"triggerID" : "d04e7822113ea65023d9311494cb67343d92fc34",
"triggerType" : "PUSH"
}, {
"hash" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26074",
"triggerID" : "d1a9dd220650005d60138be5f69ed5df511c263d",
"triggerType" : "PUSH"
}, {
"hash" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26254",
"triggerID" : "59391b06ac7eb512b298dfcaa49847d20bb32c7e",
"triggerType" : "PUSH"
}, {
"hash" : "a392282483107bb6b985d9ff724d65d602a86a73",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26337",
"triggerID" : "a392282483107bb6b985d9ff724d65d602a86a73",
"triggerType" : "PUSH"
}, {
"hash" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546",
"triggerID" : "22a0824281feec714d8182e287e1abe275b4c4ff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 22a0824281feec714d8182e287e1abe275b4c4ff Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26546)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-970413494
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org