[GitHub] [incubator-yunikorn-k8shim] anuraagnalluri commented on a change in pull request #369: [YUNIKORN-1040] add e2e test that re-starts the scheduler pod

[GitBox <gi...@apache.org>]

anuraagnalluri commented on a change in pull request #369:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/369#discussion_r805757606



##########
File path: test/e2e/basic_scheduling/basic_scheduling_test.go
##########
@@ -70,6 +70,17 @@ var _ = ginkgo.Describe("", func() {
 		Ω(err3).NotTo(HaveOccurred())
 		Ω(d).NotTo(BeNil())
 
+		ginkgo.By("Restart scheduler pod")
+		var podList, err4 = kClient.GetPods(configmanager.YuniKornTestConfig.YkNamespace)
+		Ω(err4).NotTo(HaveOccurred())
+		Ω(podList).NotTo(BeNil())
+		_, err5 := kClient.ScaleDeployment(configmanager.YKScheduler, 0, configmanager.YuniKornTestConfig.YkNamespace)
+		gomega.Ω(err5).NotTo(gomega.HaveOccurred())
+		err6 := kClient.WaitForPodBySelectorTerminated(configmanager.YuniKornTestConfig.YkNamespace, fmt.Sprintf("component=%s", configmanager.SchedulerName), 10)
+		kClient.ScaleDeployment(configmanager.YKScheduler, 1, configmanager.YuniKornTestConfig.YkNamespace)
+		gomega.Ω(err6).NotTo(gomega.HaveOccurred())
+		kClient.WaitForPodBySelectorRunning(configmanager.YuniKornTestConfig.YkNamespace, fmt.Sprintf("component=%s", configmanager.SchedulerName), 10)
+

Review comment:
       @wilfred-s Apologies if I missed the mark here, but I couldn't find a better place to include scheduler pod restart than the `BeforeSuite` of `basic_scheduling_test`. Please do advise if you have a better place in mind.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org