You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gossip.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/21 14:29:04 UTC
[jira] [Commented] (GOSSIP-81) Move code into separate packages for
Jackson and UDP
[ https://issues.apache.org/jira/browse/GOSSIP-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978820#comment-15978820 ]
ASF GitHub Bot commented on GOSSIP-81:
--------------------------------------
GitHub user gdusbabek opened a pull request:
https://github.com/apache/incubator-gossip/pull/48
GOSSIP-81 Move Jackson and UDP to their own modules
Part of what makes this work is the test implementation of TransportManager.
This PR is pretty straightforward. A few gotchas though:
* A message signing test was moved into `JacksonTests` because that is
where the signing actually happens.
* A CRDT serializing test was moved there as well. It's the best place
for now.
* No UDP tests at all. I plan to fix that in a bit. My reasoning is that it is difficult to test any TransportManager implementation without bringing up a full stack. I plan to address this in the future (GOSSIP-83).
Less notable:
* Simple round trip Jackson serialization tests.
* Added missing license header on a few files.
* Adjusted `StartupSettings` to take protocol- and transport-managers into account.
* Made `PassiveGossipThread` swallow `InterruptedException`s, which are completely normal.
* Moved some common dependencies to the parent.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gdusbabek/incubator-gossip GOSSIP-81
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gossip/pull/48.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #48
----
commit e3010c8542ab02fc20766d3eb63f75c1560b7bc3
Author: Gary Dusbabek <gd...@gmail.com>
Date: 2017-04-19T18:46:04Z
GOSSIP-81 Move Jackson and UDP to their own modules
Part of what makes this work is the test implementation of TransportManager.
This PR is pretty straightforward. A few gotchas though:
* A message signing test was moved into `JacksonTests` because that is
where the signing actually happens.
* A CRDT serializing test was moved there as well. It's the best place
for now.
* No UDP tests at all. I plan to fix that in a bit. Reasoning is that it is
difficult to test any TransportManager implementation without bring up
a full stack. I plan to address this in the future (GOSSIP-83).
* Simple round trip Jackson serialization tests.
----
> Move code into separate packages for Jackson and UDP
> ----------------------------------------------------
>
> Key: GOSSIP-81
> URL: https://issues.apache.org/jira/browse/GOSSIP-81
> Project: Gossip
> Issue Type: Improvement
> Reporter: Gary Dusbabek
> Assignee: Gary Dusbabek
>
> * Try not to modify any code
> * Leave the UDP messages in core (messages needs it's own refactoring)
> * Try to include a few tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)