You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org> on 2021/04/07 21:21:27 UTC
[Impala-ASF-CR] IMPALA-10644: RangerAuthorizationFactory cannot be instantiated
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17282
Change subject: IMPALA-10644: RangerAuthorizationFactory cannot be instantiated
......................................................................
IMPALA-10644: RangerAuthorizationFactory cannot be instantiated
Earlier when the GBN was bumped up to 11920537 in commit
1ab1143 some of the solr dependencies were excluded. This causes
RangerAuthorizationFactory to initialization errors.
This patch reverts the dependency exclusion to fix the problem.
Testing: [WIP]
Change-Id: I1b6953b84fd28bb75f97516a3b7f40cd0a12af41
---
M fe/pom.xml
1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/17282/1
--
To view, visit http://gerrit.cloudera.org:8080/17282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b6953b84fd28bb75f97516a3b7f40cd0a12af41
Gerrit-Change-Number: 17282
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-10644: RangerAuthorizationFactory cannot be instantiated
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17282 )
Change subject: IMPALA-10644: RangerAuthorizationFactory cannot be instantiated
......................................................................
Patch Set 1:
(3 comments)
This looks good to me. I have a couple nits about comments, but I'm ready to +2 otherwise.
http://gerrit.cloudera.org:8080/#/c/17282/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17282/1//COMMIT_MSG@15
PS1, Line 15: Testing: [WIP]
Please fill this in whenever the tests are done
http://gerrit.cloudera.org:8080/#/c/17282/1/fe/pom.xml
File fe/pom.xml:
http://gerrit.cloudera.org:8080/#/c/17282/1/fe/pom.xml@a114
PS1, Line 114:
:
:
:
Nit: Can you add a tombstone comment saying that we are intentionally not excluding solr?
We've had a series of these exclusion issues, and it is hard to keep the history straight.
http://gerrit.cloudera.org:8080/#/c/17282/1/fe/pom.xml@a138
PS1, Line 138:
:
:
:
Nit: Same deal here: please add a tombstone comment saying that we are intentionally not excluding solr
--
To view, visit http://gerrit.cloudera.org:8080/17282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b6953b84fd28bb75f97516a3b7f40cd0a12af41
Gerrit-Change-Number: 17282
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Apr 2021 16:40:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10644: RangerAuthorizationFactory cannot be instantiated
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17282 )
Change subject: IMPALA-10644: RangerAuthorizationFactory cannot be instantiated
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/17282/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17282/1//COMMIT_MSG@15
PS1, Line 15: Testing: [WIP]
> Please fill this in whenever the tests are done
Unfortunately, I am not able to reproduce the issue in master branch. I am trying to reproduce it on a different environment and will update the details once they are done.
http://gerrit.cloudera.org:8080/#/c/17282/1/fe/pom.xml
File fe/pom.xml:
http://gerrit.cloudera.org:8080/#/c/17282/1/fe/pom.xml@a114
PS1, Line 114:
:
:
:
> Nit: Can you add a tombstone comment saying that we are intentionally not e
Done
http://gerrit.cloudera.org:8080/#/c/17282/1/fe/pom.xml@a138
PS1, Line 138:
:
:
:
> Nit: Same deal here: please add a tombstone comment saying that we are inte
Done
--
To view, visit http://gerrit.cloudera.org:8080/17282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b6953b84fd28bb75f97516a3b7f40cd0a12af41
Gerrit-Change-Number: 17282
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Apr 2021 22:54:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10644: RangerAuthorizationFactory cannot be instantiated
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17282 )
Change subject: IMPALA-10644: RangerAuthorizationFactory cannot be instantiated
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8638/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b6953b84fd28bb75f97516a3b7f40cd0a12af41
Gerrit-Change-Number: 17282
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Apr 2021 16:08:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10644: RangerAuthorizationFactory cannot be instantiated
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17282 )
Change subject: IMPALA-10644: RangerAuthorizationFactory cannot be instantiated
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7100/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/17282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b6953b84fd28bb75f97516a3b7f40cd0a12af41
Gerrit-Change-Number: 17282
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Apr 2021 15:58:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10644: RangerAuthorizationFactory cannot be instantiated
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17282 )
Change subject: IMPALA-10644: RangerAuthorizationFactory cannot be instantiated
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8518/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b6953b84fd28bb75f97516a3b7f40cd0a12af41
Gerrit-Change-Number: 17282
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Apr 2021 21:41:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10644: RangerAuthorizationFactory cannot be instantiated
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has uploaded a new patch set (#4) to the change originally created by Vihang Karajgaonkar. ( http://gerrit.cloudera.org:8080/17282 )
Change subject: IMPALA-10644: RangerAuthorizationFactory cannot be instantiated
......................................................................
IMPALA-10644: RangerAuthorizationFactory cannot be instantiated
Earlier when the GBN was bumped up to 11920537 in commit
1ab1143 some of the solr dependencies were excluded. This causes
RangerAuthorizationFactory to initialization errors.
This patch reverts the dependency exclusion to fix the problem.
Testing:
- Passes core job
Change-Id: I1b6953b84fd28bb75f97516a3b7f40cd0a12af41
---
M fe/pom.xml
1 file changed, 6 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/17282/4
--
To view, visit http://gerrit.cloudera.org:8080/17282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1b6953b84fd28bb75f97516a3b7f40cd0a12af41
Gerrit-Change-Number: 17282
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-10644: RangerAuthorizationFactory cannot be instantiated
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17282 )
Change subject: IMPALA-10644: RangerAuthorizationFactory cannot be instantiated
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b6953b84fd28bb75f97516a3b7f40cd0a12af41
Gerrit-Change-Number: 17282
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Apr 2021 21:56:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10644: RangerAuthorizationFactory cannot be instantiated
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17282 )
Change subject: IMPALA-10644: RangerAuthorizationFactory cannot be instantiated
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b6953b84fd28bb75f97516a3b7f40cd0a12af41
Gerrit-Change-Number: 17282
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Apr 2021 22:01:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10644: RangerAuthorizationFactory cannot be instantiated
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17282 )
Change subject: IMPALA-10644: RangerAuthorizationFactory cannot be instantiated
......................................................................
IMPALA-10644: RangerAuthorizationFactory cannot be instantiated
Earlier when the GBN was bumped up to 11920537 in commit
1ab1143 some of the solr dependencies were excluded. This causes
RangerAuthorizationFactory to initialization errors.
This patch reverts the dependency exclusion to fix the problem.
Testing:
- Passes core job
Change-Id: I1b6953b84fd28bb75f97516a3b7f40cd0a12af41
Reviewed-on: http://gerrit.cloudera.org:8080/17282
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
---
M fe/pom.xml
1 file changed, 6 insertions(+), 8 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Joe McDonnell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b6953b84fd28bb75f97516a3b7f40cd0a12af41
Gerrit-Change-Number: 17282
Gerrit-PatchSet: 5
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>