You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/05/25 19:05:41 UTC
Review Request 59579: Fixed flakiness in
MasterTest.EndpointsForHalfRemovedSlave.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59579/
-----------------------------------------------------------
Review request for mesos and Anand Mazumdar.
Repository: mesos
Description
-------
The test had a race between setting up an expectation and dispatching an
asynchronous operation that would satisfy the expectation (the former
needs to happen first).
Diffs
-----
src/tests/master_tests.cpp 1dfe5fd7c33c3c479175aa522fef1956f11f265c
Diff: https://reviews.apache.org/r/59579/diff/1/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 59579: Fixed flakiness in
MasterTest.EndpointsForHalfRemovedSlave.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59579/#review176216
-----------------------------------------------------------
Ship it!
Ship It!
- Anand Mazumdar
On May 25, 2017, 7:05 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59579/
> -----------------------------------------------------------
>
> (Updated May 25, 2017, 7:05 p.m.)
>
>
> Review request for mesos and Anand Mazumdar.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test had a race between setting up an expectation and dispatching an
> asynchronous operation that would satisfy the expectation (the former
> needs to happen first).
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 1dfe5fd7c33c3c479175aa522fef1956f11f265c
>
>
> Diff: https://reviews.apache.org/r/59579/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>