[PR] Fixed: jGrowl notifications never display due to dead jQuery-plugin paths (OFBIZ-13506) [ofbiz-framework]

["mridulpathak (via GitHub)" <gi...@apache.org>]

mridulpathak opened a new pull request, #1808:
URL: https://github.com/apache/ofbiz-framework/pull/1808

   showjGrowlMessage() in themes/common-theme/webapp/common-theme/js/util/OfbizUtil.js dynamically loaded jGrowl and Readmore.js from vendor paths under js/jquery/plugins/ that no longer exist, since those two plugins were migrated to npm-managed packages while only jGrowl's CSS was updated to the new location at the time; the resulting 404s made the internal importLibrary() loader's promise reject and fall into its default catch handler, which just logs a console error, so the success callback that actually shows the jGrowl toast never ran. This fix statically includes jgrowl's and readmore-js's JS in Theme.xml alongside the other npm-migrated plugins, the same way their CSS and Trumbowyg's JS are already wired in, and drops the now-dead importLibrary call from showjGrowlMessage. Verified live in a browser that the from/thru-date validation toast (triggered via plugins/date/FromThruDateCheck.js) now renders correctly, and confirmed this doesn't affect release24.09 since that branch 
 still has the vendored plugin files in place at the paths the code references.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fixed: jGrowl notifications never display due to dead jQuery-plugin paths (OFBIZ-13506) [ofbiz-framework]

["mridulpathak (via GitHub)" <gi...@apache.org>]

mridulpathak merged PR #1808:
URL: https://github.com/apache/ofbiz-framework/pull/1808


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org