You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/27 18:27:51 UTC

[GitHub] [tvm] vegaluisjose opened a new pull request #7351: [BYOC][Verilator] change runtime registry function name

vegaluisjose opened a new pull request #7351:
URL: https://github.com/apache/tvm/pull/7351


   I think snake case is more common throughout the codebase than camel case for registering functions
   
   @tmoreau89 @liangfu 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tmoreau89 commented on pull request #7351: [BYOC][Verilator] change runtime registry function name

Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #7351:
URL: https://github.com/apache/tvm/pull/7351#issuecomment-769600869


   Thank you @vegaluisjose the PR was merged.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] vegaluisjose commented on pull request #7351: [BYOC][Verilator] change runtime registry function name

Posted by GitBox <gi...@apache.org>.
vegaluisjose commented on pull request #7351:
URL: https://github.com/apache/tvm/pull/7351#issuecomment-768496534


   I don't think so, It is just that "name change"


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tmoreau89 merged pull request #7351: [BYOC][Verilator] change runtime registry function name

Posted by GitBox <gi...@apache.org>.
tmoreau89 merged pull request #7351:
URL: https://github.com/apache/tvm/pull/7351


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org