You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/11 15:30:12 UTC

[GitHub] [arrow] thisisnic commented on a diff in pull request #13786: ARROW-11699: [R] Implement dplyr::across() for mutate()

thisisnic commented on code in PR #13786:
URL: https://github.com/apache/arrow/pull/13786#discussion_r943625393


##########
r/R/dplyr-mutate.R:
##########
@@ -24,7 +24,9 @@ mutate.arrow_dplyr_query <- function(.data,
                                      .before = NULL,
                                      .after = NULL) {
   call <- match.call()
-  exprs <- ensure_named_exprs(quos(...))
+
+  expression_list <- unfold_across(.data, quos(...))
+  exprs <- ensure_named_exprs(expression_list)

Review Comment:
   Good spot, didn't see it could be used in `filter()`!  Opened a ticket now: [ARROW-17387](https://issues.apache.org/jira/browse/ARROW-17387)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org