You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Patrick Luby <pa...@sun.com> on 2001/11/28 00:09:14 UTC
Re: cvs commit: jakarta-tomcat-4.0/catalina/src/bin setenv.shcatalina.sh
tool-wrapper.sh
Jon,
What I could do is not distribute the "setenv.sh" file and, instead, check
for the existence of this file. If it exists (which would only occur if the
user has created the file), then catalina.sh and tools-wrapper.sh would
source it.
I think that would comply with your requirement. Also, should we put the
setenv.sh somewhere else as well.
If the above sounds OK, I can cvs remove the setenv.sh file and make the
sourcing conditional.
Thanks,
Patrick
Jon Stevens wrote:
>
> on 11/27/01 2:34 PM, "patrickl@apache.org" <pa...@apache.org> wrote:
>
> > Index: setenv.sh
> > ===================================================================
> > #!/bin/sh
> > #
> > -----------------------------------------------------------------------------
> > # setenv.sh - File to hold all user customizable environment variables
> > #
> > # $Id: setenv.sh,v 1.1 2001/11/27 22:34:25 patrickl Exp $
> > #
> > -----------------------------------------------------------------------------
> >
> > # To permanently set your JAVA_HOME environment variable, uncomment and
> > # customize the following line with the absolute path to your JAVA_HOME
> > # JAVA_HOME=/usr/java
>
> -1
>
> I don't think that this file should exist in CVS if it is a user file.
>
> The problem being that if a user upgrades to a new version of Catalina, then
> they will risk overwriting this file.
>
> Instead, it should be documented that the file needs to be created in order
> to be used.
>
> -jon
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
--
_____________________________________________________________________
Patrick Luby Email: patrick.luby@sun.com
Sun Microsystems Phone: 408-276-7471
901 San Antonio Road, USCA14-303
Palo Alto, CA 94303-4900
_____________________________________________________________________
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit:
jakarta-tomcat-4.0/catalina/src/binsetenv.shcatalina.sh tool-wrapper.sh
Posted by Jon Stevens <jo...@latchkey.com>.
on 11/27/01 6:11 PM, "Remy Maucherat" <re...@apache.org> wrote:
> Yes. I'm very cautious in the Windows installer to not overwrite the config
> files. It has lots of problems (which are slowly getting resolved), but not
> that one ;-)
>
> Remy
Actually, that is still a problem.
If the server.xml file changes between revisions of Tomcat, how do you
upgrade that file, other than by hand?
-jon
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: cvs commit: jakarta-tomcat-4.0/catalina/src/binsetenv.shcatalina.sh tool-wrapper.sh
Posted by Bernard D'Have <bd...@wanadoo.be>.
Patrick,
I think that you can include
setenv.sh.sample
setenv.bat.sample
It's the way used for /build.properties
Bernard
> -----Original Message-----
> From: Remy Maucherat [mailto:remm@apache.org]
> Sent: Wednesday, 28 November, 2001 03:12
> To: Tomcat Developers List
> Subject: Re: cvs commit:
> jakarta-tomcat-4.0/catalina/src/binsetenv.shcatalina.sh tool-wrapper.sh
>
>
> > on 11/27/01 3:09 PM, "Patrick Luby" <pa...@sun.com> wrote:
> >
> > > Jon,
> > >
> > > What I could do is not distribute the "setenv.sh" file and, instead,
> check
> > > for the existence of this file. If it exists (which would
> only occur if
> the
> > > user has created the file), then catalina.sh and
> tools-wrapper.sh would
> > > source it.
> > >
> > > I think that would comply with your requirement.
> >
> > Yes.
> >
> > > Also, should we put the setenv.sh somewhere else as well.
> >
> > In documentation.
> >
> > > If the above sounds OK, I can cvs remove the setenv.sh file
> and make the
> > > sourcing conditional.
> >
> > Yes. Thanks for the quick response.
> >
> > Just as a side note, we need to be more cautious about upgrades and how
> > users perform them. The server.xml is a big sore spot as well
> because that
> > is another file that needs to be changed by the users.
>
> Yes. I'm very cautious in the Windows installer to not overwrite
> the config
> files. It has lots of problems (which are slowly getting
> resolved), but not
> that one ;-)
>
> Remy
>
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-tomcat-4.0/catalina/src/binsetenv.shcatalina.sh tool-wrapper.sh
Posted by Remy Maucherat <re...@apache.org>.
> on 11/27/01 3:09 PM, "Patrick Luby" <pa...@sun.com> wrote:
>
> > Jon,
> >
> > What I could do is not distribute the "setenv.sh" file and, instead,
check
> > for the existence of this file. If it exists (which would only occur if
the
> > user has created the file), then catalina.sh and tools-wrapper.sh would
> > source it.
> >
> > I think that would comply with your requirement.
>
> Yes.
>
> > Also, should we put the setenv.sh somewhere else as well.
>
> In documentation.
>
> > If the above sounds OK, I can cvs remove the setenv.sh file and make the
> > sourcing conditional.
>
> Yes. Thanks for the quick response.
>
> Just as a side note, we need to be more cautious about upgrades and how
> users perform them. The server.xml is a big sore spot as well because that
> is another file that needs to be changed by the users.
Yes. I'm very cautious in the Windows installer to not overwrite the config
files. It has lots of problems (which are slowly getting resolved), but not
that one ;-)
Remy
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-tomcat-4.0/catalina/src/binsetenv.shcatalina.sh
tool-wrapper.sh
Posted by Patrick Luby <pa...@sun.com>.
Jon,
Jon Stevens wrote:
[snip]
>
> Just as a side note, we need to be more cautious about upgrades and how
> users perform them. The server.xml is a big sore spot as well because that
> is another file that needs to be changed by the users.
>
Thanks for catching this in my initial commit. I have removed the setenv.sh
from the respository and the scripts only source the file if it exists. I
also added this support for Windows as well.
I still need to document this optional feature.
Thanks,
Patrick
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-tomcat-4.0/catalina/src/bin
setenv.shcatalina.sh tool-wrapper.sh
Posted by Jon Stevens <jo...@latchkey.com>.
on 11/27/01 3:09 PM, "Patrick Luby" <pa...@sun.com> wrote:
> Jon,
>
> What I could do is not distribute the "setenv.sh" file and, instead, check
> for the existence of this file. If it exists (which would only occur if the
> user has created the file), then catalina.sh and tools-wrapper.sh would
> source it.
>
> I think that would comply with your requirement.
Yes.
> Also, should we put the setenv.sh somewhere else as well.
In documentation.
> If the above sounds OK, I can cvs remove the setenv.sh file and make the
> sourcing conditional.
Yes. Thanks for the quick response.
Just as a side note, we need to be more cautious about upgrades and how
users perform them. The server.xml is a big sore spot as well because that
is another file that needs to be changed by the users.
-jon
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>