You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2018/09/18 09:36:00 UTC

[jira] [Resolved] (OAK-7760) Use NIO in the implementation of FileAccess.Mapped#read

     [ https://issues.apache.org/jira/browse/OAK-7760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dürig resolved OAK-7760.
--------------------------------
       Resolution: Fixed
    Fix Version/s: 1.9.9

Fixed at http://svn.apache.org/viewvc?rev=1841209&view=rev. 

Thanks [~tmueller], [~frm] for the review. I included your concerns in the fix. 

> Use NIO in the implementation of FileAccess.Mapped#read
> -------------------------------------------------------
>
>                 Key: OAK-7760
>                 URL: https://issues.apache.org/jira/browse/OAK-7760
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>            Priority: Major
>             Fix For: 1.10, 1.9.9
>
>
> {{FileAccess.Random#read}} currently uses {{RandomAccessFile#readFully()}} to read a segment from a tar file. That method requires a byte array and does not work with {{ByteBuffer}} instances directly. To make this method more universal (e.g. to work also for off heap byte buffers) I would like to change it to use {{FileChannel#read}} instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)