You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by khalidhuseynov <gi...@git.apache.org> on 2016/11/15 08:55:32 UTC

[GitHub] zeppelin pull request #1636: [Docs] Add note on configuration of spark-yarn ...

GitHub user khalidhuseynov opened a pull request:

    https://github.com/apache/zeppelin/pull/1636

    [Docs] Add note on configuration of spark-yarn mode on docker

    ### What is this PR for?
    This adds note to configuration to make clear about `sparkmaster` hostname defined in `/etc/hosts`
    
    
    ### What type of PR is it?
    Improvement | Documentation
    
    ### Todos
    * [x] - add note
    
    ### What is the Jira issue?
    n/a
    
    ### How should this be tested?
    see documentation
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khalidhuseynov/incubator-zeppelin docs/spark-yarn-add-note-hostname

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1636.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1636
    
----
commit 9e4ad6889725efbc6ee9688247ea0bc4ccf1e0b3
Author: Khalid Huseynov <kh...@gmail.com>
Date:   2016-11-15T08:50:22Z

    add sparkmaster hostname note

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1636: [Docs] Add note on configuration of spark-yarn mode on...

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/1636
  
    @khalidhuseynov I see, then the change is looks good to me. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1636: [Docs] Add note on configuration of spark-yarn ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1636


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1636: [Docs] Add note on configuration of spark-yarn mode on...

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/1636
  
    @khalidhuseynov LGTM. Will merge if there are no more discussions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1636: [Docs] Add note on configuration of spark-yarn mode on...

Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:

    https://github.com/apache/zeppelin/pull/1636
  
    Could you also update the `yarn` docker file path to `$ZEPPELIN_HOME/scripts/docker/spark-cluster-managers/spark_yarn_cluster` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1636: [Docs] Add note on configuration of spark-yarn ...

Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov closed the pull request at:

    https://github.com/apache/zeppelin/pull/1636


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1636: [Docs] Add note on configuration of spark-yarn mode on...

Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:

    https://github.com/apache/zeppelin/pull/1636
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1636: [Docs] Add note on configuration of spark-yarn ...

Posted by khalidhuseynov <gi...@git.apache.org>.
GitHub user khalidhuseynov reopened a pull request:

    https://github.com/apache/zeppelin/pull/1636

    [Docs] Add note on configuration of spark-yarn mode on docker

    ### What is this PR for?
    This adds note to configuration to make clear about `sparkmaster` hostname defined in `/etc/hosts`
    
    
    ### What type of PR is it?
    Improvement | Documentation
    
    ### Todos
    * [x] - add note
    
    ### What is the Jira issue?
    n/a
    
    ### How should this be tested?
    see documentation
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khalidhuseynov/incubator-zeppelin docs/spark-yarn-add-note-hostname

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1636.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1636
    
----
commit 9e4ad6889725efbc6ee9688247ea0bc4ccf1e0b3
Author: Khalid Huseynov <kh...@gmail.com>
Date:   2016-11-15T08:50:22Z

    add sparkmaster hostname note

commit 887b4991438e1a009e407f9e4e8d384ad621cdd1
Author: Khalid Huseynov <kh...@gmail.com>
Date:   2016-11-15T14:21:20Z

    update docker file path yarn mode

commit 78e790760321505343522b93ce2da60e2e97fa2e
Author: Khalid Huseynov <kh...@gmail.com>
Date:   2016-11-15T14:25:20Z

    add note about sparkmaster to each section

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1636: [Docs] Add note on configuration of spark-yarn mode on...

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/1636
  
    The PR title says "Add note on configuration of **spark-yarn mode** on docker", 
    > **Note 2:** `sparkmaster` hostname used to run docker containers below should be defined in your `/etc/hosts`." 
    
    but this sentence is currently added under "Spark standalone mode" section. Is it intended? If not, I think it needs to be moved to [here](https://github.com/khalidhuseynov/incubator-zeppelin/blob/9e4ad6889725efbc6ee9688247ea0bc4ccf1e0b3/docs/install/spark_cluster_mode.md#spark-on-yarn-mode) I guess :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1636: [Docs] Add note on configuration of spark-yarn mode on...

Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/1636
  
    @AhyoungRyu actually I meant it for all three cases (standalone, yarn, mesos) and mistakenly added it only for standalone. So I changed it now and added small note for each case. let me know if there's a better way for that. 
    @astroshim fixed docker path 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---