You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Aniket Mokashi (JIRA)" <ji...@apache.org> on 2010/07/26 18:34:50 UTC
[jira] Created: (PIG-1517) Pig needs to support keywords in the
package name
Pig needs to support keywords in the package name
-------------------------------------------------
Key: PIG-1517
URL: https://issues.apache.org/jira/browse/PIG-1517
Project: Pig
Issue Type: Bug
Components: grunt
Reporter: Aniket Mokashi
Assignee: Aniket Mokashi
Priority: Minor
Fix For: 0.8.0
Pig needs to support keywords in the package name. Pig supports most of the keywords as this was fixed in https://issues.apache.org/jira/browse/PIG-656. There are a few missing tokens like "eq","gt","lt","gte","lte","neq" that need to be supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1517) Pig needs to support keywords in the
package name
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich updated PIG-1517:
--------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
patch committed; thanks, Aniket!
> Pig needs to support keywords in the package name
> -------------------------------------------------
>
> Key: PIG-1517
> URL: https://issues.apache.org/jira/browse/PIG-1517
> Project: Pig
> Issue Type: Bug
> Components: grunt
> Reporter: Aniket Mokashi
> Assignee: Aniket Mokashi
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: KeywordSupportName.patch, pigusergroup656.patch
>
>
> Pig needs to support keywords in the package name. Pig supports most of the keywords as this was fixed in https://issues.apache.org/jira/browse/PIG-656. There are a few missing tokens like "eq","gt","lt","gte","lte","neq" that need to be supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1517) Pig needs to support keywords in the
package name
Posted by "Aniket Mokashi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aniket Mokashi updated PIG-1517:
--------------------------------
Status: Patch Available (was: Open)
> Pig needs to support keywords in the package name
> -------------------------------------------------
>
> Key: PIG-1517
> URL: https://issues.apache.org/jira/browse/PIG-1517
> Project: Pig
> Issue Type: Bug
> Components: grunt
> Reporter: Aniket Mokashi
> Assignee: Aniket Mokashi
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: KeywordSupportName.patch, pigusergroup656.patch
>
>
> Pig needs to support keywords in the package name. Pig supports most of the keywords as this was fixed in https://issues.apache.org/jira/browse/PIG-656. There are a few missing tokens like "eq","gt","lt","gte","lte","neq" that need to be supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1517) Pig needs to support keywords in the
package name
Posted by "Aniket Mokashi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aniket Mokashi updated PIG-1517:
--------------------------------
Attachment: KeywordSupportName.patch
> Pig needs to support keywords in the package name
> -------------------------------------------------
>
> Key: PIG-1517
> URL: https://issues.apache.org/jira/browse/PIG-1517
> Project: Pig
> Issue Type: Bug
> Components: grunt
> Reporter: Aniket Mokashi
> Assignee: Aniket Mokashi
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: KeywordSupportName.patch, pigusergroup656.patch
>
>
> Pig needs to support keywords in the package name. Pig supports most of the keywords as this was fixed in https://issues.apache.org/jira/browse/PIG-656. There are a few missing tokens like "eq","gt","lt","gte","lte","neq" that need to be supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1517) Pig needs to support keywords in the
package name
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892982#action_12892982 ]
Olga Natkovich commented on PIG-1517:
-------------------------------------
I asked Aniket to add a test to make sure that we don't regress when we switch parsers. Once the new patch os submitted, I will review and commit it
> Pig needs to support keywords in the package name
> -------------------------------------------------
>
> Key: PIG-1517
> URL: https://issues.apache.org/jira/browse/PIG-1517
> Project: Pig
> Issue Type: Bug
> Components: grunt
> Reporter: Aniket Mokashi
> Assignee: Aniket Mokashi
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: pigusergroup656.patch
>
>
> Pig needs to support keywords in the package name. Pig supports most of the keywords as this was fixed in https://issues.apache.org/jira/browse/PIG-656. There are a few missing tokens like "eq","gt","lt","gte","lte","neq" that need to be supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1517) Pig needs to support keywords in the
package name
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892744#action_12892744 ]
Hadoop QA commented on PIG-1517:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12450481/pigusergroup656.patch
against trunk revision 979503.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/358/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/358/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/358/console
This message is automatically generated.
> Pig needs to support keywords in the package name
> -------------------------------------------------
>
> Key: PIG-1517
> URL: https://issues.apache.org/jira/browse/PIG-1517
> Project: Pig
> Issue Type: Bug
> Components: grunt
> Reporter: Aniket Mokashi
> Assignee: Aniket Mokashi
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: pigusergroup656.patch
>
>
> Pig needs to support keywords in the package name. Pig supports most of the keywords as this was fixed in https://issues.apache.org/jira/browse/PIG-656. There are a few missing tokens like "eq","gt","lt","gte","lte","neq" that need to be supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1517) Pig needs to support keywords in the
package name
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich updated PIG-1517:
--------------------------------
Status: Patch Available (was: Open)
> Pig needs to support keywords in the package name
> -------------------------------------------------
>
> Key: PIG-1517
> URL: https://issues.apache.org/jira/browse/PIG-1517
> Project: Pig
> Issue Type: Bug
> Components: grunt
> Reporter: Aniket Mokashi
> Assignee: Aniket Mokashi
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: pigusergroup656.patch
>
>
> Pig needs to support keywords in the package name. Pig supports most of the keywords as this was fixed in https://issues.apache.org/jira/browse/PIG-656. There are a few missing tokens like "eq","gt","lt","gte","lte","neq" that need to be supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1517) Pig needs to support keywords in the
package name
Posted by "Aniket Mokashi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aniket Mokashi updated PIG-1517:
--------------------------------
Attachment: pigusergroup656.patch
> Pig needs to support keywords in the package name
> -------------------------------------------------
>
> Key: PIG-1517
> URL: https://issues.apache.org/jira/browse/PIG-1517
> Project: Pig
> Issue Type: Bug
> Components: grunt
> Reporter: Aniket Mokashi
> Assignee: Aniket Mokashi
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: pigusergroup656.patch
>
>
> Pig needs to support keywords in the package name. Pig supports most of the keywords as this was fixed in https://issues.apache.org/jira/browse/PIG-656. There are a few missing tokens like "eq","gt","lt","gte","lte","neq" that need to be supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1517) Pig needs to support keywords in the
package name
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892867#action_12892867 ]
Olga Natkovich commented on PIG-1517:
-------------------------------------
Thanks, Aniket. I will review and commit the patch
> Pig needs to support keywords in the package name
> -------------------------------------------------
>
> Key: PIG-1517
> URL: https://issues.apache.org/jira/browse/PIG-1517
> Project: Pig
> Issue Type: Bug
> Components: grunt
> Reporter: Aniket Mokashi
> Assignee: Aniket Mokashi
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: pigusergroup656.patch
>
>
> Pig needs to support keywords in the package name. Pig supports most of the keywords as this was fixed in https://issues.apache.org/jira/browse/PIG-656. There are a few missing tokens like "eq","gt","lt","gte","lte","neq" that need to be supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1517) Pig needs to support keywords in the
package name
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893447#action_12893447 ]
Olga Natkovich commented on PIG-1517:
-------------------------------------
+1, changes look good. Will be committing the patch shortly
> Pig needs to support keywords in the package name
> -------------------------------------------------
>
> Key: PIG-1517
> URL: https://issues.apache.org/jira/browse/PIG-1517
> Project: Pig
> Issue Type: Bug
> Components: grunt
> Reporter: Aniket Mokashi
> Assignee: Aniket Mokashi
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: KeywordSupportName.patch, pigusergroup656.patch
>
>
> Pig needs to support keywords in the package name. Pig supports most of the keywords as this was fixed in https://issues.apache.org/jira/browse/PIG-656. There are a few missing tokens like "eq","gt","lt","gte","lte","neq" that need to be supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1517) Pig needs to support keywords in the
package name
Posted by "Aniket Mokashi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aniket Mokashi updated PIG-1517:
--------------------------------
Status: Open (was: Patch Available)
> Pig needs to support keywords in the package name
> -------------------------------------------------
>
> Key: PIG-1517
> URL: https://issues.apache.org/jira/browse/PIG-1517
> Project: Pig
> Issue Type: Bug
> Components: grunt
> Reporter: Aniket Mokashi
> Assignee: Aniket Mokashi
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: KeywordSupportName.patch, pigusergroup656.patch
>
>
> Pig needs to support keywords in the package name. Pig supports most of the keywords as this was fixed in https://issues.apache.org/jira/browse/PIG-656. There are a few missing tokens like "eq","gt","lt","gte","lte","neq" that need to be supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1517) Pig needs to support keywords in the
package name
Posted by "Aniket Mokashi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892863#action_12892863 ]
Aniket Mokashi commented on PIG-1517:
-------------------------------------
This bug is an extension of https://issues.apache.org/jira/browse/PIG-656, does not need extra test cases.
Other tests pass manually.
> Pig needs to support keywords in the package name
> -------------------------------------------------
>
> Key: PIG-1517
> URL: https://issues.apache.org/jira/browse/PIG-1517
> Project: Pig
> Issue Type: Bug
> Components: grunt
> Reporter: Aniket Mokashi
> Assignee: Aniket Mokashi
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: pigusergroup656.patch
>
>
> Pig needs to support keywords in the package name. Pig supports most of the keywords as this was fixed in https://issues.apache.org/jira/browse/PIG-656. There are a few missing tokens like "eq","gt","lt","gte","lte","neq" that need to be supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1517) Pig needs to support keywords in the
package name
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893519#action_12893519 ]
Hadoop QA commented on PIG-1517:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12450768/KeywordSupportName.patch
against trunk revision 980148.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/363/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/363/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/363/console
This message is automatically generated.
> Pig needs to support keywords in the package name
> -------------------------------------------------
>
> Key: PIG-1517
> URL: https://issues.apache.org/jira/browse/PIG-1517
> Project: Pig
> Issue Type: Bug
> Components: grunt
> Reporter: Aniket Mokashi
> Assignee: Aniket Mokashi
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: KeywordSupportName.patch, pigusergroup656.patch
>
>
> Pig needs to support keywords in the package name. Pig supports most of the keywords as this was fixed in https://issues.apache.org/jira/browse/PIG-656. There are a few missing tokens like "eq","gt","lt","gte","lte","neq" that need to be supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.