You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/22 14:31:56 UTC

[GitHub] [flink] slinkydeveloper opened a new pull request #18879: [FLINK-26280][table-planner] Add 'table.exec.legacy-transformation-uids' to support old transformation uid generation behaviour

slinkydeveloper opened a new pull request #18879:
URL: https://github.com/apache/flink/pull/18879


   Per discussion here https://issues.apache.org/jira/browse/FLINK-25932


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #18879: [FLINK-26280][table-planner] Add 'table.exec.legacy-transformation-uids' to support old transformation uid generation behaviour

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18879:
URL: https://github.com/apache/flink/pull/18879#issuecomment-1047859465


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 43905dfb9094eb3e5ddf4da7d95615330830aca4 (Tue Feb 22 14:35:15 UTC 2022)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] twalthr commented on a change in pull request #18879: [FLINK-26280][table-planner] Add 'table.exec.legacy-transformation-uids' to support old transformation uid generation behaviour

Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #18879:
URL: https://github.com/apache/flink/pull/18879#discussion_r816632406



##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecTableSourceScan.java
##########
@@ -131,15 +133,17 @@ public DynamicTableSourceSpec getTableSourceSpec() {
         } else if (provider instanceof DataStreamScanProvider) {
             Transformation<RowData> transformation =
                     ((DataStreamScanProvider) provider)
-                            .produceDataStream(createProviderContext(), env)
+                            .produceDataStream(
+                                    createProviderContext(planner.getConfiguration()), env)

Review comment:
       Use the new `ExecNodeConfig` here. `planner.getConfiguration()` should not be accessed directly anymore.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] matriv commented on a change in pull request #18879: [FLINK-26280][table-planner] Add 'table.exec.legacy-transformation-uids' to support old transformation uid generation behaviour

Posted by GitBox <gi...@apache.org>.
matriv commented on a change in pull request #18879:
URL: https://github.com/apache/flink/pull/18879#discussion_r816647640



##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecTableSourceScan.java
##########
@@ -131,15 +133,17 @@ public DynamicTableSourceSpec getTableSourceSpec() {
         } else if (provider instanceof DataStreamScanProvider) {
             Transformation<RowData> transformation =
                     ((DataStreamScanProvider) provider)
-                            .produceDataStream(createProviderContext(), env)
+                            .produceDataStream(
+                                    createProviderContext(planner.getConfiguration()), env)
                             .getTransformation();
             meta.fill(transformation);
             transformation.setOutputType(outputTypeInfo);
             return transformation;
         } else if (provider instanceof TransformationScanProvider) {
             final Transformation<RowData> transformation =
                     ((TransformationScanProvider) provider)
-                            .createTransformation(createProviderContext());
+                            .createTransformation(
+                                    createProviderContext(planner.getConfiguration()));

Review comment:
       same here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18879: [FLINK-26280][table-planner] Add 'table.exec.legacy-transformation-uids' to support old transformation uid generation behaviour

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18879:
URL: https://github.com/apache/flink/pull/18879#issuecomment-1047862078


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32035",
       "triggerID" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1d83b31d656b6b883ca5d4ed1bfdf2089c240620",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1d83b31d656b6b883ca5d4ed1bfdf2089c240620",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 43905dfb9094eb3e5ddf4da7d95615330830aca4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32035) 
   * 1d83b31d656b6b883ca5d4ed1bfdf2089c240620 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] slinkydeveloper commented on pull request #18879: [FLINK-26280][table-planner] Add 'table.exec.legacy-transformation-uids' to support old transformation uid generation behaviour

Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on pull request #18879:
URL: https://github.com/apache/flink/pull/18879#issuecomment-1055556275


   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18879: [FLINK-26280][table-planner] Add 'table.exec.legacy-transformation-uids' to support old transformation uid generation behaviour

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18879:
URL: https://github.com/apache/flink/pull/18879#issuecomment-1047862078


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32035",
       "triggerID" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1d83b31d656b6b883ca5d4ed1bfdf2089c240620",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32349",
       "triggerID" : "1d83b31d656b6b883ca5d4ed1bfdf2089c240620",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7cf2881c1e2ec51f481fdc8be191ce43f71d5cc3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32379",
       "triggerID" : "1055556275",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "7cf2881c1e2ec51f481fdc8be191ce43f71d5cc3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32379",
       "triggerID" : "7cf2881c1e2ec51f481fdc8be191ce43f71d5cc3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "",
       "status" : "DELETED",
       "url" : "TBD",
       "triggerID" : "1055556275",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 7cf2881c1e2ec51f481fdc8be191ce43f71d5cc3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32379) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #18879: [FLINK-26280][table-planner] Add 'table.exec.legacy-transformation-uids' to support old transformation uid generation behaviour

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18879:
URL: https://github.com/apache/flink/pull/18879#issuecomment-1047862078


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 43905dfb9094eb3e5ddf4da7d95615330830aca4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18879: [FLINK-26280][table-planner] Add 'table.exec.legacy-transformation-uids' to support old transformation uid generation behaviour

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18879:
URL: https://github.com/apache/flink/pull/18879#issuecomment-1047862078


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32035",
       "triggerID" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1d83b31d656b6b883ca5d4ed1bfdf2089c240620",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32349",
       "triggerID" : "1d83b31d656b6b883ca5d4ed1bfdf2089c240620",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7cf2881c1e2ec51f481fdc8be191ce43f71d5cc3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32379",
       "triggerID" : "1055556275",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "7cf2881c1e2ec51f481fdc8be191ce43f71d5cc3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32379",
       "triggerID" : "7cf2881c1e2ec51f481fdc8be191ce43f71d5cc3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "",
       "status" : "DELETED",
       "url" : "TBD",
       "triggerID" : "1055556275",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0e1cbada9abafe4ce40be2edff15fe95d2cb3995",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0e1cbada9abafe4ce40be2edff15fe95d2cb3995",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7cf2881c1e2ec51f481fdc8be191ce43f71d5cc3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32379) 
   * 0e1cbada9abafe4ce40be2edff15fe95d2cb3995 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18879: [FLINK-26280][table-planner] Add 'table.exec.legacy-transformation-uids' to support old transformation uid generation behaviour

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18879:
URL: https://github.com/apache/flink/pull/18879#issuecomment-1047862078


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32035",
       "triggerID" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 43905dfb9094eb3e5ddf4da7d95615330830aca4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32035) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] slinkydeveloper edited a comment on pull request #18879: [FLINK-26280][table-planner] Add 'table.exec.legacy-transformation-uids' to support old transformation uid generation behaviour

Posted by GitBox <gi...@apache.org>.
slinkydeveloper edited a comment on pull request #18879:
URL: https://github.com/apache/flink/pull/18879#issuecomment-1047867159


   @twalthr seems like when the flag is deprecated, the docs generator ignores it. At least, i tried to generate, but nothing changed. Perhaps for this flag is better to not show it in the docs? WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18879: [FLINK-26280][table-planner] Add 'table.exec.legacy-transformation-uids' to support old transformation uid generation behaviour

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18879:
URL: https://github.com/apache/flink/pull/18879#issuecomment-1047862078


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32035",
       "triggerID" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1d83b31d656b6b883ca5d4ed1bfdf2089c240620",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32349",
       "triggerID" : "1d83b31d656b6b883ca5d4ed1bfdf2089c240620",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7cf2881c1e2ec51f481fdc8be191ce43f71d5cc3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32379",
       "triggerID" : "1055556275",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "7cf2881c1e2ec51f481fdc8be191ce43f71d5cc3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32379",
       "triggerID" : "7cf2881c1e2ec51f481fdc8be191ce43f71d5cc3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "",
       "status" : "DELETED",
       "url" : "TBD",
       "triggerID" : "1055556275",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0e1cbada9abafe4ce40be2edff15fe95d2cb3995",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32417",
       "triggerID" : "0e1cbada9abafe4ce40be2edff15fe95d2cb3995",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0e1cbada9abafe4ce40be2edff15fe95d2cb3995 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32417) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18879: [FLINK-26280][table-planner] Add 'table.exec.legacy-transformation-uids' to support old transformation uid generation behaviour

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18879:
URL: https://github.com/apache/flink/pull/18879#issuecomment-1047862078


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32035",
       "triggerID" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 43905dfb9094eb3e5ddf4da7d95615330830aca4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32035) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] slinkydeveloper commented on pull request #18879: [FLINK-26280][table-planner] Add 'table.exec.legacy-transformation-uids' to support old transformation uid generation behaviour

Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on pull request #18879:
URL: https://github.com/apache/flink/pull/18879#issuecomment-1047867159


   @twalthr seems like when the flag is deprecated, the docs doesn't show the flag (at least, i tried to generate, but nothing changed). Perhaps for this flag is better to not show in the docs? WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18879: [FLINK-26280][table-planner] Add 'table.exec.legacy-transformation-uids' to support old transformation uid generation behaviour

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18879:
URL: https://github.com/apache/flink/pull/18879#issuecomment-1047862078


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32035",
       "triggerID" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1d83b31d656b6b883ca5d4ed1bfdf2089c240620",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32349",
       "triggerID" : "1d83b31d656b6b883ca5d4ed1bfdf2089c240620",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7cf2881c1e2ec51f481fdc8be191ce43f71d5cc3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1055556275",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "",
       "status" : "CANCELED",
       "url" : "TBD",
       "triggerID" : "1055556275",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "7cf2881c1e2ec51f481fdc8be191ce43f71d5cc3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7cf2881c1e2ec51f481fdc8be191ce43f71d5cc3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   *  Unknown: [CANCELED](TBD) 
   * 7cf2881c1e2ec51f481fdc8be191ce43f71d5cc3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] slinkydeveloper edited a comment on pull request #18879: [FLINK-26280][table-planner] Add 'table.exec.legacy-transformation-uids' to support old transformation uid generation behaviour

Posted by GitBox <gi...@apache.org>.
slinkydeveloper edited a comment on pull request #18879:
URL: https://github.com/apache/flink/pull/18879#issuecomment-1047867159


   @twalthr seems like when the flag is deprecated, the docs generator ignores it. At least, i tried to generate, but nothing changed. Perhaps for this flag is better to not show in the docs? WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18879: [FLINK-26280][table-planner] Add 'table.exec.legacy-transformation-uids' to support old transformation uid generation behaviour

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18879:
URL: https://github.com/apache/flink/pull/18879#issuecomment-1047862078


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32035",
       "triggerID" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1d83b31d656b6b883ca5d4ed1bfdf2089c240620",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32349",
       "triggerID" : "1d83b31d656b6b883ca5d4ed1bfdf2089c240620",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 43905dfb9094eb3e5ddf4da7d95615330830aca4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32035) 
   * 1d83b31d656b6b883ca5d4ed1bfdf2089c240620 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32349) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] twalthr closed pull request #18879: [FLINK-26280][table-planner] Add 'table.exec.legacy-transformation-uids' to support old transformation uid generation behaviour

Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #18879:
URL: https://github.com/apache/flink/pull/18879


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18879: [FLINK-26280][table-planner] Add 'table.exec.legacy-transformation-uids' to support old transformation uid generation behaviour

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18879:
URL: https://github.com/apache/flink/pull/18879#issuecomment-1047862078


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32035",
       "triggerID" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1d83b31d656b6b883ca5d4ed1bfdf2089c240620",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32349",
       "triggerID" : "1d83b31d656b6b883ca5d4ed1bfdf2089c240620",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1d83b31d656b6b883ca5d4ed1bfdf2089c240620 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32349) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18879: [FLINK-26280][table-planner] Add 'table.exec.legacy-transformation-uids' to support old transformation uid generation behaviour

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18879:
URL: https://github.com/apache/flink/pull/18879#issuecomment-1047862078


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32035",
       "triggerID" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1d83b31d656b6b883ca5d4ed1bfdf2089c240620",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32349",
       "triggerID" : "1d83b31d656b6b883ca5d4ed1bfdf2089c240620",
       "triggerType" : "PUSH"
     }, {
       "hash" : "",
       "status" : "CANCELED",
       "url" : "TBD",
       "triggerID" : "1055556275",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "7cf2881c1e2ec51f481fdc8be191ce43f71d5cc3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32379",
       "triggerID" : "1055556275",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "7cf2881c1e2ec51f481fdc8be191ce43f71d5cc3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32379",
       "triggerID" : "7cf2881c1e2ec51f481fdc8be191ce43f71d5cc3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   *  Unknown: [CANCELED](TBD) 
   * 7cf2881c1e2ec51f481fdc8be191ce43f71d5cc3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32379) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18879: [FLINK-26280][table-planner] Add 'table.exec.legacy-transformation-uids' to support old transformation uid generation behaviour

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18879:
URL: https://github.com/apache/flink/pull/18879#issuecomment-1047862078


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32035",
       "triggerID" : "43905dfb9094eb3e5ddf4da7d95615330830aca4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1d83b31d656b6b883ca5d4ed1bfdf2089c240620",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32349",
       "triggerID" : "1d83b31d656b6b883ca5d4ed1bfdf2089c240620",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7cf2881c1e2ec51f481fdc8be191ce43f71d5cc3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32379",
       "triggerID" : "1055556275",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "7cf2881c1e2ec51f481fdc8be191ce43f71d5cc3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32379",
       "triggerID" : "7cf2881c1e2ec51f481fdc8be191ce43f71d5cc3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "",
       "status" : "DELETED",
       "url" : "TBD",
       "triggerID" : "1055556275",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0e1cbada9abafe4ce40be2edff15fe95d2cb3995",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32417",
       "triggerID" : "0e1cbada9abafe4ce40be2edff15fe95d2cb3995",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7cf2881c1e2ec51f481fdc8be191ce43f71d5cc3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32379) 
   * 0e1cbada9abafe4ce40be2edff15fe95d2cb3995 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32417) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org