You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2018/11/06 10:32:09 UTC
[incubator-skywalking] branch master updated: Fix logs with missing
variables (#1884)
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 9269117 Fix logs with missing variables (#1884)
9269117 is described below
commit 926911700eb4c891d65124e95ddf4932d12d91a3
Author: ScienJus <i...@scienjus.com>
AuthorDate: Tue Nov 6 18:32:02 2018 +0800
Fix logs with missing variables (#1884)
---
.../org/apache/skywalking/oap/server/core/cache/CacheUpdateTimer.java | 2 +-
.../server/core/register/service/ServiceInstanceInventoryRegister.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/cache/CacheUpdateTimer.java b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/cache/CacheUpdateTimer.java
index 3d3cbdf..3f06ecc 100644
--- a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/cache/CacheUpdateTimer.java
+++ b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/cache/CacheUpdateTimer.java
@@ -64,7 +64,7 @@ public enum CacheUpdateTimer {
cache.setMappingServiceId(serviceInventory.getMappingServiceId());
cache.setMappingLastUpdateTime(serviceInventory.getMappingLastUpdateTime());
} else {
- logger.warn("Unable to found the id of {} in service inventory cache.");
+ logger.warn("Unable to found the id of {} in service inventory cache.", serviceInventory.getSequence());
}
});
}
diff --git a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/service/ServiceInstanceInventoryRegister.java b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/service/ServiceInstanceInventoryRegister.java
index 8bb47a2..c6b0e5e 100644
--- a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/service/ServiceInstanceInventoryRegister.java
+++ b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/service/ServiceInstanceInventoryRegister.java
@@ -107,7 +107,7 @@ public class ServiceInstanceInventoryRegister implements IServiceInstanceInvento
serviceInstanceInventory.setHeartbeatTime(heartBeatTime);
InventoryProcess.INSTANCE.in(serviceInstanceInventory);
} else {
- logger.warn("Service instance {} heartbeat, but not found in storage.");
+ logger.warn("Service instance {} heartbeat, but not found in storage.", serviceInstanceId);
}
}
}