You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/17 00:52:36 UTC
[GitHub] [spark] zero323 opened a new pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as formatter for
zero323 opened a new pull request #34297:
URL: https://github.com/apache/spark/pull/34297
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-946905265
**[Test build #144422 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144422/testReport)** for PR 34297 at commit [`0f7d7c8`](https://github.com/apache/spark/commit/0f7d7c8df0958a557294f5a06584ccfd14d8e980).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-945718704
**[Test build #144370 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144370/testReport)** for PR 34297 at commit [`abb4484`](https://github.com/apache/spark/commit/abb4484ad3c72700aab036323acba6eb26d91d80).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-947505924
**[Test build #144458 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144458/testReport)** for PR 34297 at commit [`d7b1f7b`](https://github.com/apache/spark/commit/d7b1f7b9e61f59f50c0debdb312382a23eafbe1e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-955053214
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49236/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-959269982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-958993806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-964947735
im gonna merge this to avoid more conflicts. This is a big change but I believe this makes dev much easier ... let's see how it gose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-964046805
I took a quick look, and I think this is fine to go ahead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as formatter for
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-944677894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-954838807
**[Test build #144760 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144760/testReport)** for PR 34297 at commit [`d6c16de`](https://github.com/apache/spark/commit/d6c16de823f8399c31fa5da6c0ad8cea6fcb47d0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-954950424
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144760/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-954906278
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49229/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-959269982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-958993806
**[Test build #144877 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144877/testReport)** for PR 34297 at commit [`a7386a4`](https://github.com/apache/spark/commit/a7386a452efedf59af655a3614f951346ede8361).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-964078298
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49494/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-964090079
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49495/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-964176747
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145022/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-963779329
Yup, otherwise looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-959170272
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49347/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-963750024
I'm okay with this change. @zero323 would you mind resolving the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
itholic commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-963832298
Which version of `black` do you use for this changes ? We should use `21.5b2`.
Looks like it's correct version, but just for double checking just in case. :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-963845981
PR description mentions `21.5b2` so we should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34297:
URL: https://github.com/apache/spark/pull/34297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-945824380
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48845/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-945839312
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48845/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-946905265
**[Test build #144422 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144422/testReport)** for PR 34297 at commit [`0f7d7c8`](https://github.com/apache/spark/commit/0f7d7c8df0958a557294f5a06584ccfd14d8e980).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-950004282
**[Test build #144549 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144549/testReport)** for PR 34297 at commit [`34559c9`](https://github.com/apache/spark/commit/34559c901b93221f2866030248fcd1f3dfa82e0d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as formatter for
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-944680717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-947501125
@srowen
So I've re-run this with a minimal config and the result can be found [here][https://github.com/apache/spark/compare/master...zero323:SPARK-37022-minimal?expand=1).
In terms of line diffs it is (+14 033, 9 169) vs. (+15 229, −9 312) ‒ probably not worth breaking from [the style guide](https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html?highlight=magic#the-black-code-style), but I am not strictly against it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-947016932
**[Test build #144422 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144422/testReport)** for PR 34297 at commit [`0f7d7c8`](https://github.com/apache/spark/commit/0f7d7c8df0958a557294f5a06584ccfd14d8e980).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-946983810
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48895/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] BryanCutler commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
BryanCutler commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-966682490
SGTM +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-954933155
**[Test build #144760 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144760/testReport)** for PR 34297 at commit [`d6c16de`](https://github.com/apache/spark/commit/d6c16de823f8399c31fa5da6c0ad8cea6fcb47d0).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-955000908
**[Test build #144767 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144767/testReport)** for PR 34297 at commit [`70b1ed0`](https://github.com/apache/spark/commit/70b1ed0f5d4942664ab9d0fb99c1e554eefd54ab).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-950026171
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49020/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-959269982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-964125706
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49495/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-964167455
**[Test build #145022 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145022/testReport)** for PR 34297 at commit [`359de15`](https://github.com/apache/spark/commit/359de15534172702cecee6ec717e86b313f8b8b7).
* This patch passes all tests.
* This patch **does not merge cleanly**.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-945718704
**[Test build #144370 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144370/testReport)** for PR 34297 at commit [`abb4484`](https://github.com/apache/spark/commit/abb4484ad3c72700aab036323acba6eb26d91d80).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-964128493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-964045042
**[Test build #145022 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145022/testReport)** for PR 34297 at commit [`359de15`](https://github.com/apache/spark/commit/359de15534172702cecee6ec717e86b313f8b8b7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-947629042
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144458/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 edited a comment on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
zero323 edited a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-947501125
@srowen
So I've re-run this with a minimal config and the result can be found [here](https://github.com/apache/spark/compare/master...zero323:SPARK-37022-minimal?expand=1).
In terms of line diffs it is (+14 033, 9 169) vs. (+15 229, −9 312) ‒ probably not worth breaking from [the style guide](https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html?highlight=magic#the-black-code-style), but I am not strictly against it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-955078423
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144767/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-955053214
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49236/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-959269982
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49347/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-959269982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-950029775
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49020/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-950038362
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144549/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-964045042
**[Test build #145022 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145022/testReport)** for PR 34297 at commit [`359de15`](https://github.com/apache/spark/commit/359de15534172702cecee6ec717e86b313f8b8b7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-964950409
Thanks @HyukjinKwon @itholic @srowen @xinrong-databricks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-965987766
Forgot to cc other people like @BryanCutler @viirya who also work on PySpark side. Now we will apply auto-formatting via `dev/reformat-python`, and it will be verified via `dev/linter-python`.
For a bit of more background: this is a lot of changes but it boosts the development cycle given the experience in Databricks (e.g., Koalas) so we decided to get this in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-964128493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-947505924
**[Test build #144458 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144458/testReport)** for PR 34297 at commit [`d7b1f7b`](https://github.com/apache/spark/commit/d7b1f7b9e61f59f50c0debdb312382a23eafbe1e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on a change in pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #34297:
URL: https://github.com/apache/spark/pull/34297#discussion_r739487919
##########
File path: python/pyproject.toml
##########
@@ -23,3 +23,9 @@ testpaths = [
"pyspark/sql/tests/typing",
"pyspark/ml/typing",
]
+
+[tool.black]
+line-length = 100
+target-version = ['py37']
+include = '\.pyi?$'
+extend-exclude = 'cloudpickle'
Review comment:
To exclude `python/pyspark/python` that is already in `.gitignore`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-954838807
**[Test build #144760 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144760/testReport)** for PR 34297 at commit [`d6c16de`](https://github.com/apache/spark/commit/d6c16de823f8399c31fa5da6c0ad8cea6fcb47d0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-954881231
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49229/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-959472797
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144877/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-958993806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-958993806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-955078423
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144767/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-954950424
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144760/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-959068629
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49347/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-959400322
**[Test build #144877 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144877/testReport)** for PR 34297 at commit [`a7386a4`](https://github.com/apache/spark/commit/a7386a452efedf59af655a3614f951346ede8361).
* This patch passes all tests.
* This patch **does not merge cleanly**.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-958993806
**[Test build #144877 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144877/testReport)** for PR 34297 at commit [`a7386a4`](https://github.com/apache/spark/commit/a7386a452efedf59af655a3614f951346ede8361).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-947627343
**[Test build #144458 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144458/testReport)** for PR 34297 at commit [`d7b1f7b`](https://github.com/apache/spark/commit/d7b1f7b9e61f59f50c0debdb312382a23eafbe1e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-947629042
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144458/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-945839312
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48845/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-964048248
**[Test build #145023 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145023/testReport)** for PR 34297 at commit [`9db9dfe`](https://github.com/apache/spark/commit/9db9dfe989a31cf70ffd28c050ef635fd8263402).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a change in pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
itholic commented on a change in pull request #34297:
URL: https://github.com/apache/spark/pull/34297#discussion_r745298948
##########
File path: python/pyspark/worker.py
##########
@@ -581,19 +627,18 @@ def main(infile, outfile):
if bid >= 0:
if needs_broadcast_decryption_server:
read_bid = read_long(broadcast_sock_file)
- assert(read_bid == bid)
- _broadcastRegistry[bid] = \
- Broadcast(sock_file=broadcast_sock_file)
+ assert read_bid == bid
+ _broadcastRegistry[bid] = Broadcast(sock_file=broadcast_sock_file)
Review comment:
qq: Does black also fix this kind of changes automatically ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-950004282
**[Test build #144549 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144549/testReport)** for PR 34297 at commit [`34559c9`](https://github.com/apache/spark/commit/34559c901b93221f2866030248fcd1f3dfa82e0d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-947594427
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48931/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-964182005
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145023/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-950016605
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49020/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-955047090
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49236/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on a change in pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on a change in pull request #34297:
URL: https://github.com/apache/spark/pull/34297#discussion_r739398757
##########
File path: python/pyproject.toml
##########
@@ -23,3 +23,9 @@ testpaths = [
"pyspark/sql/tests/typing",
"pyspark/ml/typing",
]
+
+[tool.black]
+line-length = 100
+target-version = ['py37']
+include = '\.pyi?$'
+extend-exclude = 'cloudpickle'
Review comment:
Out of curiosity, why don't we use `exclude` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-954910803
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49229/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-955073650
**[Test build #144767 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144767/testReport)** for PR 34297 at commit [`70b1ed0`](https://github.com/apache/spark/commit/70b1ed0f5d4942664ab9d0fb99c1e554eefd54ab).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 edited a comment on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
zero323 edited a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-963752778
> I'm okay with this change. @zero323 would you mind resolving the conflicts?
I'll take a look at this tomorrow @HyukjinKwon . I assume we want to move `pyproject.toml` to `dev`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic edited a comment on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
itholic edited a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-963832298
Which version of `black` do you use for this changes ? We should use `21.5b2`.
Looks like it's correct version, but just for double checking just in case. :-)
Otherwise, LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-964111695
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49494/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-964179638
**[Test build #145023 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145023/testReport)** for PR 34297 at commit [`9db9dfe`](https://github.com/apache/spark/commit/9db9dfe989a31cf70ffd28c050ef635fd8263402).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-945898606
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144370/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-947018020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-955000908
**[Test build #144767 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144767/testReport)** for PR 34297 at commit [`70b1ed0`](https://github.com/apache/spark/commit/70b1ed0f5d4942664ab9d0fb99c1e554eefd54ab).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-947018020
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144422/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-947552063
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48931/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-947594394
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48931/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-947594427
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48931/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-950029775
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49020/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-958993806
**[Test build #144877 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144877/testReport)** for PR 34297 at commit [`a7386a4`](https://github.com/apache/spark/commit/a7386a452efedf59af655a3614f951346ede8361).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-964048248
**[Test build #145023 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145023/testReport)** for PR 34297 at commit [`9db9dfe`](https://github.com/apache/spark/commit/9db9dfe989a31cf70ffd28c050ef635fd8263402).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as formatter for PySpark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-944837197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-945883010
**[Test build #144370 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144370/testReport)** for PR 34297 at commit [`abb4484`](https://github.com/apache/spark/commit/abb4484ad3c72700aab036323acba6eb26d91d80).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-945898606
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144370/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-955025055
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49236/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-954910803
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49229/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-959472797
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144877/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-959269982
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49347/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as formatter for
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-944677894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-963752778
> I'm okay with this change. @zero323 would you mind resolving the conflicts?
I'll take a look at this tomorrow. I assume we want to move `pyproject.toml` to `dev`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-950033141
**[Test build #144549 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144549/testReport)** for PR 34297 at commit [`34559c9`](https://github.com/apache/spark/commit/34559c901b93221f2866030248fcd1f3dfa82e0d).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-950038362
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144549/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-964176747
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145022/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-964182005
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145023/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34297: [SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-964948062
Merged to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-944680717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-945773149
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48845/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-946910459
@srowen
> It's a good idea, but the amount of code churn is quite large (which causes back-port problems). Is there a subset of rules to enforce for now that requires much less change?
We could skip trailing commas (`--skip-magic-trailing-comma`) and quotes rewriting (`--skip-string-normalization`), but while accounting for majority of diffs, these are mostly cosmetic changes and shouldn't add much overhead to backporting.
In general, I was thinking about applying `black` to all active past branches (or even inactive, if there is use case for that). For branches, that have no inline annotations, this is fully automated process. This way, we'll have consistent formatting and small inter-branch diffs (yay!) to offset cost of the change.
Also, I won't lie ‒ I proposed this now, even though I thought about it for years, because we inlining annotations will impact backporting for the time being (suffer once) and, again, smaller diffs can make process easier as well (I've introduced `black` to stubs, primarily to address painful diffs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-947045784
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48895/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34297: [WIP][SPARK-37022][PYTHON] Use black as a formatter for PySpark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34297:
URL: https://github.com/apache/spark/pull/34297#issuecomment-947034261
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48895/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org