You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by "szymon-czapracki (via GitHub)" <gi...@apache.org> on 2024/04/08 10:11:56 UTC
[PR] nimble/bttester: Make adv parameters global & small fixes [mynewt-nimble]
szymon-czapracki opened a new pull request, #1749:
URL: https://github.com/apache/mynewt-nimble/pull/1749
Make advertising parameters global for in BAP test app.
MYNEWT_VAL is corrected in multiple places for an up-to-date name.
Missing semicolon and invalid function name are fixed in btp_bap.c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/bttester: Make adv parameters global & small fixes [mynewt-nimble]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on code in PR #1749:
URL: https://github.com/apache/mynewt-nimble/pull/1749#discussion_r1559288316
##########
apps/bttester/syscfg.yml:
##########
@@ -97,6 +97,8 @@ syscfg.vals:
BLE_ISO_MAX_BISES: 1
BLE_ISO_MAX_BIGS: 1
BLE_EXT_ADV: 1
+ BLE_PHY_2M: 1
+ BLE_EXT_ADV_MAX_SIZE: 261
Review Comment:
why is this needed? it is quite big value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/bttester: Make adv parameters global & small fixes [mynewt-nimble]
Posted by "szymon-czapracki (via GitHub)" <gi...@apache.org>.
szymon-czapracki commented on PR #1749:
URL: https://github.com/apache/mynewt-nimble/pull/1749#issuecomment-2044724585
@KKopyscinski @sjanc FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/bttester: Make adv parameters global & small fixes [mynewt-nimble]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc merged PR #1749:
URL: https://github.com/apache/mynewt-nimble/pull/1749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/bttester: Make adv parameters global & small fixes [mynewt-nimble]
Posted by "szymon-czapracki (via GitHub)" <gi...@apache.org>.
szymon-czapracki commented on code in PR #1749:
URL: https://github.com/apache/mynewt-nimble/pull/1749#discussion_r1560818956
##########
apps/bttester/syscfg.yml:
##########
@@ -97,6 +97,8 @@ syscfg.vals:
BLE_ISO_MAX_BISES: 1
BLE_ISO_MAX_BIGS: 1
BLE_EXT_ADV: 1
+ BLE_PHY_2M: 1
+ BLE_EXT_ADV_MAX_SIZE: 261
Review Comment:
Updated the value to `40` - previous value was an overkill. This is necessary for broadcast, and specially extended advertising configuration in broadcast bttester application.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org