You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "sgilmore10 (via GitHub)" <gi...@apache.org> on 2023/07/25 19:09:30 UTC

[GitHub] [arrow] sgilmore10 opened a new pull request, #36875: GH-36874: [MATLAB] Move type constructor functions from the `arrow.type` package to `arrow` package

sgilmore10 opened a new pull request, #36875:
URL: https://github.com/apache/arrow/pull/36875

   …package
   
   
   <!--
   Thanks for opening a pull request!
   If this is your first pull request you can find detailed information on how 
   to contribute here:
     * [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
     * [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
   
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
   
   Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename the pull request title in the following format?
   
       GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   In the case of PARQUET issues on JIRA the title also supports:
   
       PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   -->
   
   ### Rationale for this change
   
   When working on PR #36855, we realized it would be better to place all recommended public/user-facing APIs in the top-level `arrow` package. That's why we added the function `arrow.field` in the top-level `arrow` package instead of under `arrow.type`, even though the `Field` class is within `arrow.type` package.
   
   ### What changes are included in this PR?
   
   1. Moved the type constructor functions (`arrow.type.int8()`, `arrow.type.timestamp()`, etc) from the `arrow.type` package to the `arrow package`. 
   
   **Example: Old Way to Create a `Timestamp` Object:**
   
   ```matlab
   >> type = arrow.type.timestmap(TimeUnit="nanosecond");
   ```
   
   **Example: New Way to Create a `Timestamp` Object:**
   
   ```matlab
   >> type = arrow.timestmap(TimeUnit="nanosecond");
   ```
   
   ### Are these changes tested?
   
   Changes are covered by existing tests.
   
   ### Are there any user-facing changes?
   
   Yes. 
   
   NOTE: This is a breaking change, but the MATLAB interface is not yet stable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] kevingurney merged pull request #36875: GH-36874: [MATLAB] Move type constructor functions from the `arrow.type` package to `arrow` package

Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney merged PR #36875:
URL: https://github.com/apache/arrow/pull/36875


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org