[GitHub] [geode] mkevo commented on a change in pull request #5669: GEODE-8655: handling exception on SNIHostName

[GitBox <gi...@apache.org>]

mkevo commented on a change in pull request #5669:
URL: https://github.com/apache/geode/pull/5669#discussion_r515954661



##########
File path: geode-core/src/main/java/org/apache/geode/internal/net/SocketCreator.java
##########
@@ -846,7 +846,14 @@ private boolean setServerNames(SSLParameters modifiedParams, HostAndPort addr) {
         // ignore - we'll see what happens with endpoint validation using a numeric address...
       }
     }
-    serverNames.add(new SNIHostName(hostName));
+    try {
+      serverNames.add(new SNIHostName(hostName));
+    } catch (Exception ex) {

Review comment:
       This issue didn't exist before adding [GEODE-7852](https://issues.apache.org/jira/browse/GEODE-7852).
   I can't find it where it catches this exception from the [ticket description](https://issues.apache.org/jira/browse/GEODE-8655) and where it logs it. This catch is added to handle this exception:
   ` java.lang.IllegalArgumentException: Contains non-LDH ASCII characters`
   I described a failure in the ticket, and need a help to write test for it as it is using ipv6 and TLS. 
   You can try to reproduce it locally. If you need more information to reproduce the issue please contact me via mail or slack.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org