[GitHub] [incubator-yunikorn-core] kingamarton commented on a change in pull request #272: YUNIKORN-573: Make sure all timer go routines are stopped after remov…

[GitBox <gi...@apache.org>]

kingamarton commented on a change in pull request #272:
URL: https://github.com/apache/incubator-yunikorn-core/pull/272#discussion_r632534720



##########
File path: pkg/scheduler/objects/application.go
##########
@@ -1267,6 +1270,7 @@ func (sa *Application) RemoveAllAllocations() []*Allocation {
 	// cleanup allocated resource for app (placeholders and normal)
 	sa.allocatedResource = resources.NewResource()
 	sa.allocatedPlaceholder = resources.NewResource()
+	sa.clearPlaceholderTimer()

Review comment:
       Please clear the state timer as well. This will be probably OK, but just to make sure it is cleared I would call a clear on that as well. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org