You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Santhosh Srinivasan (JIRA)" <ji...@apache.org> on 2009/07/10 02:38:14 UTC
[jira] Created: (PIG-877) Push up filter does not account for added
columns in foreach
Push up filter does not account for added columns in foreach
------------------------------------------------------------
Key: PIG-877
URL: https://issues.apache.org/jira/browse/PIG-877
Project: Pig
Issue Type: Bug
Affects Versions: 0.3.1
Reporter: Santhosh Srinivasan
Fix For: 0.3.1
If a filter follows a foreach that produces an added column then push up filter fails with a null pointer exception.
{code}
...
x = foreach w generate $0, COUNT($1);
y = filter x by $1 > 10;
{code}
In the above example, the column in the filter's expression is an added column. As a result, the optimizer rule is not able to map it back to the input resulting in a null value. The subsequent for loop is failing due to NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-877) Push up filter does not account for added
columns in foreach
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santhosh Srinivasan updated PIG-877:
------------------------------------
Status: Patch Available (was: Open)
> Push up filter does not account for added columns in foreach
> ------------------------------------------------------------
>
> Key: PIG-877
> URL: https://issues.apache.org/jira/browse/PIG-877
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.1
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Fix For: 0.3.1
>
> Attachments: PIG-877.patch
>
>
> If a filter follows a foreach that produces an added column then push up filter fails with a null pointer exception.
> {code}
> ...
> x = foreach w generate $0, COUNT($1);
> y = filter x by $1 > 10;
> {code}
> In the above example, the column in the filter's expression is an added column. As a result, the optimizer rule is not able to map it back to the input resulting in a null value. The subsequent for loop is failing due to NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (PIG-877) Push up filter does not account for
added columns in foreach
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santhosh Srinivasan reassigned PIG-877:
---------------------------------------
Assignee: Santhosh Srinivasan
> Push up filter does not account for added columns in foreach
> ------------------------------------------------------------
>
> Key: PIG-877
> URL: https://issues.apache.org/jira/browse/PIG-877
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.1
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Fix For: 0.3.1
>
>
> If a filter follows a foreach that produces an added column then push up filter fails with a null pointer exception.
> {code}
> ...
> x = foreach w generate $0, COUNT($1);
> y = filter x by $1 > 10;
> {code}
> In the above example, the column in the filter's expression is an added column. As a result, the optimizer rule is not able to map it back to the input resulting in a null value. The subsequent for loop is failing due to NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-877) Push up filter does not account for added
columns in foreach
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santhosh Srinivasan updated PIG-877:
------------------------------------
Attachment: PIG-877.patch
Attached patch fixes the NPE.
> Push up filter does not account for added columns in foreach
> ------------------------------------------------------------
>
> Key: PIG-877
> URL: https://issues.apache.org/jira/browse/PIG-877
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.1
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Fix For: 0.3.1
>
> Attachments: PIG-877.patch
>
>
> If a filter follows a foreach that produces an added column then push up filter fails with a null pointer exception.
> {code}
> ...
> x = foreach w generate $0, COUNT($1);
> y = filter x by $1 > 10;
> {code}
> In the above example, the column in the filter's expression is an added column. As a result, the optimizer rule is not able to map it back to the input resulting in a null value. The subsequent for loop is failing due to NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-877) Push up filter does not account for added
columns in foreach
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santhosh Srinivasan updated PIG-877:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Issue has been fixed.
> Push up filter does not account for added columns in foreach
> ------------------------------------------------------------
>
> Key: PIG-877
> URL: https://issues.apache.org/jira/browse/PIG-877
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.1
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Fix For: 0.3.1
>
> Attachments: PIG-877.patch
>
>
> If a filter follows a foreach that produces an added column then push up filter fails with a null pointer exception.
> {code}
> ...
> x = foreach w generate $0, COUNT($1);
> y = filter x by $1 > 10;
> {code}
> In the above example, the column in the filter's expression is an added column. As a result, the optimizer rule is not able to map it back to the input resulting in a null value. The subsequent for loop is failing due to NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-877) Push up filter does not account for
added columns in foreach
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730525#action_12730525 ]
Santhosh Srinivasan commented on PIG-877:
-----------------------------------------
Its at Optimization time.
> Push up filter does not account for added columns in foreach
> ------------------------------------------------------------
>
> Key: PIG-877
> URL: https://issues.apache.org/jira/browse/PIG-877
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.1
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Fix For: 0.3.1
>
> Attachments: PIG-877.patch
>
>
> If a filter follows a foreach that produces an added column then push up filter fails with a null pointer exception.
> {code}
> ...
> x = foreach w generate $0, COUNT($1);
> y = filter x by $1 > 10;
> {code}
> In the above example, the column in the filter's expression is an added column. As a result, the optimizer rule is not able to map it back to the input resulting in a null value. The subsequent for loop is failing due to NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-877) Push up filter does not account for
added columns in foreach
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730521#action_12730521 ]
Alan Gates commented on PIG-877:
--------------------------------
Is the NPE at run time or optimization time?
> Push up filter does not account for added columns in foreach
> ------------------------------------------------------------
>
> Key: PIG-877
> URL: https://issues.apache.org/jira/browse/PIG-877
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.1
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Fix For: 0.3.1
>
> Attachments: PIG-877.patch
>
>
> If a filter follows a foreach that produces an added column then push up filter fails with a null pointer exception.
> {code}
> ...
> x = foreach w generate $0, COUNT($1);
> y = filter x by $1 > 10;
> {code}
> In the above example, the column in the filter's expression is an added column. As a result, the optimizer rule is not able to map it back to the input resulting in a null value. The subsequent for loop is failing due to NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-877) Push up filter does not account for
added columns in foreach
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729498#action_12729498 ]
Hadoop QA commented on PIG-877:
-------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12413068/PIG-877.patch
against trunk revision 792663.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/120/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/120/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/120/console
This message is automatically generated.
> Push up filter does not account for added columns in foreach
> ------------------------------------------------------------
>
> Key: PIG-877
> URL: https://issues.apache.org/jira/browse/PIG-877
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.1
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Fix For: 0.3.1
>
> Attachments: PIG-877.patch
>
>
> If a filter follows a foreach that produces an added column then push up filter fails with a null pointer exception.
> {code}
> ...
> x = foreach w generate $0, COUNT($1);
> y = filter x by $1 > 10;
> {code}
> In the above example, the column in the filter's expression is an added column. As a result, the optimizer rule is not able to map it back to the input resulting in a null value. The subsequent for loop is failing due to NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-877) Push up filter does not account for
added columns in foreach
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730813#action_12730813 ]
Hudson commented on PIG-877:
----------------------------
Integrated in Pig-trunk #503 (See [http://hudson.zones.apache.org/hudson/job/Pig-trunk/503/])
: Push up filter does not account for added columns in foreach
> Push up filter does not account for added columns in foreach
> ------------------------------------------------------------
>
> Key: PIG-877
> URL: https://issues.apache.org/jira/browse/PIG-877
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.1
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Fix For: 0.3.1
>
> Attachments: PIG-877.patch
>
>
> If a filter follows a foreach that produces an added column then push up filter fails with a null pointer exception.
> {code}
> ...
> x = foreach w generate $0, COUNT($1);
> y = filter x by $1 > 10;
> {code}
> In the above example, the column in the filter's expression is an added column. As a result, the optimizer rule is not able to map it back to the input resulting in a null value. The subsequent for loop is failing due to NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-877) Push up filter does not account for
added columns in foreach
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730529#action_12730529 ]
Alan Gates commented on PIG-877:
--------------------------------
+1, patch looks good.
> Push up filter does not account for added columns in foreach
> ------------------------------------------------------------
>
> Key: PIG-877
> URL: https://issues.apache.org/jira/browse/PIG-877
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.1
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Fix For: 0.3.1
>
> Attachments: PIG-877.patch
>
>
> If a filter follows a foreach that produces an added column then push up filter fails with a null pointer exception.
> {code}
> ...
> x = foreach w generate $0, COUNT($1);
> y = filter x by $1 > 10;
> {code}
> In the above example, the column in the filter's expression is an added column. As a result, the optimizer rule is not able to map it back to the input resulting in a null value. The subsequent for loop is failing due to NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-877) Push up filter does not account for added
columns in foreach
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Gates updated PIG-877:
---------------------------
Affects Version/s: (was: 0.3.1)
0.4.0
Fix Version/s: (was: 0.3.1)
0.4.0
> Push up filter does not account for added columns in foreach
> ------------------------------------------------------------
>
> Key: PIG-877
> URL: https://issues.apache.org/jira/browse/PIG-877
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Fix For: 0.4.0
>
> Attachments: PIG-877.patch
>
>
> If a filter follows a foreach that produces an added column then push up filter fails with a null pointer exception.
> {code}
> ...
> x = foreach w generate $0, COUNT($1);
> y = filter x by $1 > 10;
> {code}
> In the above example, the column in the filter's expression is an added column. As a result, the optimizer rule is not able to map it back to the input resulting in a null value. The subsequent for loop is failing due to NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-877) Push up filter does not account for
added columns in foreach
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730595#action_12730595 ]
Santhosh Srinivasan commented on PIG-877:
-----------------------------------------
Patch has been committed.
> Push up filter does not account for added columns in foreach
> ------------------------------------------------------------
>
> Key: PIG-877
> URL: https://issues.apache.org/jira/browse/PIG-877
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.1
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Fix For: 0.3.1
>
> Attachments: PIG-877.patch
>
>
> If a filter follows a foreach that produces an added column then push up filter fails with a null pointer exception.
> {code}
> ...
> x = foreach w generate $0, COUNT($1);
> y = filter x by $1 > 10;
> {code}
> In the above example, the column in the filter's expression is an added column. As a result, the optimizer rule is not able to map it back to the input resulting in a null value. The subsequent for loop is failing due to NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-877) Push up filter does not account for
added columns in foreach
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729729#action_12729729 ]
Santhosh Srinivasan commented on PIG-877:
-----------------------------------------
The unit test failures are unrelated to the fix.
> Push up filter does not account for added columns in foreach
> ------------------------------------------------------------
>
> Key: PIG-877
> URL: https://issues.apache.org/jira/browse/PIG-877
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.3.1
> Reporter: Santhosh Srinivasan
> Assignee: Santhosh Srinivasan
> Fix For: 0.3.1
>
> Attachments: PIG-877.patch
>
>
> If a filter follows a foreach that produces an added column then push up filter fails with a null pointer exception.
> {code}
> ...
> x = foreach w generate $0, COUNT($1);
> y = filter x by $1 > 10;
> {code}
> In the above example, the column in the filter's expression is an added column. As a result, the optimizer rule is not able to map it back to the input resulting in a null value. The subsequent for loop is failing due to NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.