You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by weiqingy <gi...@git.apache.org> on 2017/01/01 08:53:33 UTC
[GitHub] spark issue #16426: [MINOR] Add `sc.stop()`

Github user weiqingy commented on the issue:

    https://github.com/apache/spark/pull/16426
  
    Hi, @srowen Thanks for the review. I have updated the PR. The current PR is mainly about examples (and two suites: Yarn suite and SparkContext suite). 
    
    I went through the tests. I found many tests have the same issue. For example, each test in [FailureSuite](https://github.com/apache/spark/blob/master/core/src/test/scala/org/apache/spark/FailureSuite.scala#L41) creates \u201c`sc =new SparkContext(\u2026)`\u201d without \u201c`sc.stop()`\u201d. Do you think we should add \u201c`sc.stop()`\u201d for each test case in [FailureSuite](https://github.com/apache/spark/blob/master/core/src/test/scala/org/apache/spark/FailureSuite.scala#L41)? If so, the files below will also be modified, then this PR will modify many files, I am not sure if it is acceptable. For me, I am natural.
    
    ```
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/AccumulatorSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/DistributedSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/DriverSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/ExternalShuffleServiceSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/FailureSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/FileSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/FutureActionSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/ImplicitOrderingSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/InternalAccumulatorSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/JobCancellationSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/MapOutputTrackerSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/ShuffleSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/SortShuffleSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/SparkConfSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/SparkContextInfoSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/SparkContextSchedulerCreationSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/StatusTrackerSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/ThreadingSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/UnpersistSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/broadcast/BroadcastSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/deploy/LogUrlsStandaloneSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/rdd/JdbcRDDSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/scheduler/AdaptiveSchedulingSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/scheduler/CoarseGrainedSchedulerBackendSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/scheduler/ExternalClusterManagerSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/scheduler/OutputCommitCoordinatorIntegrationSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/scheduler/PoolSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/scheduler/ReplayListenerSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/scheduler/SchedulerIntegrationSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/scheduler/TaskContextSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/scheduler/TaskResultGetterSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/serializer/KryoSerializerDistributedSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/serializer/KryoSerializerResizableOutputSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/shuffle/BlockStoreShuffleReaderSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/shuffle/ShuffleDependencySuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/storage/FlatmapIteratorSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/core/src/test/scala/org/apache/spark/util/collection/ExternalSorterSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/sql/core/src/test/scala/org/apache/spark/sql/execution/UnsafeRowSerializerSuite.scala
    /Users/wyang/WorkingSpace/sparkrepo/streaming/src/test/scala/org/apache/spark/streaming/StreamingContextSuite.scala
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org