[GitHub] [airflow] jens-scheffler-bosch commented on pull request #34606: Add pagination to SimpleHttpOperator

["jens-scheffler-bosch (via GitHub)" <gi...@apache.org>]

jens-scheffler-bosch commented on PR #34606:
URL: https://github.com/apache/airflow/pull/34606#issuecomment-1734409289

   Thanks for the contribution! I was not aware of cases where pagination is used until I saw this PR. I don't know how common this is in API Calls and might be very specific.
   As the HTTP operator is very basic and used in many use cases I am not sure whether a pagination function really is best to be suited in the base operator or as proposed an extended Operator inheriting from the SimpleHttpOperator would be better.
   
   Also - to be open - I am not sure whether such function is so common that it makes sense to add it into the code package. I believe (but this is my personal opinion - other opinions welcome!) that this could also be very good placed in a contributor package to keep the basic operator "simple". Python is extensible and the standard operator can easily be used and extended per customer project.
   
   (I am not a committer so my opinion only counts a bit, would be good to get other maintainers opinion on this contribution - also if not in code where such extension could be best placed in.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org