[GitHub] [openmeetings] sebawagner commented on pull request #65: OPENMEETINGS-2278 fix restart of recording and ghost KStream

[GitBox <gi...@apache.org>]

sebawagner commented on pull request #65:
URL: https://github.com/apache/openmeetings/pull/65#issuecomment-618852104


   @solomax it works now!
   
   You can enable the recoridng and it will just start recoring, you can stop it and it will stop recording and only stop sharing if sharing was disabled.
   
   However if you start recording, and then enable sharing while recording, and then stop recording, it will continue to share screen.
   
   You can also share screen and start/stop recording as many times as you want.
   
   The issue with the ghost KStream was because the video-util close closed the stream on the first try. The logic on client side was closing the stream in a way so you couldn't restart. Stopping from Server side actually works better. 
   I'm not quite sure what happens client side its a also a bit confusing, cause if you "just record" on server side you still have a screen-share. Even though you don't create an screen-share event. Its kind of like hidden on the server, until you send the share event. 
   So I think controlling the logic from the server logic seems to work better.
   
   I also did check with a 2nd browser to make sure all screen-share events come through. And also no Zero size or ghost KStreams are created.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org